From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web08.4930.1622111122488863492 for ; Thu, 27 May 2021 03:25:22 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DesOo04q; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622111121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4vMMVJkifAFWH8TNb4HAT1sU7lFoiAxXuqeL8eIkQ0E=; b=DesOo04qUk3ViDxop8g64r8knomd10A02Klienqqz4qteoCZeKooqWHkS2PUSFE9VgmZWg uvnhL9gcMSa/elDP+Jz/rw2MWMjSCQCn+k5mfUircN8ifZsWU5Wmcl5EclWB9zgHiIsI9D NkWQxZhewP9HyDCB5HN3u69rm1XqZw4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-339--y9OLqBtNWq4UP2IszhXMg-1; Thu, 27 May 2021 06:25:20 -0400 X-MC-Unique: -y9OLqBtNWq4UP2IszhXMg-1 Received: by mail-wm1-f72.google.com with SMTP id n20-20020a05600c4f94b029017f371265feso1328498wmq.5 for ; Thu, 27 May 2021 03:25:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4vMMVJkifAFWH8TNb4HAT1sU7lFoiAxXuqeL8eIkQ0E=; b=UT8qkoAzLThUshhtmcJIwjO7wS90G/GcrLmBe46WcZmHDhwXmUSFbcJANQMdzlS/40 oiP3nwx6kP5c3tAPkOR0OCArny3UOXYSBZVoqJgCvAq8b+qoPQEDAHAa6kXajtXOU/X3 6m2pPa4in97LHCwRG0z/BXs0gpytmKRjxbnyA7jLFA/yCcaq4E1FfZn3WM4YKMpTP8t+ tDnWOR3+kLaYjA0eyO36tRMWnAMxOeqRIu1DjOiB4UxfpCRTToWoIZ+v6AMybWsMsrBV grJqInhnpBhlRH5DFim2ZDZKpb/CxfIhqVFSUx6fUsVyaqFY6r3A8DVJocbSqd6U4x0/ jwNA== X-Gm-Message-State: AOAM531MGW7K3inQowfkSkvRDxuj4s9BP6yJkJsDNZ3wQ1k4TDIlthxa PdNS9xP5vZhPrFNl46UOosFf61XnnDOGhxeMEP4c/W9brqBmpX3Yjp0f7a9IkYwU2FxbYaaVyaS 47jEiYo6pTtOCzw== X-Received: by 2002:a05:6000:148:: with SMTP id r8mr2608525wrx.311.1622111118861; Thu, 27 May 2021 03:25:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw+2BFe2O9YD6JWJNsPOaZF52E6QT7OXtrauz28Gqzfm9ZjJ3qEHhklSce+/d3w/Q5TewMBYA== X-Received: by 2002:a05:6000:148:: with SMTP id r8mr2608512wrx.311.1622111118724; Thu, 27 May 2021 03:25:18 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id m9sm2885586wrs.36.2021.05.27.03.25.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 May 2021 03:25:18 -0700 (PDT) Subject: Re: [PATCH 33/43] OvmfPkg/PciHostBridgeLibScan: remove QEMU (fw_cfg) support To: Laszlo Ersek , devel@edk2.groups.io Cc: Anthony Perard , Ard Biesheuvel , Jordan Justen , Julien Grall , Peter Grehan , Rebecca Cran References: <20210526201446.12554-1-lersek@redhat.com> <20210526201446.12554-34-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <99b11c30-1325-52d2-dd11-186abaf865ab@redhat.com> Date: Thu, 27 May 2021 12:25:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210526201446.12554-34-lersek@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 5/26/21 10:14 PM, Laszlo Ersek wrote: > The "OvmfPkg/Library/PciHostBridgeLibScan/PciHostBridgeLibScan.inf" > instance is used in the following platforms in edk2: > > OvmfPkg/Bhyve/BhyveX64.dsc > OvmfPkg/OvmfXen.dsc > > Both platforms define "PcdPciDisableBusEnumeration" with Fixed-at-Build > access method, and TRUE value. Remove the PCD from the > PciHostBridgeLibScan instance, and everything else that is useful only > when the PCD is FALSE. > > In practice, this removes the PciHostBridgeUtilityGetRootBridges() > function call, which is based on fw-cfg; see > "OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c". > > (Note that the dependency on PciHostBridgeUtilityLib remains in place, > given that the PciHostBridgeLibScan instance continues using lower-level > functions from the library that do not depend on fw-cfg.) > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Cc: Peter Grehan > Cc: Philippe Mathieu-Daudé > Cc: Rebecca Cran > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/Library/PciHostBridgeLibScan/PciHostBridgeLibScan.inf | 7 --- > OvmfPkg/Library/PciHostBridgeLibScan/PciHostBridgeLib.c | 63 +------------------- > 2 files changed, 2 insertions(+), 68 deletions(-) Reviewed-by: Philippe Mathieu-Daude