From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.groups.io with SMTP id smtpd.web11.8949.1574099889039738485 for ; Mon, 18 Nov 2019 09:58:09 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=PmO/XmET; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.128.68, mailfrom: pete@akeo.ie) Received: by mail-wm1-f68.google.com with SMTP id z26so216468wmi.4 for ; Mon, 18 Nov 2019 09:58:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=MvdwZlyUgPmrHv5puVA5kWT4JnghlKx3juLk00lTCRU=; b=PmO/XmET1UM4B69UeaslpsE9W93LQ6t1fCMSR+ONdhiwFulx4+ui1VhmbwbxWQKoLo sV61OVxoEfdPcdBM4vjAn+7VMkPkEjdoxycl6HNIzSdctIGhJVjtoZDoce6as3ljJXSy OfvTRKbmR38Na89ScQYnEDMjcI6QkkNWPqzgldJ3GXvrbeF7HNYGDrcLIJhWUZhUsRyf uodf/GlKLXEhFlWXDWkqDi0Lc38zfUmdOj5FLuFjtMLR7N/ZBkiKGiImwmU0C+grjvhR Fa4/MN7VX8MlF0buVitF1pLzm8tNrH37EvJn8q1flA75MK7wx2/yPKVqzmWvWLjsZBm6 t+xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MvdwZlyUgPmrHv5puVA5kWT4JnghlKx3juLk00lTCRU=; b=cHK4JYuUEaxLSfKte/JYt+xeX9b8O5nBhNgnHl4kRyTPHk5IH0eC+caqrtjoINFJbM Mae78Wf4GtHHG0/d9Zg5wzF7Eow2bZGCPXI75KsE36u/NpP+k/efwsFFjdhNfEXGn1Wn KADwVFsPPf3BkLHxxfmkCJom7HDYfSep9ze9yyqRnkeQTk5F7NuhSpE/lh7Wo4j/WP1W aPnwhZ52ArSSzbs3cnHj0wTc0u+5w1ln2o7jGTJChmHq6NC0y1F7CL2MyXME5qb0OHzu kflLKtMxtgl+Cz6tlz9WtHFC0lKbIbcs7iEwdrnL/qxDZWBN3RM7g8FKoO0z5Y6jfc/s 36mQ== X-Gm-Message-State: APjAAAUYFEgFIfcdLd6vdgQSBobNBkBbPLtVEQUHgQohq3CsMbyizoOe QwJ1mEV5edtLdMCgrQmRTjuAbw== X-Google-Smtp-Source: APXvYqw9t0cUP2lnbgKIguLCp2b8LlZW2arJjsaTG5pElW+ZFeVipPPs1DNCuymXfBaIu4tLkZHJhw== X-Received: by 2002:a1c:4606:: with SMTP id t6mr301377wma.73.1574099887618; Mon, 18 Nov 2019 09:58:07 -0800 (PST) Return-Path: Received: from [10.0.0.122] ([84.203.67.47]) by smtp.googlemail.com with ESMTPSA id x205sm181887wmb.5.2019.11.18.09.58.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Nov 2019 09:58:06 -0800 (PST) Subject: Re: [edk2-platforms][PATCH 1/8] Platform/RPi: Add model family detection To: Leif Lindholm Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org, philmd@redhat.com References: <20191114160740.10072-1-pete@akeo.ie> <20191114160740.10072-2-pete@akeo.ie> <20191118175156.GX7323@bivouac.eciton.net> From: "Pete Batard" Message-ID: <99b30bf5-a9c6-62aa-f7e2-7db9c2bc9848@akeo.ie> Date: Mon, 18 Nov 2019 17:58:05 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <20191118175156.GX7323@bivouac.eciton.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 2019.11.18 17:51, Leif Lindholm wrote: > On Thu, Nov 14, 2019 at 04:07:33PM +0000, Pete Batard wrote: >> From: Samer El-Haj-Mahmoud >> >> Add GetModelFamily to RASPBERRY_PI_FIRMWARE_PROTOCOL. >> >> This uses the board revision to return a numeric value representing >> the RPi family (1=RPi, 2=RPi2, 3=RPi3 and 4=RPi4). >> >> Knowing the Pi family will help us set the SD card routing when we >> introduce support for the Pi 4 and should also be easier to maintain >> than if using individual model detection. >> >> Also add a missing entry for the "Raspberry Pi Compute Module 3+" in >> RpiFirmwareGetModelName (). > > Can you drop the above line and include the below as 1/? in v2? Okay. Note that since you requested alphabetical for PCDs, I'm going to have an "Also" in 2/ (now 3/) since the existing PCDs in Platform/RaspberryPi/Library/PlatformLib/PlatformLib.inf are out of alphabetical order. I sure hope you're not going to ask me to split this extra reordering into a separate commit... Regards, /Pete > > / > Leif > > From 59f01ff36ac7918e9ce166acbd3e963f638ab4b1 Mon Sep 17 00:00:00 2001 > From: Samer El-Haj-Mahmoud > Date: Mon, 18 Nov 2019 17:47:06 +0000 > Subject: [PATCH edk2-platforms 1/1] Platform/RPi: Add missing model name > > add a missing entry for the "Raspberry Pi Compute Module 3+" in > RpiFirmwareGetModelName (). > > Signed-off-by: Leif Lindholm > --- > Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c > index 9b4aa068857c..dcb434fabefe 100644 > --- a/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c > +++ b/Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c > @@ -1,5 +1,6 @@ > /** @file > * > + * Copyright (c) 2019, ARM Limited. All rights reserved. > * Copyright (c) 2017-2018, Andrei Warkentin > * Copyright (c) 2016, Linaro, Ltd. All rights reserved. > * > @@ -595,6 +596,8 @@ RpiFirmwareGetModelName ( > return "Raspberry Pi 3 Model B+"; > case 0x0E: > return "Raspberry Pi 3 Model A+"; > + case 0x10: > + return "Raspberry Pi Compute Module 3+"; > case 0x11: > return "Raspberry Pi 4 Model B"; > default: >