From: "Ni, Ruiyu" <ruiyu.ni@Intel.com>
To: edk2-devel@lists.01.org
Subject: Re: [Patch v3 2/3] UefiCpuPkg/MpInitLib: Use BSP uCode for APs if possible.
Date: Tue, 17 Jul 2018 18:00:16 +0800 [thread overview]
Message-ID: <99bd3200-c53d-8dd2-16ae-823b0cff3bcc@Intel.com> (raw)
In-Reply-To: <20180716030851.13752-3-eric.dong@intel.com>
On 7/16/2018 11:08 AM, Eric Dong wrote:
> +
> + if (IsBspCallIn && (LatestRevision != 0)) {
> + CpuMpData->ProcessorSignature = Eax.Uint32;
> + CpuMpData->ProcessorFlags = ProcessorFlags;
> + CpuMpData->MicrocodeDataAddress = (UINTN) MicrocodeData;
> + CpuMpData->MicrocodeRevision = LatestRevision;
> + DEBUG ((DEBUG_INFO, "BSP Microcode:: signature [0x%08x], ProcessorFlags [0x%08x], \
> + MicroData [0x%08x], Revision [0x%08x]\n", Eax.Uint32, ProcessorFlags, (UINTN) MicrocodeData, LatestRevision));
> + }
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
Can you add more comments for the above logic when check in the patch?
And make the "=" aligned.
--
Thanks,
Ray
next prev parent reply other threads:[~2018-07-17 9:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 3:08 [Patch v3 0/3] Optimize load uCode performance Eric Dong
2018-07-16 3:08 ` [Patch v3 1/3] UefiCpuPkg/MpInitLib: Relocate uCode to memory to save time Eric Dong
2018-07-17 10:02 ` Ni, Ruiyu
2018-07-16 3:08 ` [Patch v3 2/3] UefiCpuPkg/MpInitLib: Use BSP uCode for APs if possible Eric Dong
2018-07-17 10:00 ` Ni, Ruiyu [this message]
2018-07-16 3:08 ` [Patch v3 3/3] UefiCpuPkg/MpInitLib: Load uCode once for each core Eric Dong
2018-07-17 10:02 ` Ni, Ruiyu
2018-07-17 14:07 ` Laszlo Ersek
2018-07-18 0:11 ` Dong, Eric
2018-07-19 4:42 ` Ni, Ruiyu
2018-07-17 16:38 ` [Patch v3 0/3] Optimize load uCode performance Laszlo Ersek
2018-07-17 19:08 ` Laszlo Ersek
2018-07-18 0:18 ` Dong, Eric
-- strict thread matches above, loose matches on Subject: below --
2018-07-13 0:47 Eric Dong
2018-07-13 0:47 ` [Patch v3 2/3] UefiCpuPkg/MpInitLib: Use BSP uCode for APs if possible Eric Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99bd3200-c53d-8dd2-16ae-823b0cff3bcc@Intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox