From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EDB8920968909 for ; Tue, 17 Jul 2018 02:59:45 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jul 2018 02:59:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,365,1526367600"; d="scan'208";a="72033081" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.4]) ([10.239.9.4]) by fmsmga004.fm.intel.com with ESMTP; 17 Jul 2018 02:59:44 -0700 To: edk2-devel@lists.01.org References: <20180716030851.13752-1-eric.dong@intel.com> <20180716030851.13752-3-eric.dong@intel.com> From: "Ni, Ruiyu" Message-ID: <99bd3200-c53d-8dd2-16ae-823b0cff3bcc@Intel.com> Date: Tue, 17 Jul 2018 18:00:16 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.0 MIME-Version: 1.0 In-Reply-To: <20180716030851.13752-3-eric.dong@intel.com> Subject: Re: [Patch v3 2/3] UefiCpuPkg/MpInitLib: Use BSP uCode for APs if possible. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jul 2018 09:59:46 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 7/16/2018 11:08 AM, Eric Dong wrote: > + > + if (IsBspCallIn && (LatestRevision != 0)) { > + CpuMpData->ProcessorSignature = Eax.Uint32; > + CpuMpData->ProcessorFlags = ProcessorFlags; > + CpuMpData->MicrocodeDataAddress = (UINTN) MicrocodeData; > + CpuMpData->MicrocodeRevision = LatestRevision; > + DEBUG ((DEBUG_INFO, "BSP Microcode:: signature [0x%08x], ProcessorFlags [0x%08x], \ > + MicroData [0x%08x], Revision [0x%08x]\n", Eax.Uint32, ProcessorFlags, (UINTN) MicrocodeData, LatestRevision)); > + } Reviewed-by: Ruiyu Ni Can you add more comments for the above logic when check in the patch? And make the "=" aligned. -- Thanks, Ray