From: Alan Ott <alan@softiron.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Leif Lindholm <leif.lindholm@linaro.org>,
Thomas Panakamattam Abraham <thomas.abraham@arm.com>,
edk2-devel-groups-io <devel@edk2.groups.io>,
Alan Ott <alan@softiron.co.uk>
Cc: Robin Murphy <robin.murphy@arm.com>,
Ruiyu Ni <ruiyu.ni@intel.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
Andrew Fish <afish@apple.com>
Subject: Re: [edk2] [RFC PATCH] OptionRomPkg: import MarvelYukonDxe driver
Date: Fri, 24 May 2019 09:52:31 -0400 [thread overview]
Message-ID: <99c13c94-9dd6-7eb2-beee-10a6d898d7c8@softiron.com> (raw)
In-Reply-To: <CAKv+Gu8MOxU8L7+9auObUzs16Sot6VZi4dmznJQjgm+ZUATUGg@mail.gmail.com>
On 5/23/19 12:36 PM, Ard Biesheuvel wrote:
> (cc the correct list)
>
> On Thu, 23 May 2019 at 17:24, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>> On Tue, May 21, 2019 at 02:38:47PM +0100, Ard Biesheuvel wrote:
>>> (+ Robin)
>>>
>>> On Wed, 19 Apr 2017 at 15:25, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>>>> The Marvell Yukon Ethernet controller driver has existed in
>>>> OpenPlatformPkg for a while now. The chip exists on plug-in cards,
>>>> as well as (at least) the ARM Juno development board and the
>>>> Softiron 1000 platform.
>>>>
>>>> Buildable as a standalone driver, also as EBC.
>>>>
>>>> Contributed-under: TianoCore Contribution Agreement 1.0
>>>> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
>>> Given that all of OptionRomPkg has been moved out of edk2 now, can we
>>> resurrect this driver in edk2-platforms/Silicon/Marvell perhaps?
>> Yes. The only thing holding it back was me wishing to either improve
>> on its coding style conformance or at least separate the imported bits
>> from the UEFI glue. The history of that driver isn't great.
>>
>> At the same time, as you commented on the DwEmax driver, separation
>> between MAC and PHY would be a nice thing to have, and that driver
>> also doesn't.
>>
> Yes, but since no generic abstraction exists today, this is going to
> be a longer term effort anyway, and so it shouldn't block
> reintroduction of this driver.
>
>> Then again, the driver is fairly well tested and seems to work OK, so
>> if someone was to resubmit the final version from
>> https://git.linaro.org/uefi/OpenPlatformPkg.git, reworked for
>> edk2-platforms, I might just go along with it.
>>
> OK, so taking the existing code and making it build in edk2-platforms
> is not going to be a huge amount of work, and I'm happy to look into
> that, provided that there is a point to doing so.
>
> Robin brought this up so I assume he has an interest in this.
>
> Thomas, Alan, could you comment as well, please?
It sounds good to me. The driver worked for us on OverDrive 1000 and
iirc worked for others on Juno.
Alan.
prev parent reply other threads:[~2019-05-24 13:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 14:25 [RFC PATCH] OptionRomPkg: import MarvelYukonDxe driver Leif Lindholm
[not found] ` <CAKv+Gu_O20d=vrNb6pgXQRcforCZk=ocTMZEcY48=ECSxLxbQw@mail.gmail.com>
[not found] ` <20190523162443.eqbgnfqbrndc3t7e@bivouac.eciton.net>
2019-05-23 16:36 ` [edk2] " Ard Biesheuvel
2019-05-24 13:52 ` Alan Ott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99c13c94-9dd6-7eb2-beee-10a6d898d7c8@softiron.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox