public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, ardb@kernel.org
Cc: Michael Kinney <michael.d.kinney@intel.com>,
	Taylor Beebe <t@taylorbeebe.com>,
	Oliver Smith-Denny <osd@smith-denny.com>
Subject: Re: [edk2-devel] another broken PR
Date: Sun, 8 Oct 2023 11:07:48 +0200	[thread overview]
Message-ID: <99c31ee6-cf3a-3346-cfcb-b0d10b5f2dea@redhat.com> (raw)
In-Reply-To: <CAMj1kXFJzzhcg4Mf+C+vFRGsQkBOePY4swScxhoHOx79r+V-7Q@mail.gmail.com>

On 10/7/23 13:33, Ard Biesheuvel wrote:
> On Sat, 7 Oct 2023 at 02:26, Michael Kubacki
> <mikuback@linux.microsoft.com> wrote:
>>
>> On 10/6/2023 8:18 PM, Michael Kubacki wrote:
>>> On 10/6/2023 7:17 PM, Michael Kubacki wrote:
>>>> https://edk2.groups.io/g/devel/message/109370
>>>>
>>> I am planning to quickly merge that series (with its R-b) when PR checks
>>> are completed to unblock CI.
>>
>> Merged to master in commits 6439c73 and 82191f8.
> 
> Thanks for getting this fixed quickly.

+1, thanks for that!

Out of curiosity, is there a ticket somewhere with details about the
python 3.12 incompatibilities in the scripts? (Asking "somewhere"
because I don't know if the issues are in tianocore/containers,
tianocore/edk2-pytool-extensions, tianocore/edk2-pytool-library, or
somewhere else.)

Thanks!
Laszlo

> 
> 
>>>
>>>> On 10/6/2023 6:54 PM, Michael Kubacki wrote:
>>>>> I think this is related to the fact that the latest VM images
>>>>> switched over to Python 3.12 and the minor version is not fixed to 11.
>>>>>
>>>>>    C:\hostedtoolcache\windows\Python\3.12.0
>>>>>
>>>>> I can send a patch to fix the minor version to 3.11 and then the
>>>>> transition to 3.12 can take place with more time to evaluate the
>>>>> changes needed.
>>>>>
>>>>> Thanks,
>>>>> Michael
>>>>>
>>>>> On 10/6/2023 6:50 PM, Ard Biesheuvel wrote:
>>>>>> Could someone please explain what went wrong this time? Many of the
>>>>>> tests are failing, and i don't see a 're-run failed tests' button.
>>>>>>
>>>>>> https://github.com/tianocore/edk2/pull/4893
>>>>>
>>>>>
>>>>>
>>>>>
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109387): https://edk2.groups.io/g/devel/message/109387
Mute This Topic: https://groups.io/mt/101808372/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



      reply	other threads:[~2023-10-08  9:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-06 22:50 [edk2-devel] another broken PR Ard Biesheuvel
2023-10-06 22:54 ` Michael Kubacki
2023-10-06 22:54 ` Taylor Beebe
     [not found] ` <178BA69DA6D10040.24994@groups.io>
2023-10-06 23:17   ` Michael Kubacki
2023-10-07  0:18     ` Michael Kubacki
2023-10-07  0:26       ` Michael Kubacki
2023-10-07 11:33         ` Ard Biesheuvel
2023-10-08  9:07           ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99c31ee6-cf3a-3346-cfcb-b0d10b5f2dea@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox