From: Rebecca Cran <rebecca@bluestop.org>
To: edk2-devel@lists.01.org, Yonghong Zhu <yonghong.zhu@intel.com>,
Liming Gao <liming.gao@intel.com>
Subject: Re: [PATCH] Fix a couple of build errors in BaseTools when using gcc 8
Date: Sun, 27 May 2018 21:48:03 -0600 [thread overview]
Message-ID: <99c666d5-06f6-38fb-8e05-0dbd343959db@bluestop.org> (raw)
In-Reply-To: <ba390085-2a3f-a22d-dd72-a771da19b6d8@bluestop.org>
On 05/27/18 21:34, Rebecca Cran wrote:
> The change from strncpy to memcpy is because from the length argument it
> appears that the contents of "CompAddress" shouldn't be NUL-terminated.
>
> The change to the comparison is because mStringFileName is a pointer,
> and comparing it against '\0' doesn't make sense. It seems the author
> meant for the first character to be compared against NUL.
>
Sorry, please ignore this: I was working against a tree that was last
updated in 2015, so this patch isn't applicable.
--
Rebecca Cran
prev parent reply other threads:[~2018-05-28 3:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-28 3:28 [PATCH] Fix a couple of build errors in BaseTools when using gcc 8 Rebecca Cran
2018-05-28 3:34 ` Rebecca Cran
2018-05-28 3:48 ` Rebecca Cran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99c666d5-06f6-38fb-8e05-0dbd343959db@bluestop.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox