From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web09.4663.1662157710461168553 for ; Fri, 02 Sep 2022 15:28:30 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=k86u1mNF; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 22FEC20477A5; Fri, 2 Sep 2022 15:28:29 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 22FEC20477A5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1662157709; bh=e701u9OpVBp8y1jQFko/IJsJJR2p44uGYq1xvkwEXTI=; h=Date:Subject:From:To:Cc:Reply-To:References:In-Reply-To:From; b=k86u1mNFEq0UzRJcskCWFnTUNAAAuvRfpE4u/OAc5N6rGbouYuRMqT66lsJGS6QSe tal06vmCP+GTbxmgqeS1rxxHDygawlq8GoGad9hxnNejlcUkGcmtUAi3hDnwFGHR70 L150CIgIKEYziZNObpj421rZBN+DJUMnxpn6wSOw= Message-ID: <99cbd2a3-0aae-4a49-c311-29abac0fd6d3@linux.microsoft.com> Date: Fri, 2 Sep 2022 18:28:28 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [edk2-devel] [PATCH v3 0/8] Fix imbalanced debug macros From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann , David Woodhouse , "Ni, Ray" Reply-To: devel@edk2.groups.io, mikuback@linux.microsoft.com References: <17112B4EDBB29064.15579@groups.io> In-Reply-To: <17112B4EDBB29064.15579@groups.io> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello OvmfPkg & FatPkg maintainers, This series only needs a Reviewed-by from these packages. It should take less than a couple minutes of your time. Thanks, Michael On 9/2/2022 6:21 PM, Michael Kubacki wrote: > From: Michael Kubacki > > After noticing a few occurrences of DEBUG macros with a mismatched > number of arguments, I wrote a script to automatically detect this. > > This patch series is the result of matches found by the script. > > In some cases it is not obvious what was originally intended so I > have attempted to capture what I believe was the original author's > intention. > > V3 Changes: > Updated R-b tags. > 1. ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c: > - Repeated BufferSizeInBytes argument per Leif's feedback > 2. MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.c: > - Fixed an additional error on Line 267 > > V2 Changes: > These additional errors were found while finishing testing of > the script. > > 1. Add DynamicTablesPkg/AcpiPpttLibArm patch for the change in > - DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c > 2. Update MdeModulePkg patch to include the change in > - MdeModulePkg/Universal/CapsulePei/UefiCapsule.c > 3. Add following to the RedfishPkg fix patch: > - RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > - RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c > 4. Add NetworkPkg patch for the change in > - NetworkPkg/TcpDxe/SockInterface.c > 5. Add OvmfPkg patch for the change in > - OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c > > Cc: Abner Chang > Cc: Alexei Fedorov > Cc: Ard Biesheuvel > Cc: Dandan Bi > Cc: David Woodhouse > Cc: Gerd Hoffmann > Cc: Guomin Jiang > Cc: Hao A Wu > Cc: Jian J Wang > Cc: Jiaxin Wu > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Leif Lindholm > Cc: Liming Gao > Cc: Maciej Rabeda > Cc: Nickle Wang > Cc: Qi Zhang > Cc: Rahul Kumar > Cc: Ray Ni > Cc: Sami Mujawar > Cc: Siyuan Fu > Signed-off-by: Michael Kubacki > > Michael Kubacki (8): > ArmPlatformPkg/NorFlashDxe: Remove unused debug print specifier > FatPkg/FatPei: Remove extraneous debug message argument > MdeModulePkg: Fix imbalanced debug macros > RedfishPkg/RedfishRestExDxe: Remove extra debug macro argument > SecurityPkg/SmmTcg2PhysicalPresenceLib: Add missing debug print > specifier > DynamicTablesPkg/AcpiPpttLibArm: Fix debug macro arguments > NetworkPkg/TcpDxe: Fix debug macro arguments > OvmfPkg/LegacyBootManagerLib: Fix debug macro arguments > > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c | 4 ++-- > DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c | 3 +-- > FatPkg/FatPei/Gpt.c | 2 +- > MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.c | 2 +- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 2 +- > MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c | 8 ++++---- > MdeModulePkg/Core/Dxe/Image/Image.c | 2 +- > MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgressLibGraphics.c | 2 +- > MdeModulePkg/Universal/CapsulePei/UefiCapsule.c | 2 +- > NetworkPkg/TcpDxe/SockInterface.c | 12 ++---------- > OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c | 6 +++--- > RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 6 +++--- > RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 2 +- > RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c | 2 +- > SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalPresenceLibCommon.c | 2 +- > 15 files changed, 24 insertions(+), 33 deletions(-) >