From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mx.groups.io with SMTP id smtpd.web10.24419.1683607567106936173 for ; Mon, 08 May 2023 21:46:07 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm1 header.b=PNSWYqIN; spf=pass (domain: bsdio.com, ip: 64.147.123.19, mailfrom: rebecca@bsdio.com) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id F1C82320082A; Tue, 9 May 2023 00:46:05 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 09 May 2023 00:46:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1683607565; x=1683693965; bh=5vlL2sYRhFWPS5AY9EvnKotPLI3+5AJIOdr wjdTuAnA=; b=PNSWYqINz/bcMe1ilfM6/UsACg5V7TDlF9LDyC4PYykCMXRypz+ PVehvf3zVdVkUhh5xw2WXVWy+fgXPwxGjJQIiRDdBrcFIHxTbWFgQqJ2I0gwbADw Uy4pKnV/SMywBVycKZxWFLVdW7cNnknq1q6Yf8IMGrFjt0wSyKPH8p117I/0HjmJ QkIBf+uRfc2gYXvyxHb1j07wHfFZ48XYLcIsMW386zM/195b52H9T24z17V1+8/j 2IUzeDG2AIIls7by+HbL43YJGCQZRWFBqONrWZIqdiIVhOOs7p6wek1KRuNJIof8 uNk8eeoHvxbmWSo2luIJbOMbs+/leOQDrPQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1683607565; x= 1683693965; bh=5vlL2sYRhFWPS5AY9EvnKotPLI3+5AJIOdrwjdTuAnA=; b=A dkXs7O+cw60JIt70pPAs68wG1Z+NaeiTeQlVDJNTvqlmBUqqLIe4Z9HO30TQpmPS hhkeJu0LqdW409AiIzgziEVPjRKcs3f8W1rHNrRrNSY+P9Us9Fhy+rVkIeliAn5P DrPyht5ul9K4QCVEd+xxGGKdgm+rfwp0jbMxoGixdipNos3gUdeJ80lPxR5Q0hZm qfh5AOGWqdkgsWI8HKwALcMnHkfCOfFCSzGZGTDSV8gZvS5GOTBcmdv84FDtV/qN L0gdXhvfEX+cKfOgveGpzdlP0LwghKMWzE3GNbAyj1SYnhzHQB9tApD9AXP4ZpQl x7kGhj/gyRwJLHFONcEvQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeefledgkeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhfhjggtgfesthejredttdefjeenucfhrhhomheptfgvsggv tggtrgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrfgrth htvghrnhepleduvedtledtvedvuedugeeuudeiiedtueduvdffueekfeejffduvdetjeev ffdvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprh gvsggvtggtrgessghsughiohdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 9 May 2023 00:46:04 -0400 (EDT) Message-ID: <99d59203-98c4-0310-cad0-8d9c919df203@bsdio.com> Date: Mon, 8 May 2023 22:46:03 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 1/1] CryptoPkg: Delete CLANG35 and CLANG38 build flags; add CLANGDWARF flags To: devel@edk2.groups.io, Jiewen Yao , Jian J Wang , Xiaoyu Lu , Guomin Jiang , Liming Gao References: <20230505134310.1320041-1-rebecca@bsdio.com> From: "Rebecca Cran" In-Reply-To: <20230505134310.1320041-1-rebecca@bsdio.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Could someone from CryptoPkg add a "Reviewed-by" tag please? I'd like this to go into the upcoming edk2-stable202305 release. -- Rebecca Cran On 5/5/23 07:43, Rebecca Cran wrote: > Since CLANG35 and CLANG38 toolchains have been deleted from > tools_def.template, delete the build flags for them from CryptoPkg. > > Since CLANGDWARF has replaced CLANG38, add build flags for it to the > CryptoPkg .inf files. > > Signed-off-by: Rebecca Cran > --- > CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf | 3 +-- > CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 3 +-- > CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 3 +-- > CryptoPkg/Library/BaseCryptLib/SecCryptLib.inf | 3 +-- > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 3 +-- > CryptoPkg/Library/BaseCryptLib/UnitTestHostBaseCryptLib.inf | 3 +-- > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 3 +-- > CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf | 3 +-- > CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 3 +-- > CryptoPkg/Library/OpensslLib/OpensslLibFull.inf | 3 +-- > CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf | 3 +-- > 11 files changed, 11 insertions(+), 22 deletions(-) > > diff --git a/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf b/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > index 5be1724f0852..07b984869629 100644 > --- a/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > @@ -110,8 +110,7 @@ [BuildOptions] > # > # suppress the following warnings so we do not break the build with warnings-as-errors: > # > - GCC:*_CLANG35_*_CC_FLAGS = -std=c99 > - GCC:*_CLANG38_*_CC_FLAGS = -std=c99 > + GCC:*_CLANGDWARF_*_CC_FLAGS = -std=c99 -Wno-error=incompatible-pointer-types > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=incompatible-pointer-types > > XCODE:*_*_*_CC_FLAGS = -std=c99 > diff --git a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > index 66261138a00b..d10c83b53c09 100644 > --- a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > @@ -97,8 +97,7 @@ [BuildOptions] > # > # suppress the following warnings so we do not break the build with warnings-as-errors: > # > - GCC:*_CLANG35_*_CC_FLAGS = -std=c99 > - GCC:*_CLANG38_*_CC_FLAGS = -std=c99 > + GCC:*_CLANGDWARF_*_CC_FLAGS = -std=c99 -Wno-error=incompatible-pointer-types > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=incompatible-pointer-types > > XCODE:*_*_*_CC_FLAGS = -std=c99 > diff --git a/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf b/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > index 07dbc0e7a8bd..56b4f7306d30 100644 > --- a/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > @@ -106,8 +106,7 @@ [BuildOptions] > # > # suppress the following warnings so we do not break the build with warnings-as-errors: > # > - GCC:*_CLANG35_*_CC_FLAGS = -std=c99 > - GCC:*_CLANG38_*_CC_FLAGS = -std=c99 > + GCC:*_CLANGDWARF_*_CC_FLAGS = -std=c99 -Wno-error=incompatible-pointer-types > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=incompatible-pointer-types > > XCODE:*_*_*_CC_FLAGS = -std=c99 > diff --git a/CryptoPkg/Library/BaseCryptLib/SecCryptLib.inf b/CryptoPkg/Library/BaseCryptLib/SecCryptLib.inf > index 4ad59b7bbc59..e7801b24c9a0 100644 > --- a/CryptoPkg/Library/BaseCryptLib/SecCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLib/SecCryptLib.inf > @@ -81,8 +81,7 @@ [BuildOptions] > # > # suppress the following warnings so we do not break the build with warnings-as-errors: > # > - GCC:*_CLANG35_*_CC_FLAGS = -std=c99 > - GCC:*_CLANG38_*_CC_FLAGS = -std=c99 > + GCC:*_CLANGDWARF_*_CC_FLAGS = -std=c99 -Wno-error=incompatible-pointer-types > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=incompatible-pointer-types > > XCODE:*_*_*_CC_FLAGS = -std=c99 > diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > index ab1993087167..109e08377a2d 100644 > --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > @@ -105,6 +105,5 @@ [BuildOptions] > > XCODE:*_*_*_CC_FLAGS = -mmmx -msse -std=c99 > > - GCC:*_CLANG35_*_CC_FLAGS = -std=c99 > - GCC:*_CLANG38_*_CC_FLAGS = -std=c99 > + GCC:*_CLANGDWARF_*_CC_FLAGS = -std=c99 -Wno-error=incompatible-pointer-types > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=incompatible-pointer-types > diff --git a/CryptoPkg/Library/BaseCryptLib/UnitTestHostBaseCryptLib.inf b/CryptoPkg/Library/BaseCryptLib/UnitTestHostBaseCryptLib.inf > index 80261794470f..c3d1d61e59c5 100644 > --- a/CryptoPkg/Library/BaseCryptLib/UnitTestHostBaseCryptLib.inf > +++ b/CryptoPkg/Library/BaseCryptLib/UnitTestHostBaseCryptLib.inf > @@ -78,8 +78,7 @@ [BuildOptions] > # > # suppress the following warnings so we do not break the build with warnings-as-errors: > # > - GCC:*_CLANG35_*_CC_FLAGS = -std=c99 > - GCC:*_CLANG38_*_CC_FLAGS = -std=c99 > + GCC:*_CLANGDWARF_*_CC_FLAGS = -std=c99 -Wno-error=incompatible-pointer-types > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=incompatible-pointer-types > > XCODE:*_*_*_CC_FLAGS = -std=c99 > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > index 86a00b1c4b2a..0f64c9fa7eca 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > @@ -639,8 +639,7 @@ [BuildOptions] > GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-variable -Wno-error=format > GCC:*_*_RISCV64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-variable > GCC:*_*_LOONGARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-variable > - GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > - GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > + GCC:*_CLANGDWARF_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-error=implicit-function-declaration -Wno-error=ignored-pragma-optimize > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-error=implicit-function-declaration -Wno-error=ignored-pragma-optimize > # Revisit after switching to 3.0 branch > GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf b/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf > index 2e4f95909b51..ebada80d9dd3 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf > @@ -687,8 +687,7 @@ [BuildOptions] > # > GCC:*_*_IA32_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) $(OPENSSL_FLAGS_CONFIG) -Wno-error=maybe-uninitialized -Wno-error=unused-but-set-variable > GCC:*_*_X64_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) $(OPENSSL_FLAGS_CONFIG) -Wno-error=maybe-uninitialized -Wno-error=format -Wno-format -Wno-error=unused-but-set-variable -DNO_MSABI_VA_FUNCS > - GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > - GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > + GCC:*_CLANGDWARF_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-error=implicit-function-declaration -Wno-error=ignored-pragma-optimize > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-error=implicit-function-declaration -Wno-error=ignored-pragma-optimize > # Revisit after switching to 3.0 branch > GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > index 637d4769e8ca..311cd1e6051a 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > @@ -589,8 +589,7 @@ [BuildOptions] > GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-variable -Wno-error=format > GCC:*_*_RISCV64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-variable > GCC:*_*_LOONGARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-variable > - GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > - GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > + GCC:*_CLANGDWARF_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-error=implicit-function-declaration -Wno-error=ignored-pragma-optimize > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-error=implicit-function-declaration -Wno-error=ignored-pragma-optimize > # Revisit after switching to 3.0 branch > GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf b/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf > index c5f90221fc66..52bb4aeaa5f1 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf > @@ -694,8 +694,7 @@ [BuildOptions] > GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-variable -Wno-error=format > GCC:*_*_RISCV64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-variable > GCC:*_*_LOONGARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-variable > - GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > - GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > + GCC:*_CLANGDWARF_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-error=implicit-function-declaration -Wno-error=ignored-pragma-optimize > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-error=implicit-function-declaration -Wno-error=ignored-pragma-optimize > # Revisit after switching to 3.0 branch > GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf b/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf > index 076295244a2a..2ea117e506f2 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf > @@ -742,8 +742,7 @@ [BuildOptions] > # > GCC:*_*_IA32_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) $(OPENSSL_FLAGS_CONFIG) -Wno-error=maybe-uninitialized -Wno-error=unused-but-set-variable > GCC:*_*_X64_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) $(OPENSSL_FLAGS_CONFIG) -Wno-error=maybe-uninitialized -Wno-error=format -Wno-format -Wno-error=unused-but-set-variable -DNO_MSABI_VA_FUNCS > - GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > - GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized > + GCC:*_CLANGDWARF_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-error=implicit-function-declaration -Wno-error=ignored-pragma-optimize > GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized -Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno-error=implicit-function-declaration -Wno-error=ignored-pragma-optimize > # Revisit after switching to 3.0 branch > GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable