From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web09.4639.1578322710344457008 for ; Mon, 06 Jan 2020 06:58:30 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VrGdmNwI; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578322709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r/Qi2hhp9Tnwlp1Ez/nsvQjIALqO7RTsBC+ptZtfs1s=; b=VrGdmNwIHDN1ciMj/FNz5pjxq8LLRsIY22RYzlYwIi0ZfeCcFqkBYa7X852aROOCfauq4O C+HfJFRJAsHbQXmYk6qdAsuPk2HeuDuisU1rwzKF/3AH+8DKZlc6EBtlSB4WmXrGawnSZE xf+aS99G3gd9K++5NPCpvh6TtPtoHaU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-176-fqwFhyZ7PuaVGLLNtuTTsg-1; Mon, 06 Jan 2020 09:58:28 -0500 Received: by mail-wm1-f72.google.com with SMTP id l11so2502812wmi.0 for ; Mon, 06 Jan 2020 06:58:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9J86NPR0v4zldneV67qO5oo3MMN7vcCKiWNo3pEL+As=; b=m329gZeRrW3jpzssY4Ev7bZefqZ90JJfBZwhWRU+vQiGD4+ickPFqt4NA4SZivG4Gk NUcZhMbnzB+hKBTy4bHxsBJydZ3kKUhG2XEg0owU/MQPwEGMISPW2mwYEyI7kFzwiPYS 1ePfZirIHH4FtDXSSAs9GfDqY9gj9ZJCsHVmPqBEjnV4PKxM+kl/Tyq5A4ClfF7sE4Z6 4XToq3gjYICBsuHHp+lpHUHk6JdQg9zUF4rnDvvsRV4JFnLV1fALGfmvkXdzJxqSIsLk YyDnjErb3cz7Jqr8jgNpvPE5wiPxA0jjQawlozLfwuGngyA6lJCfHU0nJOofHL8g0DSg whcg== X-Gm-Message-State: APjAAAV/nDMXC32/yt71MC7bMJjBWOnbuR4eLX3zzACgETU5XoS5M6mR JU/KI+tm/npqDW92Main7sM5WPzRhu2+OOkRaHD3DR5u9WDHR3TQfIOF6hoKCLXV7FwOxW3+p9L MqFgx5k3Q1O6Nhg== X-Received: by 2002:adf:ffc5:: with SMTP id x5mr5025352wrs.92.1578322706798; Mon, 06 Jan 2020 06:58:26 -0800 (PST) X-Google-Smtp-Source: APXvYqyxBB6Ry8FH7m6xU46Q/AhrMJNUS21Y5+XtGDpikvXQYPkP9FQy/lvHIHPcfId4RqqQFA8biA== X-Received: by 2002:adf:ffc5:: with SMTP id x5mr5025335wrs.92.1578322706609; Mon, 06 Jan 2020 06:58:26 -0800 (PST) Return-Path: Received: from [192.168.1.35] (34.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.34]) by smtp.gmail.com with ESMTPSA id f127sm22943449wma.4.2020.01.06.06.58.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jan 2020 06:58:26 -0800 (PST) Subject: Re: [edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master To: "Kinney, Michael D" , "devel@edk2.groups.io" , Sean Brogan , Bret Barkelew , "Gao, Liming" Cc: Laszlo Ersek References: From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <99e2e6ff-ccaa-60ba-db48-4b42931d45a5@redhat.com> Date: Mon, 6 Jan 2020 15:58:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: X-MC-Unique: fqwFhyZ7PuaVGLLNtuTTsg-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable On 1/2/20 7:36 PM, Kinney, Michael D wrote: > Hi Phil, >=20 > I am curious why the GIT committer information is so important. >=20 > Before CI, for any given package, the committer can be the > primary maintainer, the backup maintainer, or a steward. > The maintainer that actually does the commit is following the > process and the rules for doing a push, but may not have been > involved in the code change, reviews, or testing. >=20 > To me, the critical information is the Author, Reviewed-by, > Acked-by, and Tested-by tags, which I believe are all correct > when Mergify bot does the commit. Yes, they are correct. >=20 > What is the use case I am missing here? I guess I'm probably too rigid, custom to process all merge information=20 in my gitk window. If one day I've too look at Mergify I'll see if it is possible to=20 properly set the GIT_COMMITTER_[NAME/EMAIL] env vars before merging. Sorry for the noise, Phil. >> -----Original Message----- >> From: devel@edk2.groups.io On >> Behalf Of Philippe Mathieu-Daud=E9 >> Sent: Thursday, January 2, 2020 6:42 AM >> To: devel@edk2.groups.io; Kinney, Michael D >> ; Sean Brogan >> ; Bret Barkelew >> ; Gao, Liming >> >> Cc: Laszlo Ersek >> Subject: Re: [edk2-devel] EDK II Maintainers - EDK II >> CI is now active on edk2/master >> >> Hi Michael, >> >> On 11/12/19 3:55 AM, Michael D Kinney wrote: >>> EDK II Maintainers, >>> >>> EDK II CI Phase 1 feature is now active on >> edk2/master. >>> >>> Please use a GitHub pull request from a branch in a >> personal >>> fork of the edk2 repository with a 'push' label to >> request >>> a set of patches to be pushed to edk2/master. The >> GitHub PR >>> replaces the 'git push' operation currently used to >> commit >>> changes to edk2/master. >>> >>> You will need to configure your notifications from >> the edk2 >>> repository to make sure you receive email >> notifications >>> when the checks against the GitHub PR passes or >> fails. >>> >>> If you submit a GitHub Pull Request without the >> 'push' >>> label, then the CI checks are run and the results are >>> generated. >>> >>> Please let us know if there are any questions about >> this >>> change in the development process. >> >> I have 2 requests: >> >> 1/ Is it possible to have the Mergify bot use the merge >> request author >> name/email as GIT_COMMITTER_[NAME/EMAIL] instead of >> throwing away this >> information from the git history? >> >> Before we could directly use this information to email >> the maintainer >> who merged the patch in. >> Currently I can't find an easy way... I've to dig thru >> the mailing list >> archives for the last thread, figure out who could have >> merge this, >> check the different maintainers GitHub repository... >> >> The new way might be using this filter (which is not >> listed by default): >> https://github.com/tianocore/edk2/pulls?utf8=3D%E2%9C%93& >> q=3Dis%3Apr+is%3Amerged >> >> Then go thru the last ones, but this doesn't scale in >> few months to look >> at old merges. >> >> 2/ Can the Mergify bot send a mail to the list to >> notify a patch got merged? >> >> For example going thru my backlog I was going to review >> this series: >> https://edk2.groups.io/g/devel/message/52613 >> But it is already merged... The series subject is >> "Microcode related >> optimizations" and when I searched for it first with >> the GitHub MR >> filter from 1/, I couldn't find it. Later I figured it >> got merged with >> another subject "Mpinitlib opt push 1". >> >> One way to simplify Mergify to send email, is to ask >> maintainers to put >> the series cover (or each patches) URL in the GitHub >> merge request >> description, or the email Message ID(s). Since we are >> switching the a >> mostly HTTP workflow, using URLs is probably >> recommended. >> >> Thanks, and happy new year! :) >> >> Phil. >> >> >>=20 >=20