* [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid @ 2023-02-17 6:48 Jianyong Wu 2023-03-28 3:28 ` Jianyong Wu 0 siblings, 1 reply; 9+ messages in thread From: Jianyong Wu @ 2023-02-17 6:48 UTC (permalink / raw) To: devel, Sami.Mujawar; +Cc: jianyong.wu commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is missing in CloudHvHasAcpiDtDxe.inf which leads to gUefiOvmfPkgTokenSpaceGuid found nowhere. Signed-off-by: Jianyong Wu <jianyong.wu@arm.com> --- ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf | 1 + 1 file changed, 1 insertion(+) diff --git a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf index 7cad40e11f..6ff80b24d0 100644 --- a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf +++ b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf @@ -23,6 +23,7 @@ EmbeddedPkg/EmbeddedPkg.dec MdeModulePkg/MdeModulePkg.dec MdePkg/MdePkg.dec + OvmfPkg/OvmfPkg.dec [LibraryClasses] BaseLib -- 2.17.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid 2023-02-17 6:48 [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid Jianyong Wu @ 2023-03-28 3:28 ` Jianyong Wu 2023-03-28 4:41 ` Sunil V L ` (2 more replies) 0 siblings, 3 replies; 9+ messages in thread From: Jianyong Wu @ 2023-03-28 3:28 UTC (permalink / raw) To: Jianyong Wu, devel@edk2.groups.io, Sami Mujawar Cc: sunilvl@ventanamicro.com, Ard Biesheuvel Add Ard Biesheuvel <ardb@kernel.org> and Sunil V L <sunilvl@ventanamicro.com> to cc list. > -----Original Message----- > From: Jianyong Wu <jianyong.wu@arm.com> > Sent: 2023年2月17日 14:48 > To: devel@edk2.groups.io; Sami Mujawar <Sami.Mujawar@arm.com> > Cc: Jianyong Wu <Jianyong.Wu@arm.com> > Subject: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid > > commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is > missing in CloudHvHasAcpiDtDxe.inf which leads to > gUefiOvmfPkgTokenSpaceGuid found nowhere. > > Signed-off-by: Jianyong Wu <jianyong.wu@arm.com> > --- > ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf | 1 + > 1 file changed, 1 insertion(+) > > diff --git > a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf > b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf > index 7cad40e11f..6ff80b24d0 100644 > --- a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf > +++ b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf > @@ -23,6 +23,7 @@ > EmbeddedPkg/EmbeddedPkg.dec > MdeModulePkg/MdeModulePkg.dec > MdePkg/MdePkg.dec > + OvmfPkg/OvmfPkg.dec > > [LibraryClasses] > BaseLib > -- > 2.17.1 IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid 2023-03-28 3:28 ` Jianyong Wu @ 2023-03-28 4:41 ` Sunil V L 2023-03-28 4:59 ` Sunil V L 2023-03-28 7:45 ` Sami Mujawar 2 siblings, 0 replies; 9+ messages in thread From: Sunil V L @ 2023-03-28 4:41 UTC (permalink / raw) To: Jianyong Wu; +Cc: devel@edk2.groups.io, Sami Mujawar, Ard Biesheuvel On Tue, Mar 28, 2023 at 03:28:25AM +0000, Jianyong Wu wrote: > Add Ard Biesheuvel <ardb@kernel.org> and Sunil V L <sunilvl@ventanamicro.com> to cc list. > > > -----Original Message----- > > From: Jianyong Wu <jianyong.wu@arm.com> > > Sent: 2023年2月17日 14:48 > > To: devel@edk2.groups.io; Sami Mujawar <Sami.Mujawar@arm.com> > > Cc: Jianyong Wu <Jianyong.Wu@arm.com> > > Subject: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid > > > > commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is > > missing in CloudHvHasAcpiDtDxe.inf which leads to > > gUefiOvmfPkgTokenSpaceGuid found nowhere. > > > > Signed-off-by: Jianyong Wu <jianyong.wu@arm.com> > > --- > > ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git > > a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf > > b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf > > index 7cad40e11f..6ff80b24d0 100644 > > --- a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf > > +++ b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf > > @@ -23,6 +23,7 @@ > > EmbeddedPkg/EmbeddedPkg.dec > > MdeModulePkg/MdeModulePkg.dec > > MdePkg/MdePkg.dec > > + OvmfPkg/OvmfPkg.dec > > Hi Jianyong, Thanks for fixing this!. Sorry that I missed this in the first place. Reviewed-by: Sunil V L <sunilvl@ventanamicro.com> ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid 2023-03-28 3:28 ` Jianyong Wu 2023-03-28 4:41 ` Sunil V L @ 2023-03-28 4:59 ` Sunil V L 2023-03-28 7:52 ` Sami Mujawar 2023-03-28 7:45 ` Sami Mujawar 2 siblings, 1 reply; 9+ messages in thread From: Sunil V L @ 2023-03-28 4:59 UTC (permalink / raw) To: Jianyong Wu; +Cc: devel@edk2.groups.io, Sami Mujawar, Ard Biesheuvel On Tue, Mar 28, 2023 at 03:28:25AM +0000, Jianyong Wu wrote: > Add Ard Biesheuvel <ardb@kernel.org> and Sunil V L <sunilvl@ventanamicro.com> to cc list. > > > -----Original Message----- > > From: Jianyong Wu <jianyong.wu@arm.com> > > Sent: 2023年2月17日 14:48 > > To: devel@edk2.groups.io; Sami Mujawar <Sami.Mujawar@arm.com> > > Cc: Jianyong Wu <Jianyong.Wu@arm.com> > > Subject: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid > > > > commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is > > missing in CloudHvHasAcpiDtDxe.inf which leads to > > gUefiOvmfPkgTokenSpaceGuid found nowhere. > > > > Signed-off-by: Jianyong Wu <jianyong.wu@arm.com> > > --- Hi Jianyong, Any reason why this platform is not built as part of CI? I think it will be good to add so that we don't break by some changes like this. Thanks, Sunil ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid 2023-03-28 4:59 ` Sunil V L @ 2023-03-28 7:52 ` Sami Mujawar 2023-03-28 8:17 ` Jianyong Wu 0 siblings, 1 reply; 9+ messages in thread From: Sami Mujawar @ 2023-03-28 7:52 UTC (permalink / raw) To: Sunil V L, Jianyong Wu; +Cc: devel@edk2.groups.io, Ard Biesheuvel Hi Jianyong, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 28/03/2023, 08:45, "Sunil V L" <sunilvl@ventanamicro.com <mailto:sunilvl@ventanamicro.com>> wrote: On Tue, Mar 28, 2023 at 03:28:25AM +0000, Jianyong Wu wrote: > Add Ard Biesheuvel <ardb@kernel.org <mailto:ardb@kernel.org>> and Sunil V L <sunilvl@ventanamicro.com <mailto:sunilvl@ventanamicro.com>> to cc list. > > > -----Original Message----- > > From: Jianyong Wu <jianyong.wu@arm.com <mailto:jianyong.wu@arm.com>> > > Sent: 2023年2月17日 14:48 > > To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>; Sami Mujawar <Sami.Mujawar@arm.com <mailto:Sami.Mujawar@arm.com>> > > Cc: Jianyong Wu <Jianyong.Wu@arm.com <mailto:Jianyong.Wu@arm.com>> > > Subject: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid > > > > commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is > > missing in CloudHvHasAcpiDtDxe.inf which leads to > > gUefiOvmfPkgTokenSpaceGuid found nowhere. > > > > Signed-off-by: Jianyong Wu <jianyong.wu@arm.com <mailto:jianyong.wu@arm.com>> > > --- Hi Jianyong, Any reason why this platform is not built as part of CI? I think it will be good to add so that we don't break by some changes like this. [SAMI] Ard has recently added CI support for Kvmtool guest firmware. Please see the change at https://github.com/tianocore/edk2/commit/ca573b86157e7fcd34cd44e79ebd10e89d8b8cc4. Thanks, Sunil IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid 2023-03-28 7:52 ` Sami Mujawar @ 2023-03-28 8:17 ` Jianyong Wu 2023-03-28 8:33 ` Sami Mujawar 0 siblings, 1 reply; 9+ messages in thread From: Jianyong Wu @ 2023-03-28 8:17 UTC (permalink / raw) To: Sami Mujawar Cc: devel@edk2.groups.io, Ard Biesheuvel, sunilvl@ventanamicro.com Hi Sami, I have never added CI for CloudHv. So, should I add it? Also, I will update this patch based on your comment and send the second version. Thanks, Jianyong > -----Original Message----- > From: Sami Mujawar <Sami.Mujawar@arm.com> > Sent: 2023年3月28日 15:52 > To: Sunil V L <sunilvl@ventanamicro.com>; Jianyong Wu > <Jianyong.Wu@arm.com> > Cc: devel@edk2.groups.io; Ard Biesheuvel <ardb@kernel.org> > Subject: Re: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid > > Hi Jianyong, > > Please find my response inline marked [SAMI]. > > Regards, > > Sami Mujawar > > On 28/03/2023, 08:45, "Sunil V L" <sunilvl@ventanamicro.com > <mailto:sunilvl@ventanamicro.com>> wrote: > > > On Tue, Mar 28, 2023 at 03:28:25AM +0000, Jianyong Wu wrote: > > Add Ard Biesheuvel <ardb@kernel.org <mailto:ardb@kernel.org>> and Sunil > V L <sunilvl@ventanamicro.com <mailto:sunilvl@ventanamicro.com>> to cc > list. > > > > > -----Original Message----- > > > From: Jianyong Wu <jianyong.wu@arm.com > <mailto:jianyong.wu@arm.com>> > > > Sent: 2023年2月17日 14:48 > > > To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>; Sami Mujawar > > > <Sami.Mujawar@arm.com <mailto:Sami.Mujawar@arm.com>> > > > Cc: Jianyong Wu <Jianyong.Wu@arm.com > <mailto:Jianyong.Wu@arm.com>> > > > Subject: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid > > > > > > commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec > > > is missing in CloudHvHasAcpiDtDxe.inf which leads to > > > gUefiOvmfPkgTokenSpaceGuid found nowhere. > > > > > > Signed-off-by: Jianyong Wu <jianyong.wu@arm.com > > > <mailto:jianyong.wu@arm.com>> > > > --- > Hi Jianyong, > > > Any reason why this platform is not built as part of CI? I think it will be good to > add so that we don't break by some changes like this. > [SAMI] Ard has recently added CI support for Kvmtool guest firmware. Please > see the change at > https://github.com/tianocore/edk2/commit/ca573b86157e7fcd34cd44e79ebd > 10e89d8b8cc4. > > Thanks, > Sunil > > > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid 2023-03-28 8:17 ` Jianyong Wu @ 2023-03-28 8:33 ` Sami Mujawar 2023-03-28 8:54 ` Jianyong Wu 0 siblings, 1 reply; 9+ messages in thread From: Sami Mujawar @ 2023-03-28 8:33 UTC (permalink / raw) To: Jianyong Wu Cc: devel@edk2.groups.io, Ard Biesheuvel, sunilvl@ventanamicro.com Hi Jianyong, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 28/03/2023, 09:17, "Jianyong Wu" <Jianyong.Wu@arm.com <mailto:Jianyong.Wu@arm.com>> wrote: Hi Sami, I have never added CI for CloudHv. So, should I add it? [SAMI] I think you can prepare the patch that adds the CI support and push your changes to your private github branch. You should then be able to generate a draft pull request to test that the CI patch works. Also, I will update this patch based on your comment and send the second version. [SAMI] Please also update the commit message with the r-b received so far. Thanks, Jianyong > -----Original Message----- > From: Sami Mujawar <Sami.Mujawar@arm.com <mailto:Sami.Mujawar@arm.com>> > Sent: 2023年3月28日 15:52 > To: Sunil V L <sunilvl@ventanamicro.com <mailto:sunilvl@ventanamicro.com>>; Jianyong Wu > <Jianyong.Wu@arm.com <mailto:Jianyong.Wu@arm.com>> > Cc: devel@edk2.groups.io <mailto:devel@edk2.groups.io>; Ard Biesheuvel <ardb@kernel.org <mailto:ardb@kernel.org>> > Subject: Re: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid > > Hi Jianyong, > > Please find my response inline marked [SAMI]. > > Regards, > > Sami Mujawar > > On 28/03/2023, 08:45, "Sunil V L" <sunilvl@ventanamicro.com <mailto:sunilvl@ventanamicro.com> > <mailto:sunilvl@ventanamicro.com <mailto:sunilvl@ventanamicro.com>>> wrote: > > > On Tue, Mar 28, 2023 at 03:28:25AM +0000, Jianyong Wu wrote: > > Add Ard Biesheuvel <ardb@kernel.org <mailto:ardb@kernel.org> <mailto:ardb@kernel.org <mailto:ardb@kernel.org>>> and Sunil > V L <sunilvl@ventanamicro.com <mailto:sunilvl@ventanamicro.com> <mailto:sunilvl@ventanamicro.com <mailto:sunilvl@ventanamicro.com>>> to cc > list. > > > > > -----Original Message----- > > > From: Jianyong Wu <jianyong.wu@arm.com <mailto:jianyong.wu@arm.com> > <mailto:jianyong.wu@arm.com <mailto:jianyong.wu@arm.com>>> > > > Sent: 2023年2月17日 14:48 > > > To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <mailto:devel@edk2.groups.io <mailto:devel@edk2.groups.io>>; Sami Mujawar > > > <Sami.Mujawar@arm.com <mailto:Sami.Mujawar@arm.com> <mailto:Sami.Mujawar@arm.com <mailto:Sami.Mujawar@arm.com>>> > > > Cc: Jianyong Wu <Jianyong.Wu@arm.com <mailto:Jianyong.Wu@arm.com> > <mailto:Jianyong.Wu@arm.com <mailto:Jianyong.Wu@arm.com>>> > > > Subject: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid > > > > > > commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec > > > is missing in CloudHvHasAcpiDtDxe.inf which leads to > > > gUefiOvmfPkgTokenSpaceGuid found nowhere. > > > > > > Signed-off-by: Jianyong Wu <jianyong.wu@arm.com <mailto:jianyong.wu@arm.com> > > > <mailto:jianyong.wu@arm.com <mailto:jianyong.wu@arm.com>>> > > > --- > Hi Jianyong, > > > Any reason why this platform is not built as part of CI? I think it will be good to > add so that we don't break by some changes like this. > [SAMI] Ard has recently added CI support for Kvmtool guest firmware. Please > see the change at > https://github.com/tianocore/edk2/commit/ca573b86157e7fcd34cd44e79ebd <https://github.com/tianocore/edk2/commit/ca573b86157e7fcd34cd44e79ebd> > 10e89d8b8cc4. > > Thanks, > Sunil > > > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid 2023-03-28 8:33 ` Sami Mujawar @ 2023-03-28 8:54 ` Jianyong Wu 0 siblings, 0 replies; 9+ messages in thread From: Jianyong Wu @ 2023-03-28 8:54 UTC (permalink / raw) To: Sami Mujawar Cc: devel@edk2.groups.io, Ard Biesheuvel, sunilvl@ventanamicro.com Hi Sami, Inline replay. > -----Original Message----- > From: Sami Mujawar <Sami.Mujawar@arm.com> > Sent: 2023年3月28日 16:34 > To: Jianyong Wu <Jianyong.Wu@arm.com> > Cc: devel@edk2.groups.io; Ard Biesheuvel <ardb@kernel.org>; > sunilvl@ventanamicro.com > Subject: Re: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid > > Hi Jianyong, > > Please find my response inline marked [SAMI]. > > Regards, > > Sami Mujawar > > On 28/03/2023, 09:17, "Jianyong Wu" <Jianyong.Wu@arm.com > <mailto:Jianyong.Wu@arm.com>> wrote: > > > Hi Sami, > > > I have never added CI for CloudHv. So, should I add it? > [SAMI] I think you can prepare the patch that adds the CI support and push your > changes to your private github branch. You should then be able to generate a > draft pull request to test that the CI patch works. > let me try it later. > Also, I will update this patch based on your comment and send the second > version. > [SAMI] Please also update the commit message with the r-b received so far. > OK. Thanks Jianyong > > Thanks, > Jianyong > > > > -----Original Message----- > > From: Sami Mujawar <Sami.Mujawar@arm.com > > <mailto:Sami.Mujawar@arm.com>> > > Sent: 2023年3月28日 15:52 > > To: Sunil V L <sunilvl@ventanamicro.com > > <mailto:sunilvl@ventanamicro.com>>; Jianyong Wu <Jianyong.Wu@arm.com > > <mailto:Jianyong.Wu@arm.com>> > > Cc: devel@edk2.groups.io <mailto:devel@edk2.groups.io>; Ard Biesheuvel > > <ardb@kernel.org <mailto:ardb@kernel.org>> > > Subject: Re: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid > > > > Hi Jianyong, > > > > Please find my response inline marked [SAMI]. > > > > Regards, > > > > Sami Mujawar > > > > On 28/03/2023, 08:45, "Sunil V L" <sunilvl@ventanamicro.com > > <mailto:sunilvl@ventanamicro.com> <mailto:sunilvl@ventanamicro.com > <mailto:sunilvl@ventanamicro.com>>> wrote: > > > > > > On Tue, Mar 28, 2023 at 03:28:25AM +0000, Jianyong Wu wrote: > > > Add Ard Biesheuvel <ardb@kernel.org <mailto:ardb@kernel.org> > > > <mailto:ardb@kernel.org <mailto:ardb@kernel.org>>> and Sunil > > V L <sunilvl@ventanamicro.com <mailto:sunilvl@ventanamicro.com> > > <mailto:sunilvl@ventanamicro.com <mailto:sunilvl@ventanamicro.com>>> to > cc list. > > > > > > > -----Original Message----- > > > > From: Jianyong Wu <jianyong.wu@arm.com > > > > <mailto:jianyong.wu@arm.com> > > <mailto:jianyong.wu@arm.com <mailto:jianyong.wu@arm.com>>> > > > > Sent: 2023年2月17日 14:48 > > > > To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> > > > > <mailto:devel@edk2.groups.io <mailto:devel@edk2.groups.io>>; Sami > > > > Mujawar <Sami.Mujawar@arm.com <mailto:Sami.Mujawar@arm.com> > > > > <mailto:Sami.Mujawar@arm.com <mailto:Sami.Mujawar@arm.com>>> > > > > Cc: Jianyong Wu <Jianyong.Wu@arm.com > <mailto:Jianyong.Wu@arm.com> > > <mailto:Jianyong.Wu@arm.com <mailto:Jianyong.Wu@arm.com>>> > > > > Subject: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid > > > > > > > > commit f13264b34 introduces a bug for CloudHv as > > > > OvmfPkg/OvmfPkg.dec is missing in CloudHvHasAcpiDtDxe.inf which > > > > leads to gUefiOvmfPkgTokenSpaceGuid found nowhere. > > > > > > > > Signed-off-by: Jianyong Wu <jianyong.wu@arm.com > > > > <mailto:jianyong.wu@arm.com> <mailto:jianyong.wu@arm.com > > > > <mailto:jianyong.wu@arm.com>>> > > > > --- > > Hi Jianyong, > > > > > > Any reason why this platform is not built as part of CI? I think it > > will be good to add so that we don't break by some changes like this. > > [SAMI] Ard has recently added CI support for Kvmtool guest firmware. > > Please see the change at > > > https://github.com/tianocore/edk2/commit/ca573b86157e7fcd34cd44e79ebd > > > <https://github.com/tianocore/edk2/commit/ca573b86157e7fcd34cd44e79ebd > > > > > 10e89d8b8cc4. > > > > Thanks, > > Sunil > > > > > > > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid 2023-03-28 3:28 ` Jianyong Wu 2023-03-28 4:41 ` Sunil V L 2023-03-28 4:59 ` Sunil V L @ 2023-03-28 7:45 ` Sami Mujawar 2 siblings, 0 replies; 9+ messages in thread From: Sami Mujawar @ 2023-03-28 7:45 UTC (permalink / raw) To: Jianyong Wu, devel@edk2.groups.io Cc: sunilvl@ventanamicro.com, Ard Biesheuvel Hi Jianyong, Thank you for this fix. The subject line should have the package name as prefix followed by the short description for the patch e.g. "ArmVirtPkg: xxx". Other than that, this change looks good to me. Reviewed-by: Sami Mujawar <sami.mujawar@arm.com> Regards, Sami Mujawar On 28/03/2023, 04:28, "Jianyong Wu" <Jianyong.Wu@arm.com <mailto:Jianyong.Wu@arm.com>> wrote: Add Ard Biesheuvel <ardb@kernel.org <mailto:ardb@kernel.org>> and Sunil V L <sunilvl@ventanamicro.com <mailto:sunilvl@ventanamicro.com>> to cc list. > -----Original Message----- > From: Jianyong Wu <jianyong.wu@arm.com <mailto:jianyong.wu@arm.com>> > Sent: 2023年2月17日 14:48 > To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>; Sami Mujawar <Sami.Mujawar@arm.com <mailto:Sami.Mujawar@arm.com>> > Cc: Jianyong Wu <Jianyong.Wu@arm.com <mailto:Jianyong.Wu@arm.com>> > Subject: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid > > commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is > missing in CloudHvHasAcpiDtDxe.inf which leads to > gUefiOvmfPkgTokenSpaceGuid found nowhere. > > Signed-off-by: Jianyong Wu <jianyong.wu@arm.com <mailto:jianyong.wu@arm.com>> > --- > ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf | 1 + > 1 file changed, 1 insertion(+) > > diff --git > a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf > b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf > index 7cad40e11f..6ff80b24d0 100644 > --- a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf > +++ b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf > @@ -23,6 +23,7 @@ > EmbeddedPkg/EmbeddedPkg.dec > MdeModulePkg/MdeModulePkg.dec > MdePkg/MdePkg.dec > + OvmfPkg/OvmfPkg.dec > > [LibraryClasses] > BaseLib > -- > 2.17.1 IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-03-28 8:54 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-02-17 6:48 [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid Jianyong Wu 2023-03-28 3:28 ` Jianyong Wu 2023-03-28 4:41 ` Sunil V L 2023-03-28 4:59 ` Sunil V L 2023-03-28 7:52 ` Sami Mujawar 2023-03-28 8:17 ` Jianyong Wu 2023-03-28 8:33 ` Sami Mujawar 2023-03-28 8:54 ` Jianyong Wu 2023-03-28 7:45 ` Sami Mujawar
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox