From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65])
 by mx.groups.io with SMTP id smtpd.web11.107200.1680626575872259828
 for <devel@edk2.groups.io>;
 Tue, 04 Apr 2023 09:42:56 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@posteo.de header.s=2017 header.b=LMwlXCn6;
 spf=pass (domain: posteo.de, ip: 185.67.36.65, mailfrom: mhaeuser@posteo.de)
Received: from submission (posteo.de [185.67.36.169]) 
	by mout01.posteo.de (Postfix) with ESMTPS id 2DFAA240565
	for <devel@edk2.groups.io>; Tue,  4 Apr 2023 18:42:52 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017;
	t=1680626573; bh=PKVGGCL+db/sepQYSlCHi7IHqHfgXrmCUsjzoCQHuIQ=;
	h=Subject:From:Cc:Date:To:From;
	b=LMwlXCn6Tln32zZXjo+/Odp9RfeUQk8NW4Kk74fqG6eOMpM6eNMOzcpXTnUkea9CM
	 dphNC0SnBEg+t3mtkxLW5QbOB5FsPJRMpBoykKxGClbal3v0y/1XtGDDPgd216HNi8
	 XDCJpmQa4Li9oxCOhxWs+Az8zX4B5Sl5JpFLNgZd/zhl5EpMOCivJT9m+8txvtnv5s
	 kzt8/q+sdju3svTHFoIUrwnZxjGAQxAfWL3pgbRbrTK8uA5fwqCeGy7OYgl9kcNTg/
	 XW/ptsdBPgdOlPremQTgbZvjn0+aCIW1kDn4AA45HeIKcHPFy2E0TCTeZ8sqJeYLY9
	 H3z1/lUfIHmLQ==
Received: from customer (localhost [127.0.0.1])
	by submission (posteo.de) with ESMTPSA id 4PrYTf3zZQz6tw0;
	Tue,  4 Apr 2023 18:42:46 +0200 (CEST)
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH v3 0/4] Enable BTI support in memory attributes table
From: =?UTF-8?B?TWFydmluIEjDpHVzZXI=?= <mhaeuser@posteo.de>
In-Reply-To: <CAMj1kXG2zXNdz6G_sVpWNM=nx-WF0Eb=gaUdSZPYyqJwWJ3-fg@mail.gmail.com>
Cc: devel@edk2.groups.io, Michael Kinney <michael.d.kinney@intel.com>,
 Liming Gao <gaoliming@byosoft.com.cn>, Jiewen Yao <jiewen.yao@intel.com>,
 Michael Kubacki <Michael.Kubacki@microsoft.com>,
 Sean Brogan <sean.brogan@microsoft.com>,
 Rebecca Cran <quic_rcran@quicinc.com>,
 Leif Lindholm <quic_llindhol@quicinc.com>,
 Sami Mujawar <sami.mujawar@arm.com>, Taylor Beebe <t@taylorbeebe.com>,
 Bob Feng <bob.c.feng@intel.com>,
 Oliver Smith-Denny <osde@linux.microsoft.com>
Date: Tue,  4 Apr 2023 16:42:45 +0000
Message-Id: <9C4C1527-1DA6-4DA7-AE98-F2BCA59E2089@posteo.de>
References: <CAMj1kXG2zXNdz6G_sVpWNM=nx-WF0Eb=gaUdSZPYyqJwWJ3-fg@mail.gmail.com>
To: Ard Biesheuvel <ardb@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


> On 4. Apr 2023, at 18:29, Ard Biesheuvel <ardb@kernel.org> wrote:
> =EF=BB=BFOn Tue, 4 Apr 2023 at 18:19, Marvin H=C3=A4user <mhaeuser@posteo.=
de> wrote:
>>=20
>> FWIW, Reviewed-by: Marvin H=C3=A4user <mhaeuser@posteo.de>
>>=20
>> An off-topic remark, but I find it ominous that when adding a hack like t=
he DllCharacteristicsEx debug entry, the opportunity is not used to turn it i=
nto something that can be expanded in the future without introducing yet ano=
ther hack like this (I know 31 more Bits look plenty now, but if an address,=
 offset, or size will be needed=E2=80=A6 ouch).
>=20
> It *can* be expanded in the future. The debug directory entry includes
> a size field, and once flags get defined that are not present, they
> just default to unset.

Ugh, I should have known this=E2=80=A6 sorry for my terrible remark! :)

Though doesn=E2=80=99t that mean the size field should ideally be checked in=
 3/4 (not regarding the extensibility point, but well-formedness of the data=
)?

Best regards,
Marvin=