From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-in7.apple.com (mail-out7.apple.com [17.151.62.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6812D1A1E31 for ; Wed, 5 Oct 2016 14:05:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; d=apple.com; s=mailout2048s; c=relaxed/simple; q=dns/txt; i=@apple.com; t=1475701554; h=From:Sender:Reply-To:Subject:Date:Message-id:To:Cc:MIME-version:Content-type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-reply-to:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=TxzoVOnrA8J0edd/Iv1mCXEgrjJy+B5nFGTW3kl1SRg=; b=n6KqnUThgCjHMJokR3Hsq/P4RKKq40T4kO0RaA9XszgIQYhT4kT+Fa7L+JLUozxZ jqCwNzf7zSyLkI4dJG85EzqoLdYnZ3+rY6obmIwOnxzd3xZV7IDlClLfUmTdPZ+w Tx5C1z+d+8sakQh1PGQ1R7pV9YvXpGKKgS/5J2FyZKjTEQ8oQPfGuydTQuKvp0eW L2G+iOfxLhrRd1S89G4jZ6c1F9zdNvzJtDk+QgwNs8mtpftqnH5vhjOs1T622Jl1 2R68Aqq1dIc7Qwtx68LlvNDY+EceLzgxrzR2UkTR45YbvB4nca5mDeGcz8TR0CNG 61wgJWFMSoLMDIWo75UElg==; Received: from relay6.apple.com (relay6.apple.com [17.128.113.90]) by mail-in7.apple.com (Apple Secure Mail Relay) with SMTP id C5.66.07050.23B65F75; Wed, 5 Oct 2016 14:05:54 -0700 (PDT) X-AuditID: 11973e16-e7d8d9a000001b8a-23-57f56b328aed Received: from nwk-mmpp-sz13.apple.com (nwk-mmpp-sz13.apple.com [17.128.115.216]) by relay6.apple.com (Apple SCV relay) with SMTP id F0.51.23613.13B65F75; Wed, 5 Oct 2016 14:05:53 -0700 (PDT) MIME-version: 1.0 Received: from [17.153.37.250] by nwk-mmpp-sz13.apple.com (Oracle Communications Messaging Server 8.0.1.1.0 64bit (built Jun 15 2016)) with ESMTPSA id <0OEL00FLKELT2600@nwk-mmpp-sz13.apple.com>; Wed, 05 Oct 2016 14:05:53 -0700 (PDT) Sender: afish@apple.com From: Andrew Fish Message-id: <9F98A80B-A3F4-4956-9D84-33C166384EB6@apple.com> Date: Wed, 05 Oct 2016 14:05:52 -0700 In-reply-to: <6ac805ec-66c2-a291-7852-3429efa018cd@arm.com> Cc: "Carsey, Jaben" , edk2-devel-01 , Leif Lindholm To: Daniil Egranov References: <93F01BC9-4B02-467E-B900-65C6775BB0F3@apple.com> <6ac805ec-66c2-a291-7852-3429efa018cd@arm.com> X-Mailer: Apple Mail (2.3226) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMLMWRmVeSWpSXmKPExsUi2FAYpWuU/TXc4NknVostrbfYLfYcOsps sbHpD6vFov6vbA4sHmvmrWH0WLznJZNH9+x/LAHMUVw2Kak5mWWpRfp2CVwZC56ZFmy6w1hx 8tkP9gbGroOMXYycHBICJhJfZmwDsrk4hAT2MkrM3DadHSYxv/0YE0TiEKPE1svrmUASvAKC Ej8m32MBsZkFwiQePDvCDFH0jlHi0bbbYEXCAuIS785sYgax2QSUJVbM/8AO0Wwj8ffGATaI mhSJZ1ObwM5gEVCVuLVxBthQTgFrieez7jNDLKiT6Pm4EKxGREBb4uH77VCnTmGWeLS3B6iB A+hUWYnZv7wgrn7OJjHhaMkERqFZSG6dheRWCFtL4vujVqA4B5AtL3HwvCxEWFPi2b1P7BC2 tsSTdxdYFzCyrWIUyk3MzNHNzDPXSywoyEnVS87P3cQIipXpdmI7GB+usjrEKMDBqMTDe0P1 a7gQa2JZcWXuIUZpDhYlcV6OD5/DhQTSE0tSs1NTC1KL4otKc1KLDzEycXBKNTC2ZK3KfrRz kmjjPLm4qRpTPWYFS8XEqW7afXq/6nmmRYceiSlYe7VmtOh1vq/Jba3/KmR3tyZANXvm7tor ml+6NoeXrDUrbzZ799KiheECSwYr51XeZSUX2hes+vPmzzRVm+T2U6JWGWnm/6TnMzqLr323 Zs/jjXbfXU/8uCTS56Pwrzru2gwlluKMREMt5qLiRAATsrNCdgIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrFIsWRmVeSWpSXmKPExsUi2FB8Q9cw+2u4we5nlhZbWm+xW+w5dJTZ YmPTH1aLRf1f2RxYPNbMW8PosXjPSyaP7tn/WAKYo7hsUlJzMstSi/TtErgyFjwzLdh0h7Hi 5LMf7A2MXQcZuxg5OSQETCTmtx9jgrDFJC7cW8/WxcjFISRwiFFi6+X1YAleAUGJH5PvsYDY zAJhEg+eHWGGKHrHKPFo222wImEBcYl3ZzYxg9hsAsoSK+Z/YIdotpH4e+MAG0RNisSzqU1g m1kEVCVubZwBNpRTwFri+az7zBAL6iR6Pi4EqxER0JZ4+H47I8SyKcwSj/b2ADVwAJ0qKzH7 l9cERoFZSO6bheQ+CFtL4vujVqA4B5AtL3HwvCxEWFPi2b1P7BC2tsSTdxdYFzCyrWIUKErN Saw000ssKMhJ1UvOz93ECA76wqgdjA3LrQ4xCnAwKvHw3lD9Gi7EmlhWXJkLDCQOZiURXvYs oBBvSmJlVWpRfnxRaU5q8SHGiYxAT05klhJNzgfGZF5JvKGJiYGJsbGZsbG5iTkthZXEeXdf /hQuJJCeWJKanZpakFoEcxQTB6dUA+MUnc3L1vzRnZ29InqR1Ill4Xu8BRddnhtRZnCx+peX ez3D7uDmz8s2GLkLHWl78vq8Umd7UPWEJU07Zn2X+dNi4V+YIh9gE6mhfvZNa5tSspz0q+PT v7BMD3C5PutKdUfxTv8tCyd2aCs9+P5V/LV5+taDiQ/Prl1SWnHi4cKK3UzZUfr5y2yVWIoz Eg21mIuKEwGfQ3Rk7QIAAA== X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: Assert in ShellPkg with latest tianocore edk2 source on the Reference Platform X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Oct 2016 21:05:54 -0000 Content-Type: text/plain; CHARSET=US-ASCII Content-Transfer-Encoding: 7BIT > On Oct 5, 2016, at 1:53 PM, Daniil Egranov wrote: > > > > On 10/05/2016 02:48 PM, Andrew Fish wrote: >>> On Oct 5, 2016, at 12:24 PM, Daniil Egranov wrote: >>> >>> I have the same ASSERT issue on Juno platform even the EnglishDxe.inf is included to the platform build. If UefiShellLib has such dependency on the protocol then according to EDKII Module Writer's Guide you need to specify the dependency on protocol in the module .inf to ensure the drivers proper load sequence. >>> >>> 8.6 Dependency Expressions >>> A dependency expression specifies the protocols that the DXE driver requires to >>> execute. In EDK II, it is specified in the [Depex] section of INF file. >>> >> The Dependency Expression is for DXE Drivers that are dispatched by the DXE Core. A UEFI Driver from an option ROM or an Application does not get dispatched by the dispatch and the Depex will not help. The Depex ends up being a section in the FV and it has nothing to do with the PE/COFF image of the an application or option ROM. >> >> IMHO the shell should try as hard as possible to function and should not ASSERT if some newer Protocol is missing. >> >> Thanks, >> >> Andre wFish > I had to put a context of the ASSERT message in the original message to make it more clear: > > add-symbol-file /home/user1/workspace/juno_16.09/uefi/edk2/Build/ArmJuno/DEBUG_GCC49/AARCH64/ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe/DEBUG/ArmJunoDxe.dll 0xF8AB9000 > Loading driver at 0x000F8AB8000 EntryPoint=0x000F8AB9048 ArmJunoDxe.efi > > ASSERT_EFI_ERROR (Status = Not Found) > ASSERT [ArmJunoDxe] /home/danegr01/workspace/juno_16.09/uefi/edk2/ShellPkg/Library/UefiShellLib/UefiShellLib.c(305): !EFI_ERROR (Status) > > If driver includes a module which has dependency on one of the protocols, should the driver know about this dependency? Probably not. It should be inherited from the module. Adding [Depex] to UefiShellLib corrected dispatching ArmJunoDxe and EnglishDxe by the Dxe Core. > Daniil, Sorry, I was assuming the UefiShellLib only supported UEFI Applications. Thats what I get for not looking at the code :(, my bad. https://github.com/tianocore/edk2/blob/master/ShellPkg/Library/UefiShellLib/UefiShellLib.inf#L23 LIBRARY_CLASS = ShellLib|UEFI_APPLICATION UEFI_DRIVER DXE_RUNTIME_DRIVER DXE_DRIVER Given the library supports DXE_RUNTIME_DRIVER and DXE_DRIVER I think you are right it should publish a Depex if it has a hard dependency. I'm guessing that your DXE Driver is dispatching prior UEFI Driver that publishes the protocol. Thanks, Andrew Fish >> >> >>> The following dependency in UefiShellLib.inf fixes ASSERT problem: >>> >>> [Depex] >>> gEfiUnicodeCollation2ProtocolGuid >>> >>> >>> Thanks, >>> >>> Daniil >>> >>> >>> On 10/05/2016 11:02 AM, Shah, Tapan wrote: >>>> It's possible. But I think gEfiUnicodeCollation2ProtocolGuid protocol is necessary for even other Shell libraries other than UefiShellLib in order to have Shell parser and other command line processing to work properly. That's why I added ASSERT if UefiShellLib fails to locate the protocol. >>>> Reference platform should have EnglishDxe module to have this protocol installed properly. >>>> >>>> MdeModulePkg/Universal/Disk/UnicodeCollation/EnglishDxe/EnglishDxe.inf >>>> >>>> -----Original Message----- >>>> From: Carsey, Jaben [mailto:jaben.carsey@intel.com] >>>> Sent: Wednesday, October 05, 2016 10:41 AM >>>> To: Supreeth Venkatesh ; edk2-devel-01 ; Shah, Tapan >>>> Cc: Leif Lindholm ; Carsey, Jaben >>>> Subject: RE: Assert in ShellPkg with latest tianocore edk2 source on the Reference Platform >>>> >>>> Tapan, >>>> >>>> Could this be a side effect of your patch? Should we allow the UefiShellLib to continue without this protocol and then return an error only when the OpenFile is called? >>>> >>>> Also, it looks like we never properly initialize mUnicodeCollationProtocol. We check for NULL in Constructor, but nothing else... >>>> >>>> -Jaben >>>> >>>>> -----Original Message----- >>>>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >>>>> Supreeth Venkatesh >>>>> Sent: Tuesday, October 04, 2016 3:51 PM >>>>> To: edk2-devel-01 >>>>> Cc: Leif Lindholm >>>>> Subject: [edk2] Assert in ShellPkg with latest tianocore edk2 source >>>>> on the Reference Platform >>>>> Importance: High >>>>> >>>>> All, >>>>> >>>>> Recently, I updated to latest edk2 master (yesterday's) and I am >>>>> actually encountering assert in >>>>> ShellPkg/Library/UefiShellLib/UefiShellLib.c >>>>> >>>>> if (mUnicodeCollationProtocol == NULL) { >>>>> Status = gBS->LocateProtocol (&gEfiUnicodeCollation2ProtocolGuid, >>>>> NULL, (VOID**)&mUnicodeCollationProtocol); >>>>> ASSERT_EFI_ERROR (Status); >>>>> } >>>>> >>>>> It was working few weeks back and has now stopped working. >>>>> It's probably because the platform is unable to locate this protocol >>>>> "UnicodeCollationProtocol". >>>>> Is Anyone else facing the same issue? >>>>> Does the new ShellPkg requires additional packages/infs to be included >>>>> in the platform description file to work with latest changes to get >>>>> past this error? >>>>> >>>>> Thanks, >>>>> Supreeth >>>>> IMPORTANT NOTICE: The contents of this email and any attachments are >>>>> confidential and may also be privileged. If you are not the intended >>>>> recipient, please notify the sender immediately and do not disclose >>>>> the contents to any other person, use it for any purpose, or store or >>>>> copy the information in any medium. Thank you. >>>>> _______________________________________________ >>>>> edk2-devel mailing list >>>>> edk2-devel@lists.01.org >>>>> https://lists.01.org/mailman/listinfo/edk2-devel >>>> _______________________________________________ >>>> edk2-devel mailing list >>>> edk2-devel@lists.01.org >>>> https://lists.01.org/mailman/listinfo/edk2-devel >>> _______________________________________________ >>> edk2-devel mailing list >>> edk2-devel@lists.01.org >>> https://lists.01.org/mailman/listinfo/edk2-devel >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel