From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EF9FC2116327F for ; Mon, 8 Oct 2018 04:54:34 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 679665F744; Mon, 8 Oct 2018 11:54:33 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-219.rdu2.redhat.com [10.10.120.219]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2328E1057060; Mon, 8 Oct 2018 11:54:31 +0000 (UTC) To: Dandan Bi , edk2-devel@lists.01.org Cc: Ruiyu Ni , Michael D Kinney , Liming Gao References: <20181008033158.10652-1-dandan.bi@intel.com> From: Laszlo Ersek Message-ID: <9a04f184-3411-3e1c-26c5-fdb38b750198@redhat.com> Date: Mon, 8 Oct 2018 13:54:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181008033158.10652-1-dandan.bi@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 08 Oct 2018 11:54:33 +0000 (UTC) Subject: Re: [patch 1/5] MdePkg: Correct the string expression of UTF8 vendor device path X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2018 11:54:35 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Dandan, On 10/08/18 05:31, Dandan Bi wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1225 > > According to UEFI spec, the string expression of UTF8 vendor > device node should be displayed as: VenUtf8(). Current code > display it as: VenUft8() by mistake when convert device > path node to text. > > This commit is to fix this bug. > > Cc: Ruiyu Ni > Cc: Michael D Kinney > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi > --- > MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > index 7d8d304f6f..85f5e97131 100644 > --- a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > +++ b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > @@ -193,11 +193,11 @@ DevPathToTextVendor ( > return ; > } else if (CompareGuid (&Vendor->Guid, &gEfiVT100PlusGuid)) { > UefiDevicePathLibCatPrint (Str, L"VenVt100Plus()"); > return ; > } else if (CompareGuid (&Vendor->Guid, &gEfiVTUTF8Guid)) { > - UefiDevicePathLibCatPrint (Str, L"VenUft8()"); > + UefiDevicePathLibCatPrint (Str, L"VenUtf8()"); > return ; > } else if (CompareGuid (&Vendor->Guid, &gEfiUartDevicePathGuid)) { > FlowControlMap = (((UART_FLOW_CONTROL_DEVICE_PATH *) Vendor)->FlowControlMap); > switch (FlowControlMap & 0x00000003) { > case 0: > it makes sense to send a set of patches that are correlated in some fashion, even if they individually address different BZs and don't form a coherent "feature" or larger "bugfix". However, even in such cases, please send a common cover letter (0/5 in this case). Seeing a unified diffstat, and a few intro words (about the common theme of the patch set) is helpful. (no need to repost, just for the future) Thanks Laszlo