From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::142; helo=mail-it1-x142.google.com; envelope-from=ming.huang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x142.google.com (mail-it1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 63B4A202E53C5 for ; Wed, 13 Feb 2019 03:39:45 -0800 (PST) Received: by mail-it1-x142.google.com with SMTP id y184so5169584itc.1 for ; Wed, 13 Feb 2019 03:39:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=HWtF2yiaiTzIXFShp/JBMkRYTAIXpRTClAvhxrEseRY=; b=h493WRNvDyHlKZjsF2IfBrAzIoH24k31JWZI7tZivTq6BqHw54iMowoLxMRovC3k5g 2O45T/M2uB/cswW+Bg0JR8Tlc8fCIVAoZsH20Z0tywCGdiWwNB+/DdK7EtUUfMNUhYht TUlRPcmuhLOSwFDVAEwCjWkazsa8CpnuN4ZTlFaWGHsTzLSDQ5Vt5TCQI65D995hvaAt 4BXRuI1CcugUUj9UjIuiqvE6ir9B/mstYVorq2uookrhU5Y8gMEVn4woO9yuRiRH99d5 7KAi7Fu0QS5UQ9cISKjk9Ftb7SQvG0LZrnJSq6lTyLOF7HAJm3tN2rXTcy2U2R4x4XZv HhCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HWtF2yiaiTzIXFShp/JBMkRYTAIXpRTClAvhxrEseRY=; b=H7+87GH+Eyhp0Vh69lZPWbcpTjcND+jD2ltLy2cxmNKCNqWekauLRpLa5dQF6kYtTr dWAdttKxIMxfmQtBwwAc3KLqUAcvBiNjLfiUNgyb9q1GGH3JCVxjUrLbf57BK9SavCTg xc6CfLt0A4P39TSgyXHxZIsbfpQ1nF2qIM0tKNUbULd+Pw76M5IsxMPDJUhO0YW9MCsa cgkAGz06jhII3nQZE0jx99pB9hyZix8NWGvzXr4XYzbvu6In0HVk6kVem8NFjJ1mPeNN vYN0Bq83OMT0/WCCFmYwW3Qt2EqYZKuyoXaQgzPO5Q0rg++1fuCSR1s0XkNIYOC456Rc N2mg== X-Gm-Message-State: AHQUAuaB2+gPmgP9AXDxiqO0UlhLsdkOx0EwHcuxs2i6a5EWUqaWy7pX MrynSkgebDP0QUFMG42yIQ0yhA== X-Google-Smtp-Source: AHgI3IZxgXjNeZZ1YVKbcTcCT+INCPEx+SlIIGB1ubrFS3+Z65GQKO71kek1/pW/Xw/7EIgsvFXG0w== X-Received: by 2002:a24:eb0b:: with SMTP id h11mr24613itj.138.1550057985172; Wed, 13 Feb 2019 03:39:45 -0800 (PST) Received: from [10.58.0.74] ([64.64.108.254]) by smtp.gmail.com with ESMTPSA id m196sm4344522itc.33.2019.02.13.03.39.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Feb 2019 03:39:44 -0800 (PST) To: Leif Lindholm Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, zhangfeng56@huawei.com References: <20190201133436.10500-1-ming.huang@linaro.org> <20190201133436.10500-2-ming.huang@linaro.org> <20190211150505.h7itd4fqvrfazeqs@bivouac.eciton.net> <49ffdca4-332a-2678-145a-50fb2be4d000@linaro.org> <20190213094222.4w64s3wnrc7fikv2@bivouac.eciton.net> From: Ming Huang Message-ID: <9a1cb0a7-b557-26d3-0f3a-19bbc9b7479f@linaro.org> Date: Wed, 13 Feb 2019 19:39:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20190213094222.4w64s3wnrc7fikv2@bivouac.eciton.net> Subject: Re: [PATCH edk2-platforms v1 01/16] Hisilicon/D0x: Remove SerdesLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Feb 2019 11:39:46 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 2/13/2019 5:42 PM, Leif Lindholm wrote: > On Wed, Feb 13, 2019 at 02:36:11PM +0800, Ming Huang wrote: >>> Should it not then also delete #include from >>> Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06.c, >>> Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.c and >>> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type09/MiscSystemSlotDesignationFunction.c >>> ? >>> >>> Meanwhile, >>> Platform/Hisilicon/D03/Library/OemMiscLib2P/BoardFeature2PHi1610.c >>> and >>> Platform/Hisilicon/D05/Library/OemMiscLibD05/BoardFeatureD05.c >>> both include this header, but >>> Platform/Hisilicon/D03/Library/OemMiscLib2P/OemMiscLib2PHi1610.inf >>> and >>> Platform/Hisilicon/D05/Library/OemMiscLibD05/OemMiscLibD05.inf >>> do not declare the dependency. >> >> OemMiscLibD06.c can remove the SerdesLib.h. As using the definitions in >> SerdesLib.h, other .c files can not remove the header file. > > If they are using definitions from the library header, but not the > library itself, there is something suspicious about the code > structuring. Yes, there are maybe some unreasonable design in code structuring for history reason. > > But in the meantime, if they are referencing library header files, > they need to list those libraryclasses in their .inf. Do you mean add SerdesLib back to SmbiosMiscDxe.inf? If yes, maybe this patch should be droped. Thanks > >>> Can you investigate and submit an updated patch addressing all of the >>> unnecessary references? >> >> This may takes a lot of time, as Hi1620(D06) is our important project, >> maybe we should focus on D06. > > Feel free to submit deletions for all and any platforms you are > unwilling to maintain. > > Best Regards, > > Leif > > >> Thanks >> >>> >>> Best Regards, >>> >>> Leif >>> >>>> Contributed-under: TianoCore Contribution Agreement 1.1 >>>> Signed-off-by: Ming Huang >>>> --- >>>> Platform/Hisilicon/D06/D06.dsc | 2 -- >>>> Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf | 1 - >>>> 2 files changed, 3 deletions(-) >>>> >>>> diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc >>>> index 396bd03c9d24..cbbd99e4a659 100644 >>>> --- a/Platform/Hisilicon/D06/D06.dsc >>>> +++ b/Platform/Hisilicon/D06/D06.dsc >>>> @@ -64,8 +64,6 @@ [LibraryClasses.common] >>>> >>>> CpldIoLib|Silicon/Hisilicon/Library/CpldIoLib/CpldIoLib.inf >>>> >>>> - SerdesLib|Silicon/Hisilicon/Hi1620/Library/Hi1620Serdes/Hi1620SerdesLib.inf >>>> - >>>> TimeBaseLib|EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.inf >>>> RealTimeClockLib|Silicon/Hisilicon/Library/M41T83RealTimeClockLib/M41T83RealTimeClockLib.inf >>>> OemMiscLib|Platform/Hisilicon/D06/Library/OemMiscLibD06/OemMiscLibD06.inf >>>> diff --git a/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf b/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf >>>> index 61cead7779b9..8e5c56fa41fd 100644 >>>> --- a/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf >>>> +++ b/Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf >>>> @@ -77,7 +77,6 @@ [LibraryClasses] >>>> >>>> IpmiCmdLib >>>> >>>> - SerdesLib >>>> >>>> [Protocols] >>>> gEfiSmbiosProtocolGuid # PROTOCOL ALWAYS_CONSUMED >>>> -- >>>> 2.9.5 >>>>