From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0ED32941948 for ; Thu, 12 Oct 2023 12:25:13 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=PG5a2mpXMQR3Ov+mU8JTxZHkL0gKYwBtddZq1pJKrXo=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1697113512; v=1; b=jo9nOYPM9VhjO1EkbDPNKpYdG+Yv7SH/sKngnu+QeOxMFh1tM5gfOXx1nDuBSGDJRFA2QhlE q2ienkwD3JAHJyL+ysgoYihFhHizNZyV4IEdRMNGERi6SRWv7V6VatHGpVoh07KKlRSC8rvBdg/ Tec98gEIOsTKOGZyTluRXt2c= X-Received: by 127.0.0.2 with SMTP id sgyLYY7687511xeaFa907Bdv; Thu, 12 Oct 2023 05:25:12 -0700 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web11.9775.1697113509115870448 for ; Thu, 12 Oct 2023 05:25:11 -0700 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8AxTeug5SdlGF4xAA--.24136S3; Thu, 12 Oct 2023 20:25:05 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Cxvdye5SdlLeUhAA--.5965S3; Thu, 12 Oct 2023 20:25:02 +0800 (CST) Message-ID: <9a2608ed-f6b2-5ed6-6b84-fe1b8e14a031@loongson.cn> Date: Thu, 12 Oct 2023 20:25:02 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [edk2-devel] [edk2-platforms PATCH 14/19] LoongArchQemuPkg/LsRealTimeClockLib: hide LibRtcVirtualNotifyEvent To: devel@edk2.groups.io, lixianglai@loongson.cn, lersek@redhat.com Cc: Bibo Mao References: <687bbaf5-3c2b-6d27-44a5-d19541ce97bd@redhat.com> <20231012090950.108577-1-lersek@redhat.com> <20231012090950.108577-15-lersek@redhat.com> From: "Chao Li" In-Reply-To: X-CM-TRANSID: AQAAf8Cxvdye5SdlLeUhAA--.5965S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQACCGUnV6UKJQAAsU X-Coremail-Antispam: 1Uk129KBj93XoWxGw45AF1DuFWrJFyxGr4kuFX_yoW5CrW5pr y8GF1xKryUtr1FvayUX34UXrWDtF4Yya1UJr4DJF48GryUJ3W0qF17Zr1qgr4UXr48KF1U Xw18tw42v3Z8WrXCm3ZEXasCq-sJn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnRJUUU9Fb4IE77IF4wAF F20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r 1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAF wI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1l84ACjcxK6I8E87Iv67 AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AKxVW8Jr0_Cr1UM2AIxVAIcxkEcVAq 07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx1lYx0E2Ix0cI8IcVAFwI0_JrI_Jr ylYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCj r7xvwVCIw2I0I7xG6c02F41lc7I2V7IY0VAS07AlzVAYIcxG8wCF04k20xvY0x0EwIxGrw CFx2IqxVCFs4IE7xkEbVWUJVW8JwCFI7km07C267AKxVWUXVWUAwC20s026c02F40E14v2 6r106r1rMI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2 Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_ Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMI IF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IUb6nQUUUUUU= = Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lichao@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: i8y5syuQ5rF3Fz2VmhpQ0nw1x7686176AA= Content-Type: multipart/alternative; boundary="------------JanH6pYPVHIPf2fyyGf7jfHX" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=jo9nOYPM; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --------------JanH6pYPVHIPf2fyyGf7jfHX Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Laszlo, This patch is look good to me. Thanks. Acked-by: Chao Li Thanks, Chao 在 2023/10/12 20:14, xianglai 写道: > Hi Laszlo Ersek: >> The RealTimeClockLib class header in edk2 mistakenly declares a function >> called LibRtcVirtualNotifyEvent(). No component ever calls this function >> crossing module boundaries; all RealTimeClockLib instances in edk2 and >> edk2-platforms are supposed to register (and do register) their >> SetVirtualAddressMap() notification functions. >> >> Rename LibRtcVirtualNotifyEvent() to VirtualNotifyEvent(), and make it >> static, in preparation for removing the LibRtcVirtualNotifyEvent() >> declaration from the lib class header later. >> >> Build-tested only (with "Loongson.dsc"). >> >> Cc: Bibo Mao >> Cc: Chao Li >> Cc: Xianglai li >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 >> Signed-off-by: Laszlo Ersek >> --- >> Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTimeClockLib.c >> | 5 +++-- >>   1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git >> a/Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTimeClockLib.c >> b/Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTimeClockLib.c >> >> index 4315c2074d2f..eeac011a9400 100644 >> --- >> a/Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTimeClockLib.c >> +++ >> b/Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTimeClockLib.c >> @@ -180,9 +180,10 @@ LibSetWakeupTime ( >>     @param[in]    Event   The Event that is being processed >>     @param[in]    Context Event Context >>   **/ >> +STATIC >>   VOID >>   EFIAPI >> -LibRtcVirtualNotifyEvent ( >> +VirtualNotifyEvent ( >>     IN EFI_EVENT        Event, >>     IN VOID             *Context >>     ) >> @@ -325,7 +326,7 @@ LibRtcInitialize ( >>     Status = gBS->CreateEventEx ( >>                     EVT_NOTIFY_SIGNAL, >>                     TPL_NOTIFY, >> -                  LibRtcVirtualNotifyEvent, >> +                  VirtualNotifyEvent, >>                     NULL, >>                     &gEfiEventVirtualAddressChangeGuid, >>                     &mRtcVirtualAddrChangeEvent >> > This patch was compiled and tested on loongson without problems, and > modification is agreed. > > Thanks, > > xianglai. > > >> >> >> >> > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109570): https://edk2.groups.io/g/devel/message/109570 Mute This Topic: https://groups.io/mt/101914663/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- --------------JanH6pYPVHIPf2fyyGf7jfHX Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi Laszlo,

This patch is look good to me. Thanks.

Acked-by: Chao Li <lichao@loongson.cn>


Thanks,
Chao
在 2023/10/12 20:14, xianglai 写道:
Hi Laszlo Ersek:
The RealTimeClockLib class header in edk2 mistakenly declares a function
called LibRtcVirtualNotifyEvent(). No component ever calls this function
crossing module boundaries; all RealTimeClockLib instances in edk2 and
edk2-platforms are supposed to register (and do register) their
SetVirtualAddressMap() notification functions.

Rename LibRtcVirtualNotifyEvent() to VirtualNotifyEvent(), and make it
static, in preparation for removing the LibRtcVirtualNotifyEvent()
declaration from the lib class header later.

Build-tested only (with "Loongson.dsc").

Cc: Bibo Mao <maobibo@loongson.cn>
Cc: Chao Li <lichao@loongson.cn>
Cc: Xianglai li <lixianglai@loongson.cn>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
  Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTimeClockLib.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTimeClockLib.c b/Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTimeClockLib.c
index 4315c2074d2f..eeac011a9400 100644
--- a/Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTimeClockLib.c
+++ b/Platform/Loongson/LoongArchQemuPkg/Library/LsRealTimeClockLib/LsRealTimeClockLib.c
@@ -180,9 +180,10 @@ LibSetWakeupTime (
    @param[in]    Event   The Event that is being processed
    @param[in]    Context Event Context
  **/
+STATIC
  VOID
  EFIAPI
-LibRtcVirtualNotifyEvent (
+VirtualNotifyEvent (
    IN EFI_EVENT        Event,
    IN VOID             *Context
    )
@@ -325,7 +326,7 @@ LibRtcInitialize (
    Status = gBS->CreateEventEx (
                    EVT_NOTIFY_SIGNAL,
                    TPL_NOTIFY,
-                  LibRtcVirtualNotifyEvent,
+                  VirtualNotifyEvent,
                    NULL,
                    &gEfiEventVirtualAddressChangeGuid,
                    &mRtcVirtualAddrChangeEvent

This patch was compiled and tested on loongson without problems, and modification is agreed.

Thanks,

xianglai.











_._,_._,_
Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#109570) | | Mute This Topic | New Topic
Your Subscription | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------JanH6pYPVHIPf2fyyGf7jfHX--