From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web08.2169.1628609779601165365 for ; Tue, 10 Aug 2021 08:36:19 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=o3GO+2WS; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [10.124.238.202] (unknown [167.220.2.74]) by linux.microsoft.com (Postfix) with ESMTPSA id 1B9F520B36E0; Tue, 10 Aug 2021 08:36:19 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1B9F520B36E0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1628609779; bh=xQuLcrRjHCiyNmU1oWmGcXX7nFuffgK5pythqsOFTW0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=o3GO+2WS1Xu3X3vOiif37wCy4xRGXJ0lq10pQ6qv9HHnBk9N7Q5/u7OnEncbdhdGR DhBu/INQTJIQTjjAkSUMPKrrCrY+UnQsJ/1M2K/9InCuT9t4fgByV3u1WN5SpCgisS c85/6FVolSbxA3OhYeZMs9r03x/ofjFIwzOpugdY= Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement To: devel@edk2.groups.io, ray.ni@intel.com, "Chaganty, Rangasai V" Cc: "Yao, Jiewen" References: <20210809133938.2430-1-mikuback@linux.microsoft.com> From: "Michael Kubacki" Message-ID: <9a5c7c6b-70c5-c1c0-6405-51149013c295@linux.microsoft.com> Date: Tue, 10 Aug 2021 11:36:19 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Installation is a platform decision. The buried dependency on boot mode in this particular function is just a roadblock platforms have to work around. The role of this API is to install the PPI. Thanks, Michael On 8/9/2021 9:47 PM, Ni, Ray wrote: > Michael, > Allowing the gPeiSmmAccessPpiGuid PPI installation in normal boot will further allow gEfiPeiSmmCommunicationPpiGuid > installation in normal path, while without your change neither of the PPIs is installed in normal boot. > > + Jiewen for potential security concern. > > Thanks, > Ray > >> -----Original Message----- >> From: Chaganty, Rangasai V >> Sent: Tuesday, August 10, 2021 6:46 AM >> To: mikuback@linux.microsoft.com; devel@edk2.groups.io >> Cc: Ni, Ray >> Subject: RE: [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement >> >> Reviewed-by: Sai Chaganty >> >> -----Original Message----- >> From: mikuback@linux.microsoft.com >> Sent: Monday, August 09, 2021 6:40 AM >> To: devel@edk2.groups.io >> Cc: Ni, Ray ; Chaganty, Rangasai V >> Subject: [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement >> >> From: Michael Kubacki >> >> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3539 >> >> PeiInstallSmmAccessPpi() currently requires the boot mode be set to S3 to actually install gEfiPeiMmAccessPpiGuid. >> >> This change removes this requirement in the function implementation for two reasons: >> >> 1. Practical use cases exist to require this PPI in cases other than >> the boot mode being set to BOOT_ON_S3_RESUME. >> >> 2. It is poor API design to implicitly bury this requirement within >> a function whose responsibility is to install the PPI. The caller >> can easily place arbitrary constraints around whether to call >> based on conditions such as the boot mode being >> BOOT_ON_S3_RESUME. >> >> Cc: Ray Ni >> Cc: Rangasai V Chaganty >> Signed-off-by: Michael Kubacki >> --- >> Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/PeiSmmAccessLib/PeiSmmAccessLib.c | 12 ------------ >> 1 file changed, 12 deletions(-) >> >> diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/PeiSmmAccessLib/PeiSmmAccessLib.c >> b/Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/PeiSmmAccessLib/PeiSmmAccessLib.c >> index d9bf4fba983e..4df0d695fdaf 100644 >> --- a/Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/PeiSmmAccessLib/PeiSmmAccessLib.c >> +++ b/Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/PeiSmmAcce >> +++ ssLib/PeiSmmAccessLib.c >> @@ -252,19 +252,7 @@ PeiInstallSmmAccessPpi ( >> EFI_SMRAM_HOB_DESCRIPTOR_BLOCK *DescriptorBlock; >> SMM_ACCESS_PRIVATE_DATA *SmmAccessPrivate; >> VOID *HobList; >> - EFI_BOOT_MODE BootMode; >> >> - Status = PeiServicesGetBootMode (&BootMode); >> - if (EFI_ERROR (Status)) { >> - // >> - // If not in S3 boot path. do nothing >> - // >> - return EFI_SUCCESS; >> - } >> - >> - if (BootMode != BOOT_ON_S3_RESUME) { >> - return EFI_SUCCESS; >> - } >> // >> // Initialize private data >> // >> -- >> 2.28.0.windows.1 > > > > >