From: "Gupta, Pankaj" <pankaj.gupta@amd.com>
To: Dionna Amalie Glaze <dionnaglaze@google.com>
Cc: devel@edk2.groups.io, Gerd Hoffmann <kraxel@redhat.com>,
James Bottomley <jejb@linux.ibm.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Ard Biesheuvel <ardb@kernel.org>,
"Min M. Xu" <min.m.xu@intel.com>, Andrew Fish <afish@apple.com>,
"Michael D. Kinney" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [PATCH v10 1/4] OvmfPkg: Add memory acceptance event in AmdSevDxe
Date: Tue, 14 Feb 2023 13:51:15 +0100 [thread overview]
Message-ID: <9a8e1ab8-c430-0a54-11be-581a2d9b6221@amd.com> (raw)
In-Reply-To: <CAAH4kHbL1gzvhpi2tFFcBZFjZtWWni5U52iy8xn22ZsQPvGjgg@mail.gmail.com>
>> ConvertPages: range 1000000 - 41AEFFF covers multiple entries
>> ConvertPages: range 1000000 - 41AEFFF covers multiple entries
>> Accepting all memory
>> Accepting all memory
>> Accepting all memory
>> Accepting all memory
>> EFI stub: ERROR: exit_boot() failed!
>> EFI stub: ERROR: efi_main() failed!
>> StartImage failed: Invalid Parameter
>> Thanks,
>> Pankaj
>
> 4 calls is telling me that "Accepting all memory" is somehow modifying
> the memory map each call, but that shouldn't be happening. You've
> confirmed that the body of the loop is getting skipped after the first
> call?
yes. This also changes the memory key every time. Below change solves
the issue
and don't even get even the second invocation of "Accepting all memory"
message. It seems "gBS->FreePool" changes the memory map every time?
+ //gBS->FreePool (AllDescMap);^M
Thanks,
Pankaj
next prev parent reply other threads:[~2023-02-14 12:51 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 0:56 [PATCH v10 0/4] Add safe unaccepted memory behavior Dionna Glaze
2023-01-26 0:56 ` [PATCH v10 1/4] OvmfPkg: Add memory acceptance event in AmdSevDxe Dionna Glaze
2023-01-26 10:30 ` Ard Biesheuvel
2023-01-26 16:04 ` Dionna Glaze
2023-02-09 13:35 ` [edk2-devel] " Gupta, Pankaj
2023-02-09 16:52 ` Dionna Glaze
2023-02-09 21:27 ` Dionna Glaze
2023-02-10 8:00 ` Gupta, Pankaj
2023-02-10 11:12 ` Ard Biesheuvel
2023-02-10 11:34 ` Gupta, Pankaj
2023-02-10 13:56 ` Gupta, Pankaj
2023-02-10 17:05 ` Dionna Glaze
2023-02-13 14:38 ` Gupta, Pankaj
2023-02-13 16:53 ` Dionna Glaze
2023-02-13 17:56 ` Gupta, Pankaj
2023-02-13 18:31 ` Dionna Glaze
2023-02-13 19:33 ` Lendacky, Thomas
2023-02-13 19:33 ` Gupta, Pankaj
2023-02-13 21:44 ` Dionna Glaze
2023-02-14 12:51 ` Gupta, Pankaj [this message]
2023-02-14 12:55 ` Gupta, Pankaj
2023-02-14 20:44 ` Dionna Glaze
2023-02-14 20:46 ` Gupta, Pankaj
[not found] ` <1743B21FF9509E5F.2641@groups.io>
2023-02-14 14:00 ` Gupta, Pankaj
2023-02-14 9:12 ` Gerd Hoffmann
2023-02-14 17:28 ` Dionna Glaze
2023-02-14 22:44 ` Lendacky, Thomas
2023-02-15 9:38 ` Gerd Hoffmann
2023-01-26 0:56 ` [PATCH v10 2/4] MdePkg: Introduce the SevMemoryAcceptance protocol Dionna Glaze
2023-01-26 1:24 ` Yao, Jiewen
2023-01-26 17:04 ` Dionna Glaze
2023-01-26 17:19 ` Ard Biesheuvel
2023-01-26 0:56 ` [PATCH v10 3/4] OvmfPkg: Implement AcceptAllUnacceptedMemory in AmdSevDxe Dionna Glaze
2023-01-26 0:56 ` [PATCH v10 4/4] OvmfPkg/PlatformPei: SEV-SNP make >=4GB unaccepted Dionna Glaze
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a8e1ab8-c430-0a54-11be-581a2d9b6221@amd.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox