From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.44]) by mx.groups.io with SMTP id smtpd.web10.5885.1676379088033785076 for ; Tue, 14 Feb 2023 04:51:28 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=RKFa9wTB; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.92.44, mailfrom: pankaj.gupta@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gLHNgHXYXbrYNgAWpmM3KLnUALgmKWJTP2EvNJUzkKge3WISAd2y14TIyhl8d4DFSp5hpz13L+3h9Te3Bz5DFaVYU7qKPJR1VD4jx4K5d8ygrUF+JQdfeW1PXZgfuq1liJDVTMXhF08qXHEHQKbY3rKeI4mLa2t9f6/HuKLt3+4L1JV0RIzc64Be98Cqvu0hlAV4s1dKdiY6rxXx8c23c6ceAOBZwazR/Em3Zrsn1DCPvRyZbhDy/2t9Jz6hvg/JPo0NQ7vaBgEoqF+utVaNYm6h2GnSnt36E/axJslFPhknpef0JEcmhKrrhxZ+7HYyLVZRIQb+GGs6djxy26Fe6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I41I6DVZqoxSgWtFn7iv/YsaLLB0o09Xew7i/8wSlSI=; b=BiJdJ4XLTJD8+fUn959RjwBJC53ePVv+FmCyaXwr64x3gngOuGYJw/hNsWp1apMoo2imDs3AG+bNwieJS4WG0ezIOTCFOx+WraDUYkOIveTU8I6i27Gv7SMpCSQ8QeFkfdzUZMhBPbmVRpFPTyY1p23nvEHsuTxZW4yZLhatMfFPa5cfkKMieeIBYk/uKuvMWu/SALd1v3PirJNdIu0jNpVbHHOKbf7+p+lQxq182Dey7M1dKQuphwQcNZBGvV65zWBTMJfuhkzb1Zp9M4hjv9bqJh7dyuV7h3DqfpGOAVltOWglJjy8zVkfFNKyU7Pidg2uq0RbpQw4+oApzU/V/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I41I6DVZqoxSgWtFn7iv/YsaLLB0o09Xew7i/8wSlSI=; b=RKFa9wTBuhyMWllX5Z/dJhccZNLFzg2H2F/5X2gfVQ2JQV5gUsf2WveDSrKHimzZ/4YUCf6JugvPcP2IPb+QujfS6EJ5h2PbypecGaov9q9RARH+bcpA3e3tShn7Ulys04EgAPq5riXNyBPmDbHGFGG/YNKmfx+WxnOtJIMYNyQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB2810.namprd12.prod.outlook.com (2603:10b6:5:41::21) by CY5PR12MB6648.namprd12.prod.outlook.com (2603:10b6:930:42::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 12:51:23 +0000 Received: from DM6PR12MB2810.namprd12.prod.outlook.com ([fe80::b84e:f638:fa40:27ef]) by DM6PR12MB2810.namprd12.prod.outlook.com ([fe80::b84e:f638:fa40:27ef%6]) with mapi id 15.20.6086.024; Tue, 14 Feb 2023 12:51:23 +0000 Message-ID: <9a8e1ab8-c430-0a54-11be-581a2d9b6221@amd.com> Date: Tue, 14 Feb 2023 13:51:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [edk2-devel] [PATCH v10 1/4] OvmfPkg: Add memory acceptance event in AmdSevDxe To: Dionna Amalie Glaze Cc: devel@edk2.groups.io, Gerd Hoffmann , James Bottomley , Jiewen Yao , Tom Lendacky , Ard Biesheuvel , "Min M. Xu" , Andrew Fish , "Michael D. Kinney" References: <20230126005647.3019225-1-dionnaglaze@google.com> <20230126005647.3019225-2-dionnaglaze@google.com> <0d8f2b0b-1d62-3db6-34c9-e9ce39838bce@amd.com> <9ea61013-e2c1-30a4-3be7-feed537c035a@amd.com> <52c7d139-3763-b4f2-ab5c-a0a925a1a3ff@amd.com> <39f4b07d-43ce-904c-991d-4789384c496c@amd.com> From: "Gupta, Pankaj" In-Reply-To: X-ClientProxiedBy: FR0P281CA0010.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::15) To DM6PR12MB2810.namprd12.prod.outlook.com (2603:10b6:5:41::21) Return-Path: Pankaj.Gupta@amd.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB2810:EE_|CY5PR12MB6648:EE_ X-MS-Office365-Filtering-Correlation-Id: b02f7d7e-7d9f-4dc2-d3d9-08db0e8a2d39 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: casQJHw/cRnolGupLZ0DP/2Ox+RF/16OY6uUSK0DlUd+2uhJds6XRJNBitMSnAzP1ozPr9/lxXSB9M4cxMlN4Bu93ht3+jCtCMKabS7MGujXvbCGkGh+J6IRs9C2QlEsupNzCO6s49LvZxKoIv69yYq55RJ/6eNoGo0sQKKwo2bVDErMDJt9JuP5uGcl4CzifCQbP6tuhqyuxhOYtG/gAOrUlavQO3N/jrQ1wolfBBcH6CQULNAmxN9KHtYE+vVZSJEYVmuNE3reLX6COSGw/Y4PTwvG/3CwLozPtET3pDSjuDH0cVzGi0qbcIPgzV1hrFyJJqo0KdvUjNKX9PKWjEFJHZPyG0lIqocl/2nbE1yasVVp3RKu+volYmTCfXn1jlrZ9CSDXhTTqHt3I8e84AGwHXLqV89UmhUimwSMBvWB3UbIPs6l9VpKgRFIei5zAuMLFgP4v1ghwyimV2KxrAnJxZAHpOll2a31k3trkGZuGlN23g+D5Mdhu29IzqNvRKqLZiM1T9IcAqVPopTKGtXP96XaSaVOqyv7iXxa3zMpqqSX8QWKg/DH3mTTagpdP90jlG8sn2FgXnL3RaNZcsgRe79dagWSNUkAHscuTmqshi52thvH9frMzcHW2ClV5JgdJYNBYvtRmZe+ndztqFsu1l4qeMwNvgCUHrV7cECvfXOltBRF0ByxDI8CcGIvSJ+IBo1uAKtP0qFmKFUAsGmrCbc32KnpvjWebkIQt+Q= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB2810.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(396003)(376002)(39860400002)(136003)(366004)(451199018)(31686004)(478600001)(6666004)(2616005)(6506007)(8676002)(6916009)(54906003)(6512007)(186003)(316002)(66476007)(66946007)(26005)(66556008)(83380400001)(6486002)(4326008)(36756003)(86362001)(41300700001)(4744005)(8936002)(5660300002)(38100700002)(31696002)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MmJBT2VpbnVTOE9oSHA0UUJOR3JLcHpnMmw1UkxxRUJnZlgwZU56UU5QbGxK?= =?utf-8?B?ZW9IaUJNRFZKTi9MM3hYaFdWMDU0dFAveE5UeEtVNEZXVEF4dkNKNTdNZUVD?= =?utf-8?B?RHRNODdrOVhxeU94S0loaTFyY2ExWWRZWW1Hbzhwd0U1dk5DTExSQXZTeE5C?= =?utf-8?B?cnhRMm0vYmExS1pVVFp1RTNSczRPWDk3Z3N1U3doSm5LcTdjVUZFN3NiTGhV?= =?utf-8?B?T2tHMS9lRm9wWTJiY2R4ZXpKT1habis0RkxUU1JvWno3cjcwUlpDVlpEVGpH?= =?utf-8?B?V0Z3MXVTVXRqaFlhRzdqUHJ6eEFhN2NwS1Rkc0YzbzRUbU16Z1FOblI4RjY3?= =?utf-8?B?UUlwUitmazhRZU0zaks3eCt3NmxpTEpUNlVqUEJlOXgwMXYrbUk0b2hKYjJz?= =?utf-8?B?eWY1dnRSeVhIS2lScFhvbTZEc3NBOFVxSWtyWlpMVFZMOXAxRE56TndYZXZn?= =?utf-8?B?U3BSdUoycEFIemxZaFhKd0RScmxkMWE4Z2RicStHYW5sZlNYdmVhRHFPMkRR?= =?utf-8?B?NjJUR05IZmxZSWFpMWRrY0N2bDNLL0RTSzJYQmxVTmFzZTdncUVERUQ2Y2ZQ?= =?utf-8?B?MnA5b2x0eFZPaWY1ZDRuTXllN0tGZ3lKYnV4WjhrWC9DWWVyR0F3bWpFYXAv?= =?utf-8?B?QVYvL25xeU5KT2hWTXJzR0VkRTBNd3NVUEw1QXFEOXpFdEt5eXlHRmdaTmxL?= =?utf-8?B?K2wrSlRrM1cyRndHU1YyUXZaMmUxd1o5TjRpNWxxcURPcDl2VDlGNERUeEJo?= =?utf-8?B?OWlmZTRDcVZSeEdQaUFRNysybW5nTTIzYWhtSzFqeDdoRWo1a1djRS9hMlFn?= =?utf-8?B?ZWdlQ1pwdmhMS2JaelQxdlcybytEWHRsUXZraUp2REFtTFhXd1Q0ZHpaamt3?= =?utf-8?B?eFNOdDlYeEwyNm5MSG5Delg4QkxTbG01Q3A2WFlVeXhWWVFNblBxdmlPcHo1?= =?utf-8?B?K1JvVkJGd3ppSW1HRWtCeXhlbTk5ZGxJdnpDZU55NWJjZ0VtaGVVeGJDNUZx?= =?utf-8?B?ZC9CckR4Y3o0ekVyL1krcWlGbjhUVWQxNVJuemwzNmNZaExlN1NjSUZQc1Av?= =?utf-8?B?QVg0OVg2enhQMlZBdk1aOEpmR2RyOHFOM2tBbjJsZGkrMjJvY21FSHE5aGFz?= =?utf-8?B?Q1ZTSEViL2gzOUczYklUcEw1VGYzRFowSGNWbXRxdHprdDdPL0VWUElEOUFr?= =?utf-8?B?U3JNbno2UFI5M1RMWjNPRHJ1ZkVkRWgyVnhrYWRjZEV0Z1MvSWp4T0lja3hj?= =?utf-8?B?SHltNkllMWlaUlRlendzK2Zkbm9DOG9iUkRpS1dtQk5Pek43c0pnRGRLazJH?= =?utf-8?B?YURoVjB0dlByTjltYUUrcVdQcG9hUmRjaFRQaFNtdkxCdGJSOE9YY09ZSVht?= =?utf-8?B?cTRBMjhTQmpicFUxZU1MU1JtN1VqL1ZOVmY3bUtmOURTQnpUdjM3TmJQMVhY?= =?utf-8?B?aDhCOFN3MTYzeDFkTkFlc1JlV1BLU1hES3JLdWFFS0dmRmRROEtoT3kvZG5X?= =?utf-8?B?aUJibm1rSHhFS0NLUkJnTE9UZlRFcHhZTUg5cFVZRFd1bVIvYnZ3TWZDL0c0?= =?utf-8?B?R0FYM21UTXIwZW02czRKLzlRc0VGNWFKbXNCZVRJM3JsenRDSzRDTkMwVFpD?= =?utf-8?B?bVQrdmRhMUlOUWxEWFdzSUc2NnNlUGdYdlhWYzlSMHZXQVE2eUV5UGY2UjVw?= =?utf-8?B?UlVDMm1YeUpvUTgraGxmYnpIZDY2NDFaa3piUFNacEhGMGtRaUNUZ28yM0xi?= =?utf-8?B?L0tDZnRjR2pzN29sbGJEbTNIaVNYTXRsN3FEcUdOSSsxMFFlQThOc0NwOXl4?= =?utf-8?B?cHdLRno2MjJjeXdVN1JTZEZaaVdLaUl4TkUvdHZEa0lvYlJ2WkdEZlpZc1JQ?= =?utf-8?B?ZzJpQnlpbVhTRWxMbWlaamJUUzlyYkVCTFdZeGJSZEUrTjllSzcwcVB5Z0pJ?= =?utf-8?B?aGE0T2VCM2ZzbzlCajg3QjY4eW1DQmFqU001c1VQZnhNR2x1WXpTbnBlS2JG?= =?utf-8?B?ejdDTlJlTnRDc0NNUngwZWtBWk5PeUxRWnNySjBwajU2Vm9oOWlDSy9KN3hQ?= =?utf-8?B?a3c5N1FYSUFIeXpqR2FoTUFFaWdVSzlwcTE2LzVwRHk0UGdjUGM4Yno5aHRH?= =?utf-8?Q?MwnsZ/S37yp0tfmiZ+esSea7e?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b02f7d7e-7d9f-4dc2-d3d9-08db0e8a2d39 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2810.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 12:51:23.2753 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kjsh8XLxqdIs4eMqp3L1OZJJg6/Vr2pTHQQkRl9yHV68an7dzW3pHmue/Z4LBVpqNBdWBhCKGM255o110LW27Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6648 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit >> ConvertPages: range 1000000 - 41AEFFF covers multiple entries >> ConvertPages: range 1000000 - 41AEFFF covers multiple entries >> Accepting all memory >> Accepting all memory >> Accepting all memory >> Accepting all memory >> EFI stub: ERROR: exit_boot() failed! >> EFI stub: ERROR: efi_main() failed! >> StartImage failed: Invalid Parameter >> Thanks, >> Pankaj > > 4 calls is telling me that "Accepting all memory" is somehow modifying > the memory map each call, but that shouldn't be happening. You've > confirmed that the body of the loop is getting skipped after the first > call? yes. This also changes the memory key every time. Below change solves the issue and don't even get even the second invocation of "Accepting all memory" message. It seems "gBS->FreePool" changes the memory map every time? + //gBS->FreePool (AllDescMap);^M Thanks, Pankaj