From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: Pete Batard <pete@akeo.ie>,
Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
devel@edk2.groups.io
Cc: Leif Lindholm <leif@nuviainc.com>,
Andrei Warkentin <awarkentin@vmware.com>
Subject: Re: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix incorrect display resolution
Date: Wed, 4 Nov 2020 18:23:06 +0100 [thread overview]
Message-ID: <9aa494c8-6024-a00c-ca7a-bc673ebb3ec2@arm.com> (raw)
In-Reply-To: <1c69a4a1-e78a-f201-2b25-ca7e2c68334c@akeo.ie>
On 11/4/20 10:08 AM, Pete Batard wrote:
> Looks like noone has reviewed this one yet. Let's fix that.
>
> On 2020.09.29 18:48, Samer El-Haj-Mahmoud wrote:
>> Fix https://github.com/pftf/RPi4/issues/100 by swapping RPi DisplayDxe
>> resolution settings for 640x480 and 800x600, which were incorrectly
>> mapped to the settings shown in the Setup configuration variable.
>>
>> Cc: Leif Lindholm <leif@nuviainc.com>
>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>> Cc: Pete Batard <pete@akeo.ie>
>> Cc: Andrei Warkentin <awarkentin@vmware.com>
>> Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
>> ---
>> Platform/RaspberryPi/Include/ConfigVars.h | 2 +-
>> Platform/RaspberryPi/RPi3/Readme.md | 4 ++--
>> Platform/RaspberryPi/RPi4/Readme.md | 4 ++--
>> 3 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/Platform/RaspberryPi/Include/ConfigVars.h
>> b/Platform/RaspberryPi/Include/ConfigVars.h
>> index 8094d4ef9ab9..c185bfe28b55 100644
>> --- a/Platform/RaspberryPi/Include/ConfigVars.h
>> +++ b/Platform/RaspberryPi/Include/ConfigVars.h
>> @@ -19,8 +19,8 @@ typedef struct {
>> *
>> * 800x600, 640x480, 1024x768, 720p, 1080p, native.
>> */
>> - UINT8 v640 : 1;
>> UINT8 v800 : 1;
>> + UINT8 v640 : 1;
>> UINT8 v1024 : 1;
>> UINT8 v720p : 1;
>> UINT8 v1080p : 1;
>> diff --git a/Platform/RaspberryPi/RPi3/Readme.md
>> b/Platform/RaspberryPi/RPi3/Readme.md
>> index 9080cff15841..3b1171a27c3b 100644
>> --- a/Platform/RaspberryPi/RPi3/Readme.md
>> +++ b/Platform/RaspberryPi/RPi3/Readme.md
>> @@ -226,8 +226,8 @@ UEFI Setting |
>> NAME | VALUE
>> CPU Clock | `CpuClock` | Low = `0x00000000`<br>
>> Default = `0x00000001` (default)<br> Max = `0x00000002`<br> Custom =
>> `0x00000003`
>> CPU Clock Rate (MHz) | `CustomCpuClock` | Hex numeric value,
>> 4-bytes<br> (e.g. `0x000005DC` for 1500 MHz)
>> **Display Configuration** |
>> -Virtual 640x480 | `DisplayEnableScaledVModes` | Checked
>> = Bit 0 set (i.e. `<DisplayEnableScaledVModes> \| 0x01`)
>> -Virtual 800x600 | `DisplayEnableScaledVModes` | Checked
>> = Bit 1 set (i.e. `<DisplayEnableScaledVModes> \| 0x02`)
>> +Virtual 640x480 | `DisplayEnableScaledVModes` | Checked
>> = Bit 1 set (i.e. `<DisplayEnableScaledVModes> \| 0x02`)
>> +Virtual 800x600 | `DisplayEnableScaledVModes` | Checked
>> = Bit 0 set (i.e. `<DisplayEnableScaledVModes> \| 0x01`)
>> Virtual 1024x768 | `DisplayEnableScaledVModes` | Checked
>> = Bit 2 set (i.e. `<DisplayEnableScaledVModes> \| 0x04`)
>> Virtual 720p | `DisplayEnableScaledVModes` | Checked
>> = Bit 3 set (i.e. `<DisplayEnableScaledVModes> \| 0x08`)
>> Virtual 1080p | `DisplayEnableScaledVModes` | Checked
>> = Bit 4 set (i.e. `<DisplayEnableScaledVModes> \| 0x10`)
>> diff --git a/Platform/RaspberryPi/RPi4/Readme.md
>> b/Platform/RaspberryPi/RPi4/Readme.md
>> index 98388e3caba1..3b2ed44e3c38 100644
>> --- a/Platform/RaspberryPi/RPi4/Readme.md
>> +++ b/Platform/RaspberryPi/RPi4/Readme.md
>> @@ -169,8 +169,8 @@ UEFI Setting |
>> NAME | VALUE
>> CPU Clock | `CpuClock` | Low = `0x00000000`<br>
>> Default = `0x00000001` (default)<br> Max = `0x00000002`<br> Custom =
>> `0x00000003`
>> CPU Clock Rate (MHz) | `CustomCpuClock` | Hex numeric value,
>> 4-bytes<br> (e.g. `0x000005DC` for 1500 MHz)
>> **Display Configuration** |
>> -Virtual 640x480 | `DisplayEnableScaledVModes` | Checked
>> = Bit 0 set (i.e. `<DisplayEnableScaledVModes> \| 0x01`)
>> -Virtual 800x600 | `DisplayEnableScaledVModes` | Checked
>> = Bit 1 set (i.e. `<DisplayEnableScaledVModes> \| 0x02`)
>> +Virtual 640x480 | `DisplayEnableScaledVModes` | Checked
>> = Bit 1 set (i.e. `<DisplayEnableScaledVModes> \| 0x02`)
>> +Virtual 800x600 | `DisplayEnableScaledVModes` | Checked
>> = Bit 0 set (i.e. `<DisplayEnableScaledVModes> \| 0x01`)
>> Virtual 1024x768 | `DisplayEnableScaledVModes` | Checked
>> = Bit 2 set (i.e. `<DisplayEnableScaledVModes> \| 0x04`)
>> Virtual 720p | `DisplayEnableScaledVModes` | Checked
>> = Bit 3 set (i.e. `<DisplayEnableScaledVModes> \| 0x08`)
>> Virtual 1080p | `DisplayEnableScaledVModes` | Checked
>> = Bit 4 set (i.e. `<DisplayEnableScaledVModes> \| 0x10`)
>>
>
> Reviewed-by: Pete Batard <pete@akeo.ie>
Pushed as aa0803917ac9..38c387d2dac6
Thanks all,
next prev parent reply other threads:[~2020-11-04 17:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 17:48 [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix incorrect display resolution Samer El-Haj-Mahmoud
2020-11-04 9:08 ` Pete Batard
2020-11-04 17:23 ` Ard Biesheuvel [this message]
2020-11-04 16:51 ` Andrei Warkentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9aa494c8-6024-a00c-ca7a-bc673ebb3ec2@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox