From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vito-vars.onthenet.com.au (vito-vars.onthenet.com.au [203.13.68.24]) by mx.groups.io with SMTP id smtpd.web08.56079.1606714634740112014 for ; Sun, 29 Nov 2020 21:37:15 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: iredmail.onthenet.com.au, ip: 203.13.68.24, mailfrom: srs0=s1ex=fe=freebsd.org=grehan@iredmail.onthenet.com.au) Received: from alto.onthenet.com.au (alto.OntheNet.com.au [203.13.68.12]) by vito-vars.onthenet.com.au (Postfix) with ESMTPS id 8E73B20917A4 for ; Mon, 30 Nov 2020 15:37:11 +1000 (AEST) Received: from iredmail.onthenet.com.au (iredmail.onthenet.com.au [203.13.68.150]) by alto.onthenet.com.au (Postfix) with ESMTPS id 772C9208D4E4 for ; Mon, 30 Nov 2020 15:37:11 +1000 (AEST) Received: from iredmail.onthenet.com.au (iredmail.onthenet.com.au [127.0.0.1]) by iredmail.onthenet.com.au (Postfix) with ESMTP id 6969D209BFDD for ; Mon, 30 Nov 2020 15:37:11 +1000 (AEST) Received: from iredmail.onthenet.com.au ([127.0.0.1]) by iredmail.onthenet.com.au (iredmail.onthenet.com.au [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id CCK0c4fSVyMO for ; Mon, 30 Nov 2020 15:37:11 +1000 (AEST) Received: from MacBook-Air-4.local (123-243-181-154.static.tpgi.com.au [123.243.181.154]) by iredmail.onthenet.com.au (Postfix) with ESMTPSA id 757AC209BFB8; Mon, 30 Nov 2020 15:37:09 +1000 (AEST) Subject: Re: [edk2-devel] [PATCH 0/5] OvmfPkg: Fix Bhyve code formatting and style problems To: devel@edk2.groups.io, rebecca@bsdio.com Cc: Jordan Justen , Laszlo Ersek , Ard Biesheuvel References: <20201130053412.2-1-rebecca@bsdio.com> From: "Peter Grehan" Message-ID: <9ab28985-3eb9-c080-80b2-15861536f70f@freebsd.org> Date: Mon, 30 Nov 2020 15:37:09 +1000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201130053412.2-1-rebecca@bsdio.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=RcsL92lv c=1 sm=1 tr=0 a=A6CF0fG5TOl4vs6YHvqXgw==:117 a=yK2slmdtS+yP90lyNyFUhg==:17 a=IkcTkHD0fZMA:10 a=nNwsprhYR40A:10 a=6I5d2MoRAAAA:8 a=mQtYM_ISKHraI5IyhkoA:9 a=QEXdDO2ut3YA:10 a=IjZwj45LgO3ly-622nXo:22 X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=LtAJNkVc c=1 sm=1 tr=0 a=mJOSnoNX3k71adV6TmU0eQ==:117 a=yK2slmdtS+yP90lyNyFUhg==:17 a=IkcTkHD0fZMA:10 a=nNwsprhYR40A:10 a=6I5d2MoRAAAA:8 a=mQtYM_ISKHraI5IyhkoA:9 a=QEXdDO2ut3YA:10 a=IjZwj45LgO3ly-622nXo:22 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Acked by: Peter Grehan > There are several problems with the code style and formatting in Bhyve related files. > These include using structs without typedef'ing them, wrong indentation (e.g. three > spaces instead of two), and UINTN/UINT32 mix-ups which cause build errors when > using VS 2019. > > I've taken this opportunity to also change the INF and DSC versions to decimal and > bump the version to 1.29 for INF files and 1.30 for the DSC. > > Rebecca Cran (5): > OvmfPkg: Fix BhyveFwCtlLib build with VS2019 > OvmfPkg: Improve code style/formatting in BhyveFwCtlLib.c > OvmfPkg: Fix style of BhyveFwCtlLib.inf > OvmfPkg: Improve style and formatting in BhyveFwCtlLib.h > OvmfPkg/Bhyve: Fix various style issues > > OvmfPkg/Bhyve/BhyveX64.dsc | 2 +- > .../Bhyve/AcpiPlatformDxe/AcpiPlatformDxe.inf | 18 +- > OvmfPkg/Bhyve/AcpiTables/AcpiTables.inf | 10 +- > OvmfPkg/Bhyve/BhyveRfbDxe/BhyveRfbDxe.inf | 8 +- > OvmfPkg/Bhyve/PlatformPei/PlatformPei.inf | 12 +- > .../SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 10 +- > .../Library/BhyveFwCtlLib/BhyveFwCtlLib.inf | 5 +- > OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.h | 10 +- > OvmfPkg/Bhyve/AcpiTables/Platform.h | 2 +- > OvmfPkg/Bhyve/BhyveRfbDxe/Gop.h | 6 +- > OvmfPkg/Bhyve/PlatformPei/Cmos.h | 6 +- > .../SmbiosPlatformDxe/SmbiosPlatformDxe.h | 7 +- > OvmfPkg/Include/Library/BhyveFwCtlLib.h | 24 +-- > OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 3 +- > OvmfPkg/Bhyve/AcpiPlatformDxe/Bhyve.c | 2 +- > OvmfPkg/Bhyve/PlatformPei/Fv.c | 2 +- > OvmfPkg/Bhyve/PlatformPei/Platform.c | 2 +- > OvmfPkg/Library/BhyveFwCtlLib/BhyveFwCtlLib.c | 162 +++++++++--------- > 18 files changed, 143 insertions(+), 148 deletions(-) >