From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 19 Sep 2019 12:47:02 -0700 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 56CFC3C928; Thu, 19 Sep 2019 19:47:01 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-45.rdu2.redhat.com [10.10.121.45]) by smtp.corp.redhat.com (Postfix) with ESMTP id 504B660167; Thu, 19 Sep 2019 19:46:59 +0000 (UTC) Subject: Re: [PATCH] Edk2: Add Zhichao as the maintainer for shellbin relase To: "Gao, Liming" , Leif Lindholm Cc: "Gao, Zhichao" , "devel@edk2.groups.io" , Andrew Fish , "Kinney, Michael D" , "Ni, Ray" , Ard Biesheuvel References: <20190919054531.8176-1-zhichao.gao@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4FE60A@SHSMSX104.ccr.corp.intel.com> <20190919091753.GM28454@bivouac.eciton.net> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4FEA2C@SHSMSX104.ccr.corp.intel.com> <20190919143904.GY28454@bivouac.eciton.net> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4FEBEC@SHSMSX104.ccr.corp.intel.com> From: "Laszlo Ersek" Message-ID: <9ab956e7-be17-af78-65b5-607eed406659@redhat.com> Date: Thu, 19 Sep 2019 21:46:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4FEBEC@SHSMSX104.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 19 Sep 2019 19:47:01 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/19/19 16:56, Gao, Liming wrote: > Leif: > >> -----Original Message----- >> From: Leif Lindholm [mailto:leif.lindholm@linaro.org] >> Sent: Thursday, September 19, 2019 10:39 PM >> To: Gao, Liming >> Cc: Gao, Zhichao ; devel@edk2.groups.io; Andrew Fish ; Laszlo Ersek ; >> Kinney, Michael D ; Ni, Ray ; Ard Biesheuvel >> Subject: Re: [PATCH] Edk2: Add Zhichao as the maintainer for shellbin relase >> >> On Thu, Sep 19, 2019 at 02:16:44PM +0000, Gao, Liming wrote: >>> Leif: >>> >>>> -----Original Message----- >>>> From: Leif Lindholm [mailto:leif.lindholm@linaro.org] >>>> Sent: Thursday, September 19, 2019 5:18 PM >>>> To: Gao, Liming >>>> Cc: Gao, Zhichao ; devel@edk2.groups.io; Andrew Fish ; Laszlo Ersek >> ; >>>> Kinney, Michael D ; Ni, Ray ; Ard Biesheuvel >>>> Subject: Re: [PATCH] Edk2: Add Zhichao as the maintainer for shellbin relase >>>> >>>> I have no objection to this addition, but I do have two questions - and >>>> really I realise this is a follow-on for 81a8a52a6bb21 ("ShellBinPkg: >>>> Remove ShellBinPkg"): >>>> >>>> 1) Since ShellBinPkg no longer exists, what is the intent of listing >>>> this in the Maintainers.txt file? Generally, this is so that people >>>> know who to Cc: on patches - but there will not be any patches here. >>> >>> Here is the info who can be contacted to generate the binary files >>> for the quarter stable tag. >> >> I agree this is important to keep somewhere. But I am unsure if >> Maintainers.txt is the location for that. Clearly it was when >> ShellBinPkg existed, but I am not sure now. >> >> And yes, this is something I should have realised when ShellBinPkg was >> removed - but I didn't at that point. So there is no need to hold >> back this patch. >> > OK. This patch can be pushed first. > >> But I think it would make possibly more sense to add this information >> either into a ShellPkg/Readme.md or the wiki. If we keep the >> information in Maintainers.txt, I would suggest creating a new >> section below "EDK II Releases:" with a W: entry pointing somewhere. > > I will take your suggestion to move this info to EDK II Releases: section in Maintainers.txt. > I will send another patch for this change. Sounds good to me. Thanks Laszlo >>>> 2) If Zhichao is now responsible for this, should Jaben and Ray still >>>> be listed? >>>> >>> I think Jaben and Ray can be removed. >>> >>> Thanks >>> Liming >>>> Best Regards, >>>> >>>> Leif >>>> >>>> On Thu, Sep 19, 2019 at 05:58:16AM +0000, Gao, Liming wrote: >>>>> Reviewed-by: Liming Gao >>>>> >>>>>> -----Original Message----- >>>>>> From: Gao, Zhichao >>>>>> Sent: Thursday, September 19, 2019 1:46 PM >>>>>> To: devel@edk2.groups.io >>>>>> Cc: Andrew Fish ; Laszlo Ersek ; Leif >>>>>> Lindholm ; Kinney, Michael D >>>>>> ; Ni, Ray ; Ard Biesheuvel >>>>>> ; Gao, Liming >>>>>> Subject: [PATCH] Edk2: Add Zhichao as the maintainer for shellbin relase >>>>>> >>>>>> Zhichao is responsible for the IA32 and X64 ARCH shell binary generation. >>>>>> >>>>>> Cc: Andrew Fish >>>>>> Cc: Laszlo Ersek >>>>>> Cc: Leif Lindholm >>>>>> Cc: Michael D Kinney >>>>>> Cc: Ray Ni >>>>>> Cc: Ard Biesheuvel >>>>>> Cc: Liming Gao >>>>>> Signed-off-by: Zhichao Gao >>>>>> --- >>>>>> Maintainers.txt | 1 + >>>>>> 1 file changed, 1 insertion(+) >>>>>> >>>>>> diff --git a/Maintainers.txt b/Maintainers.txt >>>>>> index dcf81c737a..a0121123ec 100644 >>>>>> --- a/Maintainers.txt >>>>>> +++ b/Maintainers.txt >>>>>> @@ -426,6 +426,7 @@ Maintainers for stable Shell binaries generation >>>>>> when need to publish Shell binaries with edk2 release: >>>>>> M: Jaben Carsey (Ia32/X64) >>>>>> M: Ray Ni (Ia32/X64) >>>>>> +M: Zhichao Gao (Ia32/X64) >>>>>> M: Leif Lindholm (ARM/AArch64) >>>>>> M: Ard Biesheuvel (ARM/AArch64) >>>>>> >>>>>> -- >>>>>> 2.21.0.windows.1 >>>>>