Re: [edk2-devel] [PATCH] ArmPkg/ArmGic: Fix maximum number of interrupts in GICv3

["Laszlo Ersek" <lersek@redhat.com>]

On 05/23/21 11:03, Ard Biesheuvel wrote:
> On Sun, 23 May 2021 at 10:55, Laszlo Ersek <lersek@redhat.com> wrote:
>>
>> On 05/21/21 12:49, Joey Gouly wrote:
>>>> From: Joey Gouly <joey.gouly@arm.com>
>>>> Sent: 09 March 2021 16:45
>>>> Subject: [PATCH] ArmPkg/ArmGic: Fix maximum number of interrupts in GICv3
>>>
>>> Hi,
>>>
>>> A little ping on this. Can someone take a look?
>>>
>>> There was a similar patch here, that addressed the same issue https://edk2.groups.io/g/devel/topic/82327316#74401 so I think it would be good get this in.
>>
>> This even looks like a candidate for edk2-stable202105 to me (it's small
>> and arguably a clear-cut bugfix).
>>
>> NB the comment style should be:
>>
>>   //
>>   // Interrupt ID 1020-1023 are reserved:
>>   //
>>
>> IOW, we need a trailing and a leading empty comment line, plus the
>> semicolon at the end of the comment should likely be a colon, or maybe
>> just a period.
>>
> 
> With that,
> 
> Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
> 

Thank you, Ard!

Joey, can you please resubmit the patch with the comment fix, and Ard's
R-b, quickly?

Please use the following subject prefix:

  [edk2-devel202105 PATCH v2]

Also, please file a bugzilla ticket for this issue at
<https://bugzilla.tianocore.org/>, and include the BZ URL in the commit
message. (It wouldn't be really necessary for such a small patch, but a
ticket is required during the feature freeze.)

Thanks
Laszlo