From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web09.8999.1621769229216593264 for ; Sun, 23 May 2021 04:27:09 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NIm/czsU; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621769228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XlmqhlqRpPf6qe0iHHUxd1oTHA0biYZkXrj0KItD7/I=; b=NIm/czsU0psuXKxrHEDXjo1+Hw/SkZFxYguf/xoxT/vxLKe9mdqIpVNIseaxorSwdKMUYi jNa6E9aa5J4KL6n4LQsLs0ThEijdEmfwc2kuyPIdA/wKcOaVJLhLu9PIM0d1yw4LXPRurG 15nrCpjQt+mg4m5XHl7sHxQR2IDAhVg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-143-rplT2sAaOVe74rSkz_ptIA-1; Sun, 23 May 2021 07:27:04 -0400 X-MC-Unique: rplT2sAaOVe74rSkz_ptIA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 61B93180FD60; Sun, 23 May 2021 11:27:03 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-8.ams2.redhat.com [10.36.112.8]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7E3D160C17; Sun, 23 May 2021 11:27:01 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH] ArmPkg/ArmGic: Fix maximum number of interrupts in GICv3 To: Ard Biesheuvel , joey.gouly@arm.com Cc: edk2-devel-groups-io , "ardb+tianocore@kernel.org" , "leif@nuviainc.com" , Sami Mujawar , Andreas Sandberg , nd References: <20210309164510.19272-1-joey.gouly@arm.com> <15e1864b-1eb3-921b-3b10-2aba99afc9a0@redhat.com> From: "Laszlo Ersek" Message-ID: <9af50a9a-d64f-7036-8b0f-a2aeda9acf8f@redhat.com> Date: Sun, 23 May 2021 13:26:59 +0200 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05/23/21 11:03, Ard Biesheuvel wrote: > On Sun, 23 May 2021 at 10:55, Laszlo Ersek wrote: >> >> On 05/21/21 12:49, Joey Gouly wrote: >>>> From: Joey Gouly >>>> Sent: 09 March 2021 16:45 >>>> Subject: [PATCH] ArmPkg/ArmGic: Fix maximum number of interrupts in GICv3 >>> >>> Hi, >>> >>> A little ping on this. Can someone take a look? >>> >>> There was a similar patch here, that addressed the same issue https://edk2.groups.io/g/devel/topic/82327316#74401 so I think it would be good get this in. >> >> This even looks like a candidate for edk2-stable202105 to me (it's small >> and arguably a clear-cut bugfix). >> >> NB the comment style should be: >> >> // >> // Interrupt ID 1020-1023 are reserved: >> // >> >> IOW, we need a trailing and a leading empty comment line, plus the >> semicolon at the end of the comment should likely be a colon, or maybe >> just a period. >> > > With that, > > Reviewed-by: Ard Biesheuvel > Thank you, Ard! Joey, can you please resubmit the patch with the comment fix, and Ard's R-b, quickly? Please use the following subject prefix: [edk2-devel202105 PATCH v2] Also, please file a bugzilla ticket for this issue at , and include the BZ URL in the commit message. (It wouldn't be really necessary for such a small patch, but a ticket is required during the feature freeze.) Thanks Laszlo