From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124])
 by mx.groups.io with SMTP id smtpd.web12.36933.1610990774681229178
 for <devel@edk2.groups.io>;
 Mon, 18 Jan 2021 09:26:14 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aY1hNfmr;
 spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1610990773;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=DQBsZ8fvnA/o4o63tC29+dHgxqUT7KaO8iPK+9iLCc8=;
	b=aY1hNfmrE2JES2bj49y+efiZtmlzsOgZ4ByHSMc22uQom81TWKUhiTzspMSzJx6FnPA35W
	I1vGJ9j8KkandqrFglwM1GT7OudIAiWio1T9Q6l62yLND6Z74okx7XKQDnxgNerWpTdrUj
	wcizs4B2MlIZGOmGfEOvarTYlL7rX38=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-288-eOxpx-B-Peu3_kThINkKmA-1; Mon, 18 Jan 2021 12:26:09 -0500
X-MC-Unique: eOxpx-B-Peu3_kThINkKmA-1
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5A2B8107ACE3;
	Mon, 18 Jan 2021 17:26:05 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-48.ams2.redhat.com [10.36.112.48])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 2E2E360C67;
	Mon, 18 Jan 2021 17:26:01 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH v4 0/9] Add extra pci roots support for Arm
To: devel@edk2.groups.io, cenjiahui@huawei.com
Cc: Jordan Justen <jordan.l.justen@intel.com>,
 Ard Biesheuvel <ard.biesheuvel@arm.com>, Rebecca Cran <rebecca@bsdio.com>,
 Peter Grehan <grehan@freebsd.org>, Anthony Perard
 <anthony.perard@citrix.com>, Julien Grall <julien@xen.org>,
 Leif Lindholm <leif@nuviainc.com>, Sami Mujawar <sami.mujawar@arm.com>,
 xieyingtai@huawei.com, wu.wubin@huawei.com, Yubo Miao <miaoyubo@huawei.com>
References: <20210112094549.10238-1-cenjiahui@huawei.com>
 <956970aa-fd13-92fc-adb2-5308a493b334@redhat.com>
 <37dc9c07-00a3-c0a5-3e1c-318004c9c56c@huawei.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <9b21e604-eba9-4297-2f3e-f668051d4884@redhat.com>
Date: Mon, 18 Jan 2021 18:26:00 +0100
MIME-Version: 1.0
In-Reply-To: <37dc9c07-00a3-c0a5-3e1c-318004c9c56c@huawei.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 01/14/21 13:51, Jiahui Cen via groups.io wrote:
> Hi Laszlo,
> 
> On 2021/1/14 19:53, Laszlo Ersek wrote:
>> On 01/12/21 10:45, Jiahui Cen wrote:
>>> v3->v4:
>>> * Refactor InitRootBridges/UninitRootBridges/GetRootBridges/FreeRootBridges.
>>> * Fix library dependencies.
>>>
>>> v2->v3:
>>> * Rename utility functions under the PciHostBridgeUtilityLib namespace.
>>> * Remove some unused Library dependencies.
>>> * Sort the Include headers.
>>>
>>> v1->v2:
>>> * Separated into four patches.
>>> * Factor the same logic parts into a new library.
>>>
>>> v3: https://edk2.groups.io/g/devel/message/69382
>>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3059
>>> QEMU: https://lore.kernel.org/qemu-devel/20201119014841.7298-1-cenjiahui@huawei.com/
>>>
>>> This patch series adds support for extra pci roots for ARM.
>>>
>>> In order to avoid duplicated codes, we introduce a new library
>>> PciHostBridgeUtilityLib which extracts common interfaces from
>>> OvmfPkg/PciHostBridgeLib. It provides conflicts informing and extra pci
>>> roots scanning. Using the utility lib, the uefi could scan for extra
>>> root buses and recognize multiple roots for ARM.
>>>
>>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>>> Cc: Laszlo Ersek <lersek@redhat.com>
>>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>>> Cc: Rebecca Cran <rebecca@bsdio.com>
>>> Cc: Peter Grehan <grehan@freebsd.org>
>>> Cc: Anthony Perard <anthony.perard@citrix.com>
>>> Cc: Julien Grall <julien@xen.org>
>>> Cc: Leif Lindholm <leif@nuviainc.com>
>>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>>> Signed-off-by: Jiahui Cen <cenjiahui@huawei.com>
>>> Signed-off-by: Yubo Miao <miaoyubo@huawei.com>
>>
>> I've finished reviewing this version; please submit v6.
>>
> 
> Thanks for the detailed review. I'll carefully fix them as you points
> and submit v6 soon.

I'm looking forward to v6; I'd really like to merge that, so I can move
on to reviewing other patches.

Thanks!
Laszlo