From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id BB2A0D80D5A for ; Mon, 11 Dec 2023 15:00:50 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=DQN5xchB4HApzNY2HGn+GybkJsQCEEsb0lrVLp9Syv8=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702306849; v=1; b=S35lGNv95Lvr8h8/Y/KjkvpMyUTdSpqv0jWNSS7AJSRfLgaVHrN2Y/tDHijLnNqDQSwRwbLV xPhOXlNS3Iu1UqsCFL8xA4WyeCfPMKkHMdna9yyj8sHodTYJZ1wndGKn4R4vIQ4lIlw7PH25W78 e3rhiKDk3AXcLCRM5VZslUmU= X-Received: by 127.0.0.2 with SMTP id eefCYY7687511x4XCvYQ0MIL; Mon, 11 Dec 2023 07:00:49 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.10343.1702306848693745948 for ; Mon, 11 Dec 2023 07:00:48 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-563-Op8GnGHUM1WOWMD2mKloJA-1; Mon, 11 Dec 2023 10:00:26 -0500 X-MC-Unique: Op8GnGHUM1WOWMD2mKloJA-1 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5773E803936; Mon, 11 Dec 2023 15:00:08 +0000 (UTC) X-Received: from [10.39.194.43] (unknown [10.39.194.43]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7F8D32166B31; Mon, 11 Dec 2023 15:00:07 +0000 (UTC) Message-ID: <9b333ba1-7ce6-5be7-6482-3aadef7f1973@redhat.com> Date: Mon, 11 Dec 2023 16:00:06 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH] BaseTools/tools_def: Disable unneeded-internal-declaration warning in CLANGPDB To: devel@edk2.groups.io, mjsbeaton@gmail.com, Ard Biesheuvel Cc: ardb@google.com References: <20231210101859.19198-1-mjsbeaton@gmail.com> From: "Laszlo Ersek" In-Reply-To: <20231210101859.19198-1-mjsbeaton@gmail.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: UsbHsUVkxHXOIUa1jAFfhtX3x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=S35lGNv9; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On 12/10/23 11:18, Mike Beaton wrote: > From: Mike Beaton >=20 > This warning was already disabled in CLANGDWARF by commit > d3225577123767fd09c91201d27e9c91663ae132. >=20 > gcc can distinguish between optimised-away variable usage (as can occur = in > valid debug code) and genuinely unused variables, and only complains abou= t > the latter. clang cannot, and therefore this warning ends up complaining > about valid debug code under clang. >=20 > Since EDK-II code is in general going to be compiled by gcc as well as cl= ang > then disabling this warning in clang does not amount to entirely removing > potentially valid warnings about genuinely unused variables. >=20 > Signed-off-by: Mike Beaton > --- > BaseTools/Conf/tools_def.template | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def= .template > index c34ecfd557..48cf45245f 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -1754,7 +1754,7 @@ DEFINE CLANGPDB_X64_PREFIX =3D ENV(CLANG_= BIN) > DEFINE CLANGPDB_IA32_TARGET =3D -target i686-unknown-windows-gn= u > DEFINE CLANGPDB_X64_TARGET =3D -target x86_64-unknown-windows-= gnu > =20 > -DEFINE CLANGPDB_WARNING_OVERRIDES =3D -Wno-parentheses-equality -Wno-= tautological-compare -Wno-tautological-constant-out-of-range-compare -Wno-e= mpty-body -Wno-unused-const-variable -Wno-varargs -Wno-unknown-warning-opti= on -Wno-unused-but-set-variable -Wno-unused-const-variable -Wno-unaligned-a= ccess -Wno-microsoft-enum-forward-reference > +DEFINE CLANGPDB_WARNING_OVERRIDES =3D -Wno-parentheses-equality -Wno-= tautological-compare -Wno-tautological-constant-out-of-range-compare -Wno-e= mpty-body -Wno-unused-const-variable -Wno-varargs -Wno-unknown-warning-opti= on -Wno-unused-but-set-variable -Wno-unused-const-variable -Wno-unaligned-a= ccess -Wno-unneeded-internal-declaration -Wno-microsoft-enum-forward-refere= nce > DEFINE CLANGPDB_ALL_CC_FLAGS =3D DEF(GCC48_ALL_CC_FLAGS) DEF(CLA= NGPDB_WARNING_OVERRIDES) -fno-stack-protector -funsigned-char -ftrap-functi= on=3Dundefined_behavior_has_been_optimized_away_by_clang -Wno-address -Wno-= shift-negative-value -Wno-unknown-pragmas -Wno-incompatible-library-redecla= ration -Wno-null-dereference -mno-implicit-float -mms-bitfields -mno-stack-= arg-probe -nostdlib -nostdlibinc -fseh-exceptions > =20 > ########################### AFAICT, CLANGPDB_WARNING_OVERRIDES gets included in CLANGPDB_ALL_CC_FLAGS, which in turn gets included in all three of DEBUG, RELEASE and NOOPT build target flags. The original report was "RELEASE CLANGPDB OVMF currently does not compile". Can we use "-Wno-unneeded-internal-declaration" with RELEASE builds only? Thanks, Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112304): https://edk2.groups.io/g/devel/message/112304 Mute This Topic: https://groups.io/mt/103087794/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-