Re: [PATCH 1/4] ArmVirtPkg/FdtClientDxe: fix check for size of "reg" properties

[Laszlo Ersek <lersek@redhat.com>]

On 09/15/16 15:30, Ard Biesheuvel wrote:
> Currently, the code in FdtClientDxe assumes #address-cells and

s/and/are/?

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

> of <base, size> tuples, this means the size of the entire property
> should always be a multiple of 16 bytes (i.e, 4 * sizeof(UINT32),
> not 8. So fix this.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  ArmVirtPkg/FdtClientDxe/FdtClientDxe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c b/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c
> index c336e2410033..2063a597323b 100644
> --- a/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c
> +++ b/ArmVirtPkg/FdtClientDxe/FdtClientDxe.c
> @@ -178,7 +178,7 @@ FindCompatibleNodeReg (
>      return Status;
>    }
>  
> -  if ((*RegSize % 8) != 0) {
> +  if ((*RegSize % 16) != 0) {
>      DEBUG ((EFI_D_ERROR,
>        "%a: '%a' compatible node has invalid 'reg' property (size == 0x%x)\n",
>        __FUNCTION__, CompatibleString, *RegSize));
>