From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web12.1243.1579200892607740282 for ; Thu, 16 Jan 2020 10:54:52 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BtSMN8Sg; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579200891; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GwMfBC5RuDh0f7UX9fsuF74PLXzR2ZQxIj5xscQnMD0=; b=BtSMN8SgDbNIQf+pGk6tphcOQex+MaA+xmRk84p8+l0hsAxnNVzP87Zrw+56gGY5zpZA4y TspiUVAsiSV8fhWlOaOhL5Ilnm4vzST0uFvKY8w8gbIDYmf9j0sQQj18ko03Dho1SupXVW UERO2+OsC1QrQN02A7/BbOu6IDIBSpI= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-37-KYTv67qFNwqYa1Qq-z_R_A-1; Thu, 16 Jan 2020 13:54:48 -0500 Received: by mail-wm1-f70.google.com with SMTP id q206so1498634wme.9 for ; Thu, 16 Jan 2020 10:54:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GwMfBC5RuDh0f7UX9fsuF74PLXzR2ZQxIj5xscQnMD0=; b=lWslwrcoI/uyn9GLepdwfNpPcANFU9WuxP/VppyRAsUxi0vBb2rJK0JPC347uXodeE 186c0N6Gqf+pMxKu77qHzBeJYZlRQCjRTcq6KdlnO3VTpMrezS8Ug33DO0U11VVgKIAx EMqxlh0s3OyyM1CpY01phCwyMazTieFjN/6XfDIBpG0pIwqkZhA6xqsAj1WOLCQctTKB 2cTmyyyQreUa8I+v6HNCSf9ylzOTRraULKciVuyocUw2Gx5FWdMPY1zSCfL9WHeBzZ9i zBLVtngHgmUqGo3kU1fuIiHIEOa5RpIp6g0Zn1PCQSL7AeN9onJ15uKfg7EpmMUj/3wA i/QQ== X-Gm-Message-State: APjAAAU8ZgsAiP4aeZxldtjYNUM8FIfAvTUwx+ww2DfZ4I+ZltPR1KhU sIz6/xGcbZ1iF2ZThUh95aeKJ/g1Iq6dUQiatTbPMYtDn7HT14e0Gv7mE5WATb698YY3q2x2EUo BxQqMNBU3AwmPsg== X-Received: by 2002:a1c:a50e:: with SMTP id o14mr478695wme.2.1579200887655; Thu, 16 Jan 2020 10:54:47 -0800 (PST) X-Google-Smtp-Source: APXvYqynUX9N1vCXqtULUB30I/QwGiTPI5YYWT/SVE6qU09Ho47GmLVp+jq+V+WsZiXJP2kkytcgoA== X-Received: by 2002:a1c:a50e:: with SMTP id o14mr478674wme.2.1579200887430; Thu, 16 Jan 2020 10:54:47 -0800 (PST) Return-Path: Received: from [10.101.1.81] ([176.12.107.132]) by smtp.gmail.com with ESMTPSA id s65sm4379669wmf.48.2020.01.16.10.54.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jan 2020 10:54:46 -0800 (PST) Subject: Re: [PATCH 1/2] Maintainers.txt: update email address for Leif Lindholm To: Laszlo Ersek , Leif Lindholm , devel@edk2.groups.io Cc: Andrew Fish , Ard Biesheuvel , Michael D Kinney , Ray Ni , Zhichao Gao , Leif Lindholm References: <20200114163255.10681-1-leif.lindholm@linaro.org> <20200114163255.10681-2-leif.lindholm@linaro.org> <119a8e77-6472-9be6-b12e-3bfe8e4e83b5@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <9b4c40fe-b15c-2b44-c3f0-70a4b7f1dfc8@redhat.com> Date: Thu, 16 Jan 2020 19:54:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <119a8e77-6472-9be6-b12e-3bfe8e4e83b5@redhat.com> X-MC-Unique: KYTv67qFNwqYa1Qq-z_R_A-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 1/14/20 9:27 PM, Laszlo Ersek wrote: > CC Phil > > On 01/14/20 17:32, Leif Lindholm wrote: >> Leif now works at NUVIA Inc, update email address accordingly. >> >> Cc: Andrew Fish >> Cc: Ard Biesheuvel >> Cc: Laszlo Ersek >> Cc: Michael D Kinney >> Cc: Ray Ni >> Cc: Zhichao Gao >> Cc: Leif Lindholm >> Signed-off-by: Leif Lindholm >> --- >> Maintainers.txt | 14 +++++++------- >> 1 file changed, 7 insertions(+), 7 deletions(-) > > For this patch: > > Reviewed-by: Laszlo Ersek > > Phil, would it make sense for us to ask Leif to post an update to > ".mailmap"? > > For example, what happens if we run "git shortlog" over a period that > contains patches authored by *both* of Leif's email addresses? Would > those entries be merged into a single block? Would such a merging be > desirable (that's for Leif to decide / propose)? One use of .mailmap is to clean/unify the NAME part. In this case Leif isn't affected because his NAME is the same. The other use is to redirect email when a user switch email. When fixing/referring old commit, some email tools might take the old commit author/committer. In this case .mailmap helps. I think it is desirable in Leif particular case. If he agrees the maintainer pushing his patch can amend this snippet: -- >8 -- diff --git a/.mailmap b/.mailmap index ae179b0886c7..bbf3052aa3aa 100644 --- a/.mailmap +++ b/.mailmap @@ -37,6 +37,7 @@ Jim Dailey Jim Dailey Laszlo Ersek Laszlo Ersek +Leif Lindholm Liming Gao Liming Gao Liming Gao --- Note he stays close to you and Liming ;) > > Right now, Leif is not listed in ".mailmap" -- probably because there is > exactly one email address associated with his authorship, all across the > project history. But that's what's changing now, isn't it? > > Thanks, > Laszlo > > > >> diff --git a/Maintainers.txt b/Maintainers.txt >> index 146d8aca93f0..ca9da2892534 100644 >> --- a/Maintainers.txt >> +++ b/Maintainers.txt >> @@ -70,7 +70,7 @@ Tianocore Stewards >> F: * >> M: Andrew Fish >> M: Laszlo Ersek >> -M: Leif Lindholm >> +M: Leif Lindholm >> M: Michael D Kinney >> >> Responsible Disclosure, Reporting Security Issues >> @@ -87,7 +87,7 @@ UEFI Shell Binaries (ShellBinPkg.zip) from EDK II Releases: >> W: https://github.com/tianocore/edk2/releases/ >> M: Ray Ni (Ia32/X64) >> M: Zhichao Gao (Ia32/X64) >> -M: Leif Lindholm (ARM/AArch64) >> +M: Leif Lindholm (ARM/AArch64) >> M: Ard Biesheuvel (ARM/AArch64) >> >> EDK II Architectures: >> @@ -95,7 +95,7 @@ EDK II Architectures: >> ARM, AARCH64 >> F: */AArch64/ >> F: */Arm/ >> -M: Leif Lindholm >> +M: Leif Lindholm >> M: Ard Biesheuvel >> >> EDK II Continuous Integration: >> @@ -126,13 +126,13 @@ EDK II Packages: >> ArmPkg >> F: ArmPkg/ >> W: https://github.com/tianocore/tianocore.github.io/wiki/ArmPkg >> -M: Leif Lindholm >> +M: Leif Lindholm >> M: Ard Biesheuvel >> >> ArmPlatformPkg >> F: ArmPlatformPkg/ >> W: https://github.com/tianocore/tianocore.github.io/wiki/ArmPlatformPkg >> -M: Leif Lindholm >> +M: Leif Lindholm >> M: Ard Biesheuvel >> >> ArmVirtPkg >> @@ -140,7 +140,7 @@ F: ArmVirtPkg/ >> W: https://github.com/tianocore/tianocore.github.io/wiki/ArmVirtPkg >> M: Laszlo Ersek >> M: Ard Biesheuvel >> -R: Leif Lindholm >> +R: Leif Lindholm >> >> ArmVirtPkg: modules used on Xen >> F: ArmVirtPkg/ArmVirtXen.* >> @@ -173,7 +173,7 @@ M: Alexei Fedorov >> EmbeddedPkg >> F: EmbeddedPkg/ >> W: https://github.com/tianocore/tianocore.github.io/wiki/EmbeddedPkg >> -M: Leif Lindholm >> +M: Leif Lindholm >> M: Ard Biesheuvel >> >> EmulatorPkg >> >