From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by mx.groups.io with SMTP id smtpd.web12.21212.1639449725702007595 for ; Mon, 13 Dec 2021 18:42:05 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=VpwKmlw7; spf=pass (domain: nuviainc.com, ip: 209.85.210.175, mailfrom: rebecca@nuviainc.com) Received: by mail-pf1-f175.google.com with SMTP id x5so16711543pfr.0 for ; Mon, 13 Dec 2021 18:42:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=jZh3gz8A8WsgHFVt7C67ZBHw3uV8tyseLhztTaef41Q=; b=VpwKmlw7Hv4jnYJ3Ae1NECFn4q6/XV5oflrMDp1OoQUYe3ILxbjhL5CUox4X8QCrlI r9x9yUw2qt3zwoLadQ9SgZmlOHIullfU3jdAi6WVBjC9bF3eviWY2aKiOEqdyBbW6Pho R2iHhraWGH79qBaTzPDXQS7UpWZBXFI25IQKNATqPauikr1DD5jionSbFKyvFS70ECRj GDAUBu1eCtw1t0ANFs/Z1DKEnyAUeCjM2BHEDYQ9lzF7X+Zws6qC0spbHILmyyFOWAWj 9nrpCbLKA/kNFrliiCfAK1hz10fIjBss1vnfeiWiUyudhz0/iKrptesInenr21FVzx9W SF/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=jZh3gz8A8WsgHFVt7C67ZBHw3uV8tyseLhztTaef41Q=; b=OthgGLKND11HlKKH0bgZnTDjJkG4wh61kXKQEoy0e6LLrQm4CzYtvpTFsWyGyBZqnJ YblvHveRIsi60AgNkORJBxXMXsJb8a/RFIy1yUZxg0wZLQAFoswylPw7b/Clm0A4MAZ0 l6KkBnKqoSZPEctio+qXVD8lG7PeNQ14mf308b/PoRDcvQtSXBYOOQfFdlW7JmBgT6fL RjQHhoZq8KxOm/zLWFbpgRUX4Tcm2yHRNMa+khxsGxbL3tT7CRQjtJz7VxlOt3btzB/r ElkZK9QaiJOGbGshSHPWh+vWi88xr1/AXXs4VDULLBULyS+mn4dtFkhwVPqVXEL2kaDw htgA== X-Gm-Message-State: AOAM533rtEGwajASG/458XVOOLkyW/rAznmYiFkuzBoyupXRA1MhP3wT Pr8E2lQSuYtjg/15g+Tn4MepmA== X-Google-Smtp-Source: ABdhPJyP5nt62X1txxqd4Y311HRjYu8UkJuBfhkZRx2cTq8gRAYvS5j9KKKnz5IQ8jmNZweIUW+1eg== X-Received: by 2002:a63:6907:: with SMTP id e7mr1760233pgc.481.1639449725210; Mon, 13 Dec 2021 18:42:05 -0800 (PST) Return-Path: Received: from ?IPv6:2601:681:4300:69e:9e7b:efff:fe2b:884c? ([2601:681:4300:69e:9e7b:efff:fe2b:884c]) by smtp.gmail.com with ESMTPSA id kk7sm450968pjb.19.2021.12.13.18.42.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Dec 2021 18:42:04 -0800 (PST) Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VmgExitLib: Fix uninitialized variable warning To: devel@edk2.groups.io, jiewen.yao@intel.com, Brijesh Singh Cc: James Bottomley , "Xu, Min M" , Tom Lendacky , "Justen, Jordan L" , Ard Biesheuvel , "Aktas, Erdem" , Michael Roth , Gerd Hoffmann , Rebecca Cran References: <20211213193839.143953-1-brijesh.singh@amd.com> <16C07D237B4BFD37.18377@groups.io> From: "Rebecca Cran" Message-ID: <9bb6e396-5cb2-b143-c526-7ac642dde2d4@nuviainc.com> Date: Mon, 13 Dec 2021 19:41:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/alternative; boundary="------------44578FCF7409108750B043A8" Content-Language: en-US --------------44578FCF7409108750B043A8 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit The error is: ERROR - /home/vsts/work/1/s/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c ERROR - --->Test Failed: Uncrustify Coding Standard Test NO-TARGET returned 1 From what I can see, there's no report of the actual error here, so you have to setup Uncrustify locally to see what changes it wants to make. For instructions on setting up Uncrustify, see https://github.com/makubacki/tianocore.github.io/blob/add_uncrustify_instructions/EDK-II-Code-Formatting.md . Given the change, I expect the indentation of the equals sign is wrong. -- Rebecca Cran On 12/13/21 7:34 PM, Yao, Jiewen wrote: > Hey Brijesh > > CI fails - https://github.com/tianocore/edk2/pull/2301 > Would you please take a look? > > Please remember to submit patch after you run CI next time. > >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of Yao, Jiewen >> Sent: Tuesday, December 14, 2021 10:11 AM >> To: Brijesh Singh ; devel@edk2.groups.io >> Cc: James Bottomley ; Xu, Min M ; >> Tom Lendacky ; Justen, Jordan L >> ; Ard Biesheuvel ; >> Aktas, Erdem ; Michael Roth >> ; Gerd Hoffmann ; Rebecca >> Cran >> Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VmgExitLib: Fix uninitialized >> variable warning >> >> Reviewed-by: Jiewen Yao >> >>> -----Original Message----- >>> From: Brijesh Singh >>> Sent: Tuesday, December 14, 2021 3:39 AM >>> To: devel@edk2.groups.io >>> Cc: James Bottomley ; Xu, Min M >> ; >>> Yao, Jiewen ; Tom Lendacky >>> ; Justen, Jordan L ; >>> Ard Biesheuvel ; Aktas, Erdem >>> ; Michael Roth ; Gerd >>> Hoffmann ; Brijesh Singh ; >>> Rebecca Cran >>> Subject: [PATCH 1/1] OvmfPkg/VmgExitLib: Fix uninitialized variable warning >>> >>> The XCODE5 reported the below warning >>> >>> OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c:1895:12: note: uninitialized >>> use occurs here >>> Compacted >>> ^^^^^^^^^ >>> >>> Initialize the 'Compacted' variable to fix the warning. >>> >>> Fixes: d2b998fbdca4 (OvmfPkg/VmgExitLib: use SEV-SNP-validated CPUID >> values) >>> Cc: James Bottomley >>> Cc: Min Xu >>> Cc: Jiewen Yao >>> Cc: Tom Lendacky >>> Cc: Jordan Justen >>> Cc: Ard Biesheuvel >>> Cc: Erdem Aktas >>> Cc: Gerd Hoffmann >>> Cc: Rebecca Cran >>> Cc: Michael Roth >>> Signed-off-by: Brijesh Singh >>> --- >>> OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c >>> b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c >>> index a40a31f7c275..ff367411cc59 100644 >>> --- a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c >>> +++ b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c >>> @@ -1872,6 +1872,7 @@ GetCpuidFw ( >>> UINT32 XSaveSize; >>> >>> XssMsr.Uint64 = 0; >>> + Compacted = FALSE; >>> if (EcxIn == 1) { >>> /* >>> * The PPR and APM aren't clear on what size should be encoded in >>> -- >>> 2.25.1 >> >> >> >> > > > > > --------------44578FCF7409108750B043A8 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit

The error is:

ERROR - /home/vsts/work/1/s/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c

ERROR - --->Test Failed: Uncrustify Coding Standard Test NO-TARGET returned 1


From what I can see, there's no report of the actual error here, so you have to setup Uncrustify locally to see what changes it wants to make.

For instructions on setting up Uncrustify, see https://github.com/makubacki/tianocore.github.io/blob/add_uncrustify_instructions/EDK-II-Code-Formatting.md .


Given the change, I expect the indentation of the equals sign is wrong.


--
Rebecca Cran


On 12/13/21 7:34 PM, Yao, Jiewen wrote:
Hey Brijesh

CI fails - https://github.com/tianocore/edk2/pull/2301
Would you please take a look?

Please remember to submit patch after you run CI next time.


-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao, Jiewen
Sent: Tuesday, December 14, 2021 10:11 AM
To: Brijesh Singh <brijesh.singh@amd.com>; devel@edk2.groups.io
Cc: James Bottomley <jejb@linux.ibm.com>; Xu, Min M <min.m.xu@intel.com>;
Tom Lendacky <thomas.lendacky@amd.com>; Justen, Jordan L
<jordan.l.justen@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>;
Aktas, Erdem <erdemaktas@google.com>; Michael Roth
<Michael.Roth@amd.com>; Gerd Hoffmann <kraxel@redhat.com>; Rebecca
Cran <rebecca@bsdio.com>
Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VmgExitLib: Fix uninitialized
variable warning

Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>


-----Original Message-----
From: Brijesh Singh <brijesh.singh@amd.com>
Sent: Tuesday, December 14, 2021 3:39 AM
To: devel@edk2.groups.io
Cc: James Bottomley <jejb@linux.ibm.com>; Xu, Min M

<min.m.xu@intel.com>;

Yao, Jiewen <jiewen.yao@intel.com>; Tom Lendacky
<thomas.lendacky@amd.com>; Justen, Jordan L <jordan.l.justen@intel.com>;
Ard Biesheuvel <ardb+tianocore@kernel.org>; Aktas, Erdem
<erdemaktas@google.com>; Michael Roth <Michael.Roth@amd.com>; Gerd
Hoffmann <kraxel@redhat.com>; Brijesh Singh <brijesh.singh@amd.com>;
Rebecca Cran <rebecca@bsdio.com>
Subject: [PATCH 1/1] OvmfPkg/VmgExitLib: Fix uninitialized variable warning

The XCODE5 reported the below warning

OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c:1895:12: note: uninitialized
use occurs here
           Compacted
           ^^^^^^^^^

Initialize the 'Compacted' variable to fix the warning.

Fixes: d2b998fbdca4 (OvmfPkg/VmgExitLib: use SEV-SNP-validated CPUID

values)

Cc: James Bottomley <jejb@linux.ibm.com>
Cc: Min Xu <min.m.xu@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Erdem Aktas <erdemaktas@google.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Michael Roth <Michael.Roth@amd.com>
Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
---
 OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
index a40a31f7c275..ff367411cc59 100644
--- a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
+++ b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
@@ -1872,6 +1872,7 @@ GetCpuidFw (
     UINT32                 XSaveSize;

     XssMsr.Uint64 = 0;
+    Compacted = FALSE;
     if (EcxIn == 1) {
       /*
        * The PPR and APM aren't clear on what size should be encoded in
--
2.25.1
--------------44578FCF7409108750B043A8--