From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbonzini@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=209.132.183.28; helo=mx1.redhat.com;
 envelope-from=pbonzini@redhat.com; receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 8F374202E618C
 for <edk2-devel@lists.01.org>; Tue, 17 Oct 2017 07:33:38 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com
 [10.5.11.11])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 47104C0587FE;
 Tue, 17 Oct 2017 14:37:14 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 47104C0587FE
Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com;
 dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com;
 spf=fail smtp.mailfrom=pbonzini@redhat.com
Received: from [10.36.117.51] (ovpn-117-51.ams2.redhat.com [10.36.117.51])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id D7C4464448;
 Tue, 17 Oct 2017 14:37:10 +0000 (UTC)
To: Laszlo Ersek <lersek@redhat.com>, "Duran, Leo" <leo.duran@amd.com>,
 "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
 Jiewen Yao <jiewen.yao@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>,
 Michael D Kinney <michael.d.kinney@intel.com>,
 Jordan Justen <jordan.l.justen@intel.com>, Liming Gao <liming.gao@intel.com>
References: <1507751131-32404-1-git-send-email-leo.duran@amd.com>
 <1507751131-32404-2-git-send-email-leo.duran@amd.com>
 <DM5PR12MB1243EBBB8ADA0B5C34C4DE2BF94C0@DM5PR12MB1243.namprd12.prod.outlook.com>
 <e1945384-c8bb-2206-d87d-f458fc21d85e@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <9bda521d-a160-77e1-66e5-4647ad7f02d5@redhat.com>
Date: Tue, 17 Oct 2017 16:37:07 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <e1945384-c8bb-2206-d87d-f458fc21d85e@redhat.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.32]); Tue, 17 Oct 2017 14:37:14 +0000 (UTC)
Subject: Re: [PATCH v5 1/2] UefiCpuPkg/SmmCpuFeaturesLib: Use global variables to replace macros
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Oct 2017 14:33:38 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 17/10/2017 16:23, Laszlo Ersek wrote:
>> For the SRAM_SAVE_STATE_MAP_OFFSET:
>> I propose returning the value by a function in SmmCpuFeaturesLib...
> This has crossed my mind (superficially :) ), and I support your idea.
> 
> Paolo, can you please comment?

I don't see a reason why AMD must use a state save map that only covers
the last 512 bytes rather than the whole 1024, even if the first half is
unused...

Paolo