public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Mohammad Younas Khan Pathan <pmdyounaskhan786@gmail.com>
Cc: edk2-devel@lists.01.org
Subject: Re: Bug 843 - Need to remove unnecessary return statements in void functions of EDKII.
Date: Mon, 11 Jun 2018 11:56:26 +0200	[thread overview]
Message-ID: <9be90c97-cac6-429c-d7c2-38d0eb4a3b97@redhat.com> (raw)
In-Reply-To: <50c9dbcc-83b2-57ef-f32f-5cb0fbe166f8@redhat.com>

On 06/11/18 11:47, Laszlo Ersek wrote:
> On 06/11/18 09:17, Mohammad Younas Khan Pathan wrote:

> (4) Please split the patch to one patch per top-level directory. For
> example, you should have a separate patch for OvmfPkg.

This is required by our development workflow, but it's also required for
technical reasons. I'm just noticing that your posting (with message ID
<CAN9uzB=UhGhveKK4=F=jiwUmc_5QO+pmROvqcjiuBQtbHjyjRg@mail.gmail.com>)
hasn't even reached the list, and that's because the email was oversized
-- 855190 bytes. That's way beyond the limit.

If you split the changes with the right granularity, this won't be a
problem.

Thanks
Laszlo


      reply	other threads:[~2018-06-11  9:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-06  8:28 Bug 843 - Need to remove unnecessary return statements in void functions of EDKII Mohammad Younas Khan Pathan
2018-06-06 20:12 ` Laszlo Ersek
     [not found]   ` <CAN9uzB=UhGhveKK4=F=jiwUmc_5QO+pmROvqcjiuBQtbHjyjRg@mail.gmail.com>
2018-06-11  9:47     ` Laszlo Ersek
2018-06-11  9:56       ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9be90c97-cac6-429c-d7c2-38d0eb4a3b97@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox