From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 4655F21198CDD
 for <edk2-devel@lists.01.org>; Mon, 11 Jun 2018 02:56:28 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com
 [10.11.54.5])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 9619A40BC052;
 Mon, 11 Jun 2018 09:56:27 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-125.rdu2.redhat.com
 [10.10.120.125])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 279B583B86;
 Mon, 11 Jun 2018 09:56:27 +0000 (UTC)
From: Laszlo Ersek <lersek@redhat.com>
To: Mohammad Younas Khan Pathan <pmdyounaskhan786@gmail.com>
Cc: edk2-devel@lists.01.org
References: <CAN9uzBn73V6DZ49Ha+r0KwK+1U6MtZaQrN+ccBAa_RHrh0fsHw@mail.gmail.com>
 <bfb3e278-8504-18ea-8d49-bef9217b2816@redhat.com>
 <CAN9uzB=UhGhveKK4=F=jiwUmc_5QO+pmROvqcjiuBQtbHjyjRg@mail.gmail.com>
 <50c9dbcc-83b2-57ef-f32f-5cb0fbe166f8@redhat.com>
Message-ID: <9be90c97-cac6-429c-d7c2-38d0eb4a3b97@redhat.com>
Date: Mon, 11 Jun 2018 11:56:26 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <50c9dbcc-83b2-57ef-f32f-5cb0fbe166f8@redhat.com>
X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.11.55.7]); Mon, 11 Jun 2018 09:56:27 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]);
 Mon, 11 Jun 2018 09:56:27 +0000 (UTC) for IP:'10.11.54.5'
 DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com'
 HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:''
Subject: Re: Bug 843 - Need to remove unnecessary return statements in void functions of EDKII.
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jun 2018 09:56:28 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 06/11/18 11:47, Laszlo Ersek wrote:
> On 06/11/18 09:17, Mohammad Younas Khan Pathan wrote:

> (4) Please split the patch to one patch per top-level directory. For
> example, you should have a separate patch for OvmfPkg.

This is required by our development workflow, but it's also required for
technical reasons. I'm just noticing that your posting (with message ID
<CAN9uzB=UhGhveKK4=F=jiwUmc_5QO+pmROvqcjiuBQtbHjyjRg@mail.gmail.com>)
hasn't even reached the list, and that's because the email was oversized
-- 855190 bytes. That's way beyond the limit.

If you split the changes with the right granularity, this won't be a
problem.

Thanks
Laszlo