From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 35CAD74003A for ; Wed, 6 Mar 2024 18:20:28 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Z4ynYtwMTKKTUWG2lTEnI6or7cMigKBAABnEczIq0K0=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:From:To:Cc:Reply-To:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1709749226; v=1; b=sKtXoBV4R1smcvsyI8nSz7uiAgJsIFQh1yIwZwrsEnRXMZY/PGoOBm195Ij3SEFibehLZ96A Lp7CbQtVC2aFhHed/9m+NFkCpof1EMyBjqwhjBR7oLbyj23M6SNYIf7+jH1mHOxSaHr6U2NZdcC 84favIDpKpn5VQyxAgOd9GKSq52rwROIibfGKHm/5zzU3FwX1QOv/WkSk8XRYnTiGpQJL3M8qW5 bLKTdSQuTgP5ucBmbjcpuUhny9cKZytvqoLVMH1LxlkaMcVN1i8D5L9Sa0ro8HrAWiyDmyC+dmp dgHAPkIAj7HxQy2bDdxquoiq9LbbMc9yRZfqEvqWFTEUw== X-Received: by 127.0.0.2 with SMTP id 48hZYY7687511xFCdqcf1hag; Wed, 06 Mar 2024 10:20:26 -0800 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.1265.1709749226298632659 for ; Wed, 06 Mar 2024 10:20:26 -0800 X-Received: from [10.137.194.171] (unknown [131.107.160.171]) by linux.microsoft.com (Postfix) with ESMTPSA id CA77220B74C0; Wed, 6 Mar 2024 10:20:25 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com CA77220B74C0 Message-ID: <9c091218-ceff-443b-9116-14c75b5782b7@linux.microsoft.com> Date: Wed, 06 Mar 2024 10:20:26 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel][PATCH v2 0/3] Fix Runtime Granularity Issues From: "Oliver Smith-Denny" To: devel@edk2.groups.io, Liming Gao Cc: Leif Lindholm , Ard Biesheuvel , Sami Mujawar Reply-To: devel@edk2.groups.io,osde@linux.microsoft.com References: <17B4822428B54117.28679@groups.io> <17B77781EF7C2ED3.24693@groups.io> In-Reply-To: <17B77781EF7C2ED3.24693@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: F5etSm8rGXEB4xtXcrPm9cSCx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=sKtXoBV4; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Liming, Friendly ping again, can you please review this? It fixes a UEFI spec violation. Thanks, Oliver On 2/26/2024 8:46 AM, Oliver Smith-Denny wrote: > Hi Liming, >=20 > Now that the stable tag is finished, can you review this MdeModulePkg=20 > patch? >=20 > Thanks, > Oliver >=20 > On 2/16/2024 5:27 PM, Oliver Smith-Denny wrote: >> This patch series is the second version of >> MdeModulePkg: DxeCore: Don't Guard Large Runtime Granularity=20 >> Allocations=E2=80=8B. >> The subject line has been updated because this went from a one commit >> patch with no cover letter to a multi-commit patch. >> >> The commit messages cover the vast amount of detail here, but this >> patchset fixes three issues: >> - a UEFI spec violation for which memory types require runtime page >> allocation granularity alignment >> - An incompatibility of the heap guard system to guard these regions >> that require runtime page allocation granularities greater than >> the EFI_PAGE_SIZE. >> - A CodeQL error that fails CI when updating the Page.c code >> >> v2: >> - Add commit to fix UEFI spec violation >> - Add commit to fix newly flagged CodeQL error >> - Update guard commit message, comments, and static assert to use >> the correct types >> >> Cc: Leif Lindholm >> Cc: Ard Biesheuvel >> Cc: Sami Mujawar >> Cc: Liming Gao >> >> Oliver Smith-Denny (3): >> =C2=A0=C2=A0 MdeModulePkg: DxeCore: Fix CodeQL Error in FreePages >> =C2=A0=C2=A0 MdeModulePkg: DxeCore: Correct Runtime Granularity Memory T= ype >> =C2=A0=C2=A0 MdeModulePkg: DxeCore: Do Not Apply Guards to Unsupported T= ypes >> >> =C2=A0 MdeModulePkg/MdeModulePkg.dec=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 10 +++++++++ >> =C2=A0 MdeModulePkg/Core/Dxe/Mem/HeapGuard.h=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 | 14 +++++++++++++ >> =C2=A0 MdeModulePkg/Core/Dxe/Mem/Page.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 22 +++++++++++++++++--- >> =C2=A0 MdeModulePkg/Core/Dxe/Mem/Pool.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 15 +++++++++++-- >> =C2=A0 MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c |=C2=A0 4 ++-- >> =C2=A0 MdeModulePkg/Core/Pei/Memory/MemoryServices.c |=C2=A0 2 +- >> =C2=A0 6 files changed, 59 insertions(+), 8 deletions(-) >> >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116452): https://edk2.groups.io/g/devel/message/116452 Mute This Topic: https://groups.io/mt/104405577/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-