From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web10.114022.1597938959062638841 for ; Thu, 20 Aug 2020 08:55:59 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: linux.intel.com, ip: 192.55.52.120, mailfrom: maciej.rabeda@linux.intel.com) IronPort-SDR: BuaZLD3Z2jff9svRm3wQ3XXK1OdKMN7zORf76g53qacxnFIZQ+TcFHxfpp/DUdYPTirs65WppE y4sHDXJDr/UQ== X-IronPort-AV: E=McAfee;i="6000,8403,9718"; a="152744223" X-IronPort-AV: E=Sophos;i="5.76,333,1592895600"; d="scan'208,217";a="152744223" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2020 08:55:57 -0700 IronPort-SDR: NSFOhHb1IsfDmwY4MCmLUEQy/J4mcfs8Pl6vM82Ihj7st8qUfV9hEIf9pgUWcv38Ml19GfbuDP NqJCwhDZBD+g== X-IronPort-AV: E=Sophos;i="5.76,333,1592895600"; d="scan'208,217";a="472702152" Received: from mrabeda-mobl.ger.corp.intel.com (HELO [10.249.158.232]) ([10.249.158.232]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Aug 2020 08:55:55 -0700 Subject: Re: [edk2-devel] [Patch ] IP is getting Configured when IP Configuration is disabled To: devel@edk2.groups.io, sivaramann@amiindia.co.in, "jiaxin.wu@intel.com" Cc: "liming.gao@intel.com" References: <162AC138777CB9A5.16363@groups.io> From: "Maciej Rabeda" Message-ID: <9c2f698b-1fbf-555b-ed2d-47c5dbcfd2ec@linux.intel.com> Date: Thu, 20 Aug 2020 17:55:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/alternative; boundary="------------2E9831FAE6E9CBD933E0C91F" Content-Language: pl --------------2E9831FAE6E9CBD933E0C91F Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Hi Siva, If you want to propose a patch for review, please follow the process: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers I do not think my git will be able to process your email. Thanks, Maciej On 20-Aug-20 17:16, Sivaraman Nainar wrote: > > Jiaxin: > > Did you get chance to review the patch? > > -Siva > > *From:* devel@edk2.groups.io [mailto:devel@edk2.groups.io] *On Behalf > Of *Sivaraman Nainar > *Sent:* Thursday, August 13, 2020 12:21 PM > *To:* devel@edk2.groups.io > *Cc:* liming.gao@intel.com; jiaxin.wu@intel.com > *Subject:* [edk2-devel] [Patch ] IP is getting Configured when IP > Configuration is disabled > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2873 > > > *** E:\Work\NWStack\EDK2Tickets\IPConfigFix\Mod\Ip4Config2Impl.c > 2020-08-04 18:38:06.000000000 +05-30 > > --- E:\Work\NWStack\EDK2Tickets\IPConfigFix\Org\Ip4Config2Impl.c > 2020-05-07 22:54:46.000000000 +05-30 > > *************** > > *** 1965,1978 **** > >     IP4_CONFIG2_INSTANCE  *TmpInstance; > >     LIST_ENTRY            *Entry; > >     EFI_STATUS            Status; > >     UINTN                 Index; > >     UINT16                IfIndex; > >     IP4_CONFIG2_DATA_ITEM *DataItem; > > !   BOOLEAN IPConfigEnabled = FALSE; > > !   IP4_CONFIG2_IFR_NVDATA *IfrFromNvData = NULL; > >     IpSb = IP4_SERVICE_FROM_IP4_CONFIG2_INSTANCE (Instance); > >     Instance->Signature = IP4_CONFIG2_INSTANCE_SIGNATURE; > > --- 1965,1977 ---- > >     IP4_CONFIG2_INSTANCE  *TmpInstance; > >     LIST_ENTRY            *Entry; > >     EFI_STATUS            Status; > >     UINTN                 Index; > >     UINT16                IfIndex; > >     IP4_CONFIG2_DATA_ITEM *DataItem; > > ! > >     IpSb = IP4_SERVICE_FROM_IP4_CONFIG2_INSTANCE (Instance); > >     Instance->Signature = IP4_CONFIG2_INSTANCE_SIGNATURE; > > *************** > > *** 2038,2063 **** > >     // > >     // Try to read the config data from NV variable. > >     // If not found, write initialized config data into NV variable > >     // as a default config data. > >     // > > !     Status = GetVariable2(IpSb->MacString, &gIp4Config2NvDataGuid, > (VOID**)&IfrFromNvData, NULL); > > !     if(!EFI_ERROR(Status)){ > > !         if (IfrFromNvData->Configure == TRUE) { > > !             Status = Ip4Config2ReadConfigData (IpSb->MacString, > Instance); > > !             if (Status == EFI_NOT_FOUND) { > > !                 Status = Ip4Config2WriteConfigData (IpSb->MacString, > Instance); > > !             } > > !             IPConfigEnabled = TRUE; > > !         } > > !         FreePool(IfrFromNvData); > > !     } > > !     if(!IPConfigEnabled){ > > !         Status = Ip4Config2WriteConfigData (IpSb->MacString, Instance); > > !     } > >     if (EFI_ERROR (Status)) { > >       return Status; > >     } > >     Instance->Ip4Config2.SetData = EfiIp4Config2SetData; > > --- 2037,2052 ---- > >     // > >     // Try to read the config data from NV variable. > >     // If not found, write initialized config data into NV variable > >     // as a default config data. > >     // > > !   Status = Ip4Config2ReadConfigData (IpSb->MacString, Instance); > > !   if (Status == EFI_NOT_FOUND) { > > !     Status = Ip4Config2WriteConfigData (IpSb->MacString, Instance); > > !   } > >     if (EFI_ERROR (Status)) { > >       return Status; > >     } > >     Instance->Ip4Config2.SetData = EfiIp4Config2SetData; > > This e-mail is intended for the use of the addressee only and may > contain privileged, confidential, or proprietary information that is > exempt from disclosure under law. If you have received this message in > error, please inform us promptly by reply e-mail, then delete the > e-mail and destroy any printed copy. Thank you. > > --------------2E9831FAE6E9CBD933E0C91F Content-Type: text/html; charset=windows-1252 Content-Transfer-Encoding: 8bit Hi Siva,

If you want to propose a patch for review, please follow the process:
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers

I do not think my git will be able to process your email.

Thanks,
Maciej

On 20-Aug-20 17:16, Sivaraman Nainar wrote:

Jiaxin:

 

Did you get chance to review the patch?

 

-Siva

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Sivaraman Nainar
Sent: Thursday, August 13, 2020 12:21 PM
To: devel@edk2.groups.io
Cc: liming.gao@intel.com; jiaxin.wu@intel.com
Subject: [edk2-devel] [Patch ] IP is getting Configured when IP Configuration is disabled

 

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2873

 

*** E:\Work\NWStack\EDK2Tickets\IPConfigFix\Mod\Ip4Config2Impl.c               2020-08-04 18:38:06.000000000 +05-30

--- E:\Work\NWStack\EDK2Tickets\IPConfigFix\Org\Ip4Config2Impl.c     2020-05-07 22:54:46.000000000 +05-30

***************

*** 1965,1978 ****

    IP4_CONFIG2_INSTANCE  *TmpInstance;

    LIST_ENTRY            *Entry;

    EFI_STATUS            Status;

    UINTN                 Index;

    UINT16                IfIndex;

    IP4_CONFIG2_DATA_ITEM *DataItem;

!   BOOLEAN                                                       IPConfigEnabled = FALSE;

!   IP4_CONFIG2_IFR_NVDATA  *IfrFromNvData = NULL;

 

    IpSb = IP4_SERVICE_FROM_IP4_CONFIG2_INSTANCE (Instance);

 

    Instance->Signature = IP4_CONFIG2_INSTANCE_SIGNATURE;

 

  

--- 1965,1977 ----

    IP4_CONFIG2_INSTANCE  *TmpInstance;

    LIST_ENTRY            *Entry;

    EFI_STATUS            Status;

    UINTN                 Index;

    UINT16                IfIndex;

    IP4_CONFIG2_DATA_ITEM *DataItem;

!

  

    IpSb = IP4_SERVICE_FROM_IP4_CONFIG2_INSTANCE (Instance);

 

    Instance->Signature = IP4_CONFIG2_INSTANCE_SIGNATURE;

 

  

***************

*** 2038,2063 ****

 

    //

    // Try to read the config data from NV variable.

    // If not found, write initialized config data into NV variable

    // as a default config data.

    //

!     Status = GetVariable2(IpSb->MacString, &gIp4Config2NvDataGuid, (VOID**)&IfrFromNvData, NULL);

!     if(!EFI_ERROR(Status)){

!         if (IfrFromNvData->Configure == TRUE) {

!             Status = Ip4Config2ReadConfigData (IpSb->MacString, Instance);

!             if (Status == EFI_NOT_FOUND) {

!                 Status = Ip4Config2WriteConfigData (IpSb->MacString, Instance);

!             }

!             IPConfigEnabled = TRUE;

!         }

!         FreePool(IfrFromNvData);

!     }

!     if(!IPConfigEnabled){

!         Status = Ip4Config2WriteConfigData (IpSb->MacString, Instance);

!     }

 

    if (EFI_ERROR (Status)) {

      return Status;

    }

 

    Instance->Ip4Config2.SetData              = EfiIp4Config2SetData;

--- 2037,2052 ----

 

    //

    // Try to read the config data from NV variable.

    // If not found, write initialized config data into NV variable

    // as a default config data.

    //

!   Status = Ip4Config2ReadConfigData (IpSb->MacString, Instance);

!   if (Status == EFI_NOT_FOUND) {

!     Status = Ip4Config2WriteConfigData (IpSb->MacString, Instance);

!   }

 

    if (EFI_ERROR (Status)) {

      return Status;

    }

 

    Instance->Ip4Config2.SetData              = EfiIp4Config2SetData;

This e-mail is intended for the use of the addressee only and may contain privileged, confidential, or proprietary information that is exempt from disclosure under law. If you have received this message in error, please inform us promptly by reply e-mail, then delete the e-mail and destroy any printed copy. Thank you.


--------------2E9831FAE6E9CBD933E0C91F--