From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web10.6454.1606309932752870306
 for <devel@edk2.groups.io>;
 Wed, 25 Nov 2020 05:12:12 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6E24F31B;
	Wed, 25 Nov 2020 05:12:12 -0800 (PST)
Received: from [192.168.1.81] (unknown [10.37.8.72])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0DECA3F70D;
	Wed, 25 Nov 2020 05:12:09 -0800 (PST)
Subject: Re: [PATCH edk2-platforms 00/15] arm platform fixes triggered by VariablePolicy
To: Leif Lindholm <leif@nuviainc.com>, devel@edk2.groups.io
Cc: Abner Chang <abner.chang@hpe.com>, Bret Barkelew
 <brbarkel@microsoft.com>, Daniel Schaefer <daniel.schaefer@hpe.com>,
 Graeme Gregory <graeme@nuviainc.com>, Marcin Wojtas <mw@semihalf.com>,
 Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>,
 Ming Huang <huangming23@huawei.com>, Radoslaw Biernacki <rad@semihalf.com>,
 Tanmay Jagdale <tanmay.jagdale@linaro.org>,
 Thomas Abraham <thomas.abraham@arm.com>
References: <20201125125559.11631-1-leif@nuviainc.com>
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
Message-ID: <9c3e8a0c-a250-93e9-a7f8-1175579f839a@arm.com>
Date: Wed, 25 Nov 2020 14:12:08 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20201125125559.11631-1-leif@nuviainc.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 11/25/20 1:55 PM, Leif Lindholm wrote:
> The recently merged VariablePolicy set in edk2,
> d448574e7310..124b3f9289f1, broke everything[tm].
> Fix up the ARM platforms I have any sort of history about,
> including some unrelated things that popped up along the way.
> 

Thanks for fixing this mess.

For the patches I did not reply to individually,

Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>


> Note: the hisilicon server platforms still don't build due to use
> of now deleted (previously deprecated) string functions in
> the SMBIOS code. Rebecca Cran has been sending out a genericised
> set *based* on this code, but now fixed. If Hisilicon could look
> into making use of that version instead, that might be less hassle
> than fixing the current implementation:
> https://edk2.groups.io/g/devel/message/67255
> 
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Bret Barkelew <brbarkel@microsoft.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Cc: Graeme Gregory <graeme@nuviainc.com>
> Cc: Marcin Wojtas <mw@semihalf.com>
> Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> Cc: Ming Huang <huangming23@huawei.com>
> Cc: Radoslaw Biernacki <rad@semihalf.com>
> Cc: Tanmay Jagdale <tanmay.jagdale@linaro.org>
> Cc: Thomas Abraham <thomas.abraham@arm.com>
> 
> Leif Lindholm (15):
>    Silicon/AMD: update Styx to use PcdSet*S APIs
>    Platform/AMD: add RngLib for Overdriveboard
>    Platform,Silicon: fix beagleboard tautological compares
>    Silicon/Hisilicon: add RngLib for Hisilicon
>    Platform/ARM: VExpressPkg fixes to work with new VariablePolicyLib
>    Platform/AMD: add VariablePolicy library resolutions for Overdrive
>    Platform/SoftIron: add VariablePolicy resolutions for Overdrive1000
>    Platform/LeMaker: add VariablePolicy resolutions for cello
>    Platform/SiFive: add VariablePolicy resolutions
>    Platform/Qemu: add VariablePolicy resolutions
>    Silicon/Marvell: add VariablePolicy resolutions
>    Platform/BeagleBoard: add VariablePolicy resolutions
>    Silicon/NXP: add VariablePolicy resolutions
>    Platform/SocioNext: add VariablePolicy resolutions
>    Silicon/Hisilicon: add VariablePolicy resolutions
> 
>   Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc  |  1 +
>   Silicon/Hisilicon/Hisilicon.dsc.inc           |  4 ++++
>   Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc |  5 ++++-
>   Silicon/NXP/NxpQoriqLs.dsc.inc                |  4 ++++
>   .../AMD/OverdriveBoard/OverdriveBoard.dsc     |  4 ++++
>   .../BeagleBoardPkg/BeagleBoardPkg.dsc         |  4 ++++
>   Platform/LeMaker/CelloBoard/CelloBoard.dsc    |  4 ++++
>   Platform/Qemu/SbsaQemu/SbsaQemu.dsc           |  3 +++
>   .../FreedomU500VC707Board/U500.dsc            |  4 ++++
>   .../FreedomU540HiFiveUnleashedBoard/U540.dsc  |  4 ++++
>   .../Socionext/DeveloperBox/DeveloperBox.dsc   |  3 +++
>   .../Overdrive1000Board/Overdrive1000Board.dsc |  4 ++++
>   .../Library/ResetSystemLib/ResetSystemLib.c   |  2 +-
>   .../Styx/Drivers/PlatInitPei/PlatInitPei.c    | 11 ++++++----
>   .../Library/MemoryInitPei/MemoryInitPeiLib.c  | 20 +++++++++++--------
>   .../Omap35xxPkg/SmbusDxe/Smbus.c              |  2 +-
>   16 files changed, 64 insertions(+), 15 deletions(-)
>