From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Tue, 24 Sep 2019 16:43:05 -0700
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 965C28A1C82;
	Tue, 24 Sep 2019 23:43:04 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-118.rdu2.redhat.com [10.10.120.118])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 879EA61F21;
	Tue, 24 Sep 2019 23:43:03 +0000 (UTC)
Subject: Re: [edk2-devel] [edk2/master PATCHv1 1/1] OvmfPkg: Make SOURCE_DEBUG_ENABLE actually need to be set to TRUE
To: pjones@redhat.com
Cc: devel@edk2.groups.io, Ard Biesheuvel <ard.biesheuvel@linaro.org>,
 Jordan Justen <jordan.l.justen@intel.com>
References: <20190920184507.909884-1-pjones@redhat.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <9c6d70b5-fcd6-373f-973f-044d1338e47b@redhat.com>
Date: Wed, 25 Sep 2019 01:43:02 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190920184507.909884-1-pjones@redhat.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.69]); Tue, 24 Sep 2019 23:43:04 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Peter,

thanks for the patch. Two comments:

On 09/20/19 20:45, Peter Jones wrote:
> Currently some tests check the value of SOURCE_DEBUG_ENABLE, and some
> tests check if it's defined or not.  Additionally, in UefiPayloadPkg as
> well as some other trees, we define it as FALSE in the .dsc file.
> 
> This patch changes all of the Ovmf platforms to explicitly define it as
> FALSE by default, and changes all of the checks to test if the value is
> TRUE.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1

(1) Please drop this line. (I cannot touch up this part for you.)

The Contributed-under line has not been necessary since
<https://bugzilla.tianocore.org/show_bug.cgi?id=1373> was fixed.

> Signed-off-by: Peter Jones <pjones@redhat.com>
> ---
>  OvmfPkg/OvmfPkgIa32.dsc    | 17 +++++++++--------
>  OvmfPkg/OvmfPkgIa32.fdf    |  2 +-
>  OvmfPkg/OvmfPkgIa32X64.dsc | 19 ++++++++++---------
>  OvmfPkg/OvmfPkgIa32X64.fdf |  2 +-
>  OvmfPkg/OvmfPkgX64.dsc     | 19 ++++++++++---------
>  OvmfPkg/OvmfPkgX64.fdf     |  2 +-
>  OvmfPkg/OvmfXen.dsc        | 17 +++++++++--------
>  OvmfPkg/OvmfXen.fdf        |  2 +-
>  8 files changed, 42 insertions(+), 38 deletions(-)

[...]

> diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf
> index 785affeb90c8..c7622fcfb7b0 100644
> --- a/OvmfPkg/OvmfPkgIa32.fdf
> +++ b/OvmfPkg/OvmfPkgIa32.fdf
> @@ -260,7 +260,7 @@ [FV.DXEFV]
>  INF  MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe.inf
>  
>  INF  OvmfPkg/SioBusDxe/SioBusDxe.inf
> -!ifndef $(SOURCE_DEBUG_ENABLE)
> +!if $(SOURCE_DEBUG_ENABLE) != TRUE

(2) Can you please write "== FALSE" here (in the other FDF files too)?
That has a tiny bit more precedent.

I'd be willing to fix up (2) for you just before pushing, but I can't
touch (1).

With (1) and (2) fixed, for v2:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks!
Laszlo