From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web08.1640.1619808228617636192 for ; Fri, 30 Apr 2021 11:43:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=erP0rxQC; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619808227; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o9q9hoHbaAa6z/PPvUrwu4ZXB2vBKsXkv4orpVgqa58=; b=erP0rxQC3PuTkIIXNmCt3LsLJbSVs+zpYBG3ufc35YkV/WIJ0LDOrs1Z2MysyIbhLyOHAR V7doLeOdQQfTGibrCJsqoU8F7ldSOh5vPzlYhM81b6MpGC2O0rBA4N6pp0ydaM7MIs6WrT HRh4PPTIEjsxwnUP9ixv8v3pdKGWW9Y= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-167-AeXoFNoPOO6PfSGNXlUpZQ-1; Fri, 30 Apr 2021 14:43:44 -0400 X-MC-Unique: AeXoFNoPOO6PfSGNXlUpZQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 67B4F107ACC7; Fri, 30 Apr 2021 18:43:42 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-248.ams2.redhat.com [10.36.112.248]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9D4475C232; Fri, 30 Apr 2021 18:43:32 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v3 3/5] OvmfPkg: Define a new PPI GUID to signal TPM MMIO accessability From: "Laszlo Ersek" To: devel@edk2.groups.io, thomas.lendacky@amd.com Cc: Joerg Roedel , Borislav Petkov , Ard Biesheuvel , Jordan Justen , Brijesh Singh , Erdem Aktas , James Bottomley , Jiewen Yao , Min Xu , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Stefan Berger Reply-To: devel@edk2.groups.io, lersek@redhat.com References: <03e292339273721724c8b14605cfe9d7bbe45a71.1619716333.git.thomas.lendacky@amd.com> <24ba1ef4-91f5-7fd6-9f74-c3d4c268e5ef@amd.com> <4665b01a-2a57-7d8b-7cd5-353e266cd0a1@redhat.com> Message-ID: <9c7bca35-e6e5-50f2-7f2b-7dc005941f76@redhat.com> Date: Fri, 30 Apr 2021 20:43:31 +0200 MIME-Version: 1.0 In-Reply-To: <4665b01a-2a57-7d8b-7cd5-353e266cd0a1@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 04/30/21 18:54, Laszlo Ersek wrote: > On 04/29/21 19:20, Lendacky, Thomas wrote: >> On 4/29/21 12:12 PM, Tom Lendacky wrote: >>> Define a new PPI GUID that is to be used as a signal of when it is safe >>> to access the TPM MMIO range. This is needed so that, when SEV is active, >>> the MMIO range can be mapped unencrypted before it is accessed. >>> >>> Cc: Laszlo Ersek >>> Cc: Ard Biesheuvel >>> Cc: Jordan Justen >>> Cc: Brijesh Singh >>> Cc: Erdem Aktas >>> Cc: James Bottomley >>> Cc: Jiewen Yao >>> Cc: Min Xu >>> Cc: Marc-André Lureau >>> Cc: Stefan Berger >>> Signed-off-by: Tom Lendacky >> >> Sorry, Laszlo, I forgot to include your Reviewed-by: on this patch. > > Reviewed-by: Laszlo Ersek Hrmpf, a more even workload would benefit my reviews; here I missed that we didn't add the BZ link. :/ Laszlo > > Thanks > Laszlo > >> >> Tom >> >>> --- >>> OvmfPkg/OvmfPkg.dec | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec >>> index 9629707020ba..6ae733f6e39f 100644 >>> --- a/OvmfPkg/OvmfPkg.dec >>> +++ b/OvmfPkg/OvmfPkg.dec >>> @@ -128,6 +128,10 @@ [Ppis] >>> # has been discovered and recorded >>> gOvmfTpmDiscoveredPpiGuid = {0xb9a61ad0, 0x2802, 0x41f3, {0xb5, 0x13, 0x96, 0x51, 0xce, 0x6b, 0xd5, 0x75}} >>> >>> + # This PPI signals that accessing the MMIO range of the TPM is possible in >>> + # the PEI phase, regardless of memory encryption >>> + gOvmfTpmMmioAccessiblePpiGuid = {0x35c84ff2, 0x7bfe, 0x453d, {0x84, 0x5f, 0x68, 0x3a, 0x49, 0x2c, 0xf7, 0xb7}} >>> + >>> [Protocols] >>> gVirtioDeviceProtocolGuid = {0xfa920010, 0x6785, 0x4941, {0xb6, 0xec, 0x49, 0x8c, 0x57, 0x9f, 0x16, 0x0a}} >>> gXenBusProtocolGuid = {0x3d3ca290, 0xb9a5, 0x11e3, {0xb7, 0x5d, 0xb8, 0xac, 0x6f, 0x7d, 0x65, 0xe6}} >>> >> >> >> >> >> > > > > > >