From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id A259C208AE2B8
 for <edk2-devel@lists.01.org>; Tue, 26 Feb 2019 04:31:28 -0800 (PST)
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com
 [10.5.11.13])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 1E5A930BD43A;
 Tue, 26 Feb 2019 12:31:28 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-155.rdu2.redhat.com
 [10.10.120.155])
 by smtp.corp.redhat.com (Postfix) with ESMTP id E39FA60BF0;
 Tue, 26 Feb 2019 12:31:26 +0000 (UTC)
To: Rebecca Cran <rebecca@bluestop.org>, edk2-devel@lists.01.org
Cc: Jaben Carsey <jaben.carsey@intel.com>,
 Daryl McDaniel <edk2-lists@mc2research.org>
References: <20190225183637.91406-1-rebecca@bluestop.org>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <9c7ed75b-b43d-ae8e-1e74-7a7b56d1626b@redhat.com>
Date: Tue, 26 Feb 2019 13:31:25 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190225183637.91406-1-rebecca@bluestop.org>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.46]); Tue, 26 Feb 2019 12:31:28 +0000 (UTC)
Subject: Re: [PATCH] StdLib: Update resolv.conf to use Google's public DNS servers
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Feb 2019 12:31:28 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 02/25/19 19:36, Rebecca Cran via edk2-devel wrote:
> The current servers listed appear to be unusable. I suspect most
> people will get correct DNS servers via DHCP, but the defaults
> should work for anyone.
> 
> Change the entries to be Google's public DNS servers.
> Also, change the domain name to be example.com, to be more applicable
> to consumers outside Intel.
> ---
>  StdLib/Efi/StdLib/etc/resolv.conf | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/StdLib/Efi/StdLib/etc/resolv.conf b/StdLib/Efi/StdLib/etc/resolv.conf
> index 3ac16ac230..724e6297b2 100644
> --- a/StdLib/Efi/StdLib/etc/resolv.conf
> +++ b/StdLib/Efi/StdLib/etc/resolv.conf
> @@ -1,13 +1,13 @@
>  #
>  #   Domain name
>  #
> -domain          intel.com
> +domain          example.com
>  
>  ;
>  ;   Name Servers
>  ;
> -nameserver      206.63.63.61
> -nameserver      216.251.100.1
> +nameserver      8.8.8.8
> +nameserver      8.8.4.4
>  
>  ; nameserver      10.248.2.1
>  ; nameserver      10.22.224.204
> 

Sorry for missing this earlier, but the patch misses the
Contributed-under and Signed-off-by lines, from the end of the commit
message.

Please repost like that, and then please also include the Reviewed-by
tags from Jaben and myself.

Thanks,
Laszlo