From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web10.119626.1671060103789062633
 for <devel@edk2.groups.io>;
 Wed, 14 Dec 2022 15:21:43 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=iaPdk0gE;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [192.168.4.22] (unknown [47.201.8.94])
	by linux.microsoft.com (Postfix) with ESMTPSA id 9DAA020B87DA;
	Wed, 14 Dec 2022 15:21:42 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 9DAA020B87DA
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1671060103;
	bh=RaHJT3rtr3MohB3hYQi8zS4RxwPAUqfCjaql2xTwogQ=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=iaPdk0gEnRxhoyiMQcslOu2qlJzJeo5N3Qv8otht56y79Tznys/d+jP+QPcPPhhOW
	 +jyrTe1eboSYxSiwMmr5r3N/u7H/V7X1BF/TjZbPHFwuPlvljcBAaqCHMMqRnLLkAa
	 F1QXq6EvYEdEe5WFEOliuCSt5siTzj8zeWU4kPVU=
Message-ID: <9c88fe54-5e83-fb43-b845-af4a79eaef79@linux.microsoft.com>
Date: Wed, 14 Dec 2022 18:21:41 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH v3 13/14] ArmPkg: Turn off spellcheck audit mode
To: Ard Biesheuvel <ardb@kernel.org>
Cc: devel@edk2.groups.io, Leif Lindholm <quic_llindhol@quicinc.com>,
 Ard Biesheuvel <ardb+tianocore@kernel.org>,
 Sami Mujawar <sami.mujawar@arm.com>
References: <20221214225252.1660-1-mikuback@linux.microsoft.com>
 <20221214225252.1660-14-mikuback@linux.microsoft.com>
 <CAMj1kXGvzMcCdi+zRr0yKJ6y8She9z5AqjttgX_jve65xN8Vcg@mail.gmail.com>
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
In-Reply-To: <CAMj1kXGvzMcCdi+zRr0yKJ6y8She9z5AqjttgX_jve65xN8Vcg@mail.gmail.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Yes. It will also reduce frequency of incoming patches that must be 
reviewed and merged due to people continuously fixing trivial spelling 
errors.

On 12/14/2022 6:07 PM, Ard Biesheuvel wrote:
> On Wed, 14 Dec 2022 at 23:53, <mikuback@linux.microsoft.com> wrote:
>>
>> From: Michael Kubacki <michael.kubacki@microsoft.com>
>>
>> Audit mode was enabled for the spellcheck CI plugin. It is no longer
>> needed with recent changes. Spelling errors can be checked in the
>> package moving forward.
>>
>> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> Will this patch result in PRs potentially being rejected by pre-merge
> CI due to trivial spelling errors?
> 
> 
>> ---
>>   ArmPkg/ArmPkg.ci.yaml | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/ArmPkg/ArmPkg.ci.yaml b/ArmPkg/ArmPkg.ci.yaml
>> index c8dface6821a..a304c7966cf7 100644
>> --- a/ArmPkg/ArmPkg.ci.yaml
>> +++ b/ArmPkg/ArmPkg.ci.yaml
>> @@ -87,7 +87,7 @@
>>
>>       ## options defined .pytool/Plugin/SpellCheck
>>       "SpellCheck": {
>> -        "AuditOnly": True,
>> +        "AuditOnly": False,
>>           "IgnoreFiles": [
>>               "Library/ArmSoftFloatLib/berkeley-softfloat-3/**"
>>           ],                           # use gitignore syntax to ignore errors
>> @@ -148,6 +148,7 @@
>>             "fcmplt",
>>             "ffreestanding",
>>             "frsub",
>> +          "hauser",
>>             "hisilicon",
>>             "iccabpr",
>>             "iccbpr",
>> --
>> 2.28.0.windows.1
>>