Re: [PATCH] MdeModulePkg/Core/Dxe: log informative memprotect msgs at DEBUG_INFO level

[Laszlo Ersek <lersek@redhat.com>]

On 12/05/17 04:00, Zeng, Star wrote:
> Reviewed-by: Star Zeng <star.zeng@intel.com>

Thank you both; commit a921228818b5.

Laszlo

> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com] 
> Sent: Tuesday, December 5, 2017 3:48 AM
> To: edk2-devel-01 <edk2-devel@lists.01.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Dong, Eric <eric.dong@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Gao, Liming <liming.gao@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [PATCH] MdeModulePkg/Core/Dxe: log informative memprotect msgs at DEBUG_INFO level
> 
> In commit 7eb927db3e25 ("MdeModulePkg/DxeCore: implement memory protection policy", 2017-02-24), we added two informative messages with the
> InitializeDxeNxMemoryProtectionPolicy() function:
> 
>> InitializeDxeNxMemoryProtectionPolicy: applying strict permissions to 
>> active memory regions
> 
> and
> 
>> InitializeDxeNxMemoryProtectionPolicy: applying strict permissions to 
>> inactive memory regions
> 
> The messages don't report errors or warnings, thus downgrade their log masks from DEBUG_ERROR to DEBUG_INFO.
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1520485
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c b/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c
> index 21a52d0af55a..a74cfc137a22 100644
> --- a/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c
> +++ b/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c
> @@ -831,8 +831,11 @@ InitializeDxeNxMemoryProtectionPolicy (
>    } while (Status == EFI_BUFFER_TOO_SMALL);
>    ASSERT_EFI_ERROR (Status);
>  
> -  DEBUG((DEBUG_ERROR, "%a: applying strict permissions to active memory regions\n",
> -    __FUNCTION__));
> +  DEBUG ((
> +    DEBUG_INFO,
> +    "%a: applying strict permissions to active memory regions\n",
> +    __FUNCTION__
> +    ));
>  
>    MergeMemoryMapForProtectionPolicy (MemoryMap, &MemoryMapSize, DescriptorSize);
>  
> @@ -856,9 +859,11 @@ InitializeDxeNxMemoryProtectionPolicy (
>    // accessible, but have not been added to the UEFI memory map (yet).
>    //
>    if (GetPermissionAttributeForMemoryType (EfiConventionalMemory) != 0) {
> -    DEBUG((DEBUG_ERROR,
> +    DEBUG ((
> +      DEBUG_INFO,
>        "%a: applying strict permissions to inactive memory regions\n",
> -      __FUNCTION__));
> +      __FUNCTION__
> +      ));
>  
>      CoreAcquireGcdMemoryLock ();
>  
> --
> 2.14.1.3.gb7cf6e02401b
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
>