From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 66C7320356253 for ; Tue, 5 Dec 2017 09:57:14 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 93005FC7D0; Tue, 5 Dec 2017 18:01:44 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-123-60.rdu2.redhat.com [10.10.123.60]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2A4BF66D57; Tue, 5 Dec 2017 18:01:42 +0000 (UTC) To: "Zeng, Star" , Ard Biesheuvel Cc: edk2-devel-01 , "Yao, Jiewen" , "Dong, Eric" , "Gao, Liming" References: <20171204194743.15245-1-lersek@redhat.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B9BF7B1@shsmsx102.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: <9c8bca29-744e-7097-7cdf-233be725c601@redhat.com> Date: Tue, 5 Dec 2017 19:01:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103B9BF7B1@shsmsx102.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 05 Dec 2017 18:01:44 +0000 (UTC) Subject: Re: [PATCH] MdeModulePkg/Core/Dxe: log informative memprotect msgs at DEBUG_INFO level X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Dec 2017 17:57:14 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/05/17 04:00, Zeng, Star wrote: > Reviewed-by: Star Zeng Thank you both; commit a921228818b5. Laszlo > -----Original Message----- > From: Laszlo Ersek [mailto:lersek@redhat.com] > Sent: Tuesday, December 5, 2017 3:48 AM > To: edk2-devel-01 > Cc: Ard Biesheuvel ; Dong, Eric ; Yao, Jiewen ; Gao, Liming ; Zeng, Star > Subject: [PATCH] MdeModulePkg/Core/Dxe: log informative memprotect msgs at DEBUG_INFO level > > In commit 7eb927db3e25 ("MdeModulePkg/DxeCore: implement memory protection policy", 2017-02-24), we added two informative messages with the > InitializeDxeNxMemoryProtectionPolicy() function: > >> InitializeDxeNxMemoryProtectionPolicy: applying strict permissions to >> active memory regions > > and > >> InitializeDxeNxMemoryProtectionPolicy: applying strict permissions to >> inactive memory regions > > The messages don't report errors or warnings, thus downgrade their log masks from DEBUG_ERROR to DEBUG_INFO. > > Cc: Ard Biesheuvel > Cc: Eric Dong > Cc: Jiewen Yao > Cc: Liming Gao > Cc: Star Zeng > Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1520485 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Laszlo Ersek > --- > MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c b/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c > index 21a52d0af55a..a74cfc137a22 100644 > --- a/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c > +++ b/MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c > @@ -831,8 +831,11 @@ InitializeDxeNxMemoryProtectionPolicy ( > } while (Status == EFI_BUFFER_TOO_SMALL); > ASSERT_EFI_ERROR (Status); > > - DEBUG((DEBUG_ERROR, "%a: applying strict permissions to active memory regions\n", > - __FUNCTION__)); > + DEBUG (( > + DEBUG_INFO, > + "%a: applying strict permissions to active memory regions\n", > + __FUNCTION__ > + )); > > MergeMemoryMapForProtectionPolicy (MemoryMap, &MemoryMapSize, DescriptorSize); > > @@ -856,9 +859,11 @@ InitializeDxeNxMemoryProtectionPolicy ( > // accessible, but have not been added to the UEFI memory map (yet). > // > if (GetPermissionAttributeForMemoryType (EfiConventionalMemory) != 0) { > - DEBUG((DEBUG_ERROR, > + DEBUG (( > + DEBUG_INFO, > "%a: applying strict permissions to inactive memory regions\n", > - __FUNCTION__)); > + __FUNCTION__ > + )); > > CoreAcquireGcdMemoryLock (); > > -- > 2.14.1.3.gb7cf6e02401b > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >