public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Jake Garver" <jake@nvidia.com>
To: <devel@edk2.groups.io>, <jbrasen@nvidia.com>, <ashishsingha@nvidia.com>
Cc: Jake Garver <jake@nvidia.com>
Subject: [PATCH] BaseTools/Conf: Fix Dynamic-Library-File template
Date: Thu, 7 Apr 2022 13:04:20 -0400	[thread overview]
Message-ID: <9c8bfad0f021bea4831b7d707f9e851afb0d7ad0.1649351002.git.jake@nvidia.com> (raw)

In the Dynamic-Library-File template, add missing output file
declarations.  These files are generated by the template and other rules
explicitly depend on them.

This change resolves missing dependency issues we encountered while
running a recursive make with job control.

Signed-off-by: Jake Garver <jake@nvidia.com>
---
 BaseTools/Conf/build_rule.template | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule.template
index f401182344..4356623512 100755
--- a/BaseTools/Conf/build_rule.template
+++ b/BaseTools/Conf/build_rule.template
@@ -366,6 +366,8 @@
 
     <OutputFile>
         $(OUTPUT_DIR)(+)$(MODULE_NAME).efi
+        $(DEBUG_DIR)(+)$(MODULE_NAME).efi
+        $(OUTPUT_DIR)(+)$(MODULE_NAME).map
 
     <Command.MSFT, Command.INTEL, Command.RVCT, Command.CLANGPDB>
         "$(GENFW)" -e $(MODULE_TYPE) -o ${dst} ${src} $(GENFW_FLAGS)
-- 
2.17.1


             reply	other threads:[~2022-04-07 17:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-07 17:04 Jake Garver [this message]
2022-04-26  3:52 ` [edk2-devel] [PATCH] BaseTools/Conf: Fix Dynamic-Library-File template Bob Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c8bfad0f021bea4831b7d707f9e851afb0d7ad0.1649351002.git.jake@nvidia.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox