From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::143; helo=mail-it1-x143.google.com; envelope-from=ming.huang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x143.google.com (mail-it1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A8D77201B0413 for ; Tue, 12 Feb 2019 00:06:03 -0800 (PST) Received: by mail-it1-x143.google.com with SMTP id r11so5070219itc.2 for ; Tue, 12 Feb 2019 00:06:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=mfbwXvsVQ5RBYO7hvPVfSU0+/mmazcv5s+iTEERKwpk=; b=yqct3jxZlhEkoHidDbQcb7D+MyPuq6OigbTiT9t0EnzW65m5prVKL24rfw8lYIqIef rmF8loiVPqi/hTj+/TMXvmF7n11CAUdFW5k7EQmhm2NfaQmQAFC8fDy2fAosXoBBo2fl KQM6VzziEfImOrdkG4b3Taxs+y6N8ua/bJVIQ99HYSfeNCiI49NEE9QBTx/1VaHa2Y3Y RYz24UqOFYmGD3hGRyEN+DP2EA50eavnBA9qM9QG+SLF2hWmi7VD5xZfqZZ4EZVU96NQ IgBhbdBPeH2HIyBVDSKFX2Ev+R5wLElyHzRhuei60jBt8vyWYY7teCYBl/3hXgS+P19A imQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mfbwXvsVQ5RBYO7hvPVfSU0+/mmazcv5s+iTEERKwpk=; b=BU25gyFn83BkAMOx/46TeqB7zIWpgTC593BF9H6RJXYkveUsV/cj21wdOgy0Acy6h9 yjOSPFxn1cvvQLe74huqMFLgv92aUHy+rHG0JXjzK7J1H3J859qSUEz2JRCeAAhBAL27 0PJ8OLdYe3FQT70TEbm6btjyp5CbMBWpnYLmCXgvGXCQoLeLpaKO2NbAfXPFhQD7RHrm +hdBh4l+wrJkAv50J5+M77dyAM3TY88A7KfivM2MMwiw0zwdFsgXE/O8BvCVjHuLzAL+ 6eY61ecAcyCYW0VY2yk1pPdgF/xHEdIicO3I4MGO9wGTlzWTU3l+LILG7G2fpBcgx38C 9dAw== X-Gm-Message-State: AHQUAuZ8YZMIXFeibAjfpepfXuv6YMK+CHcqHlzbbSqZPCEjhbketPgc JYtKH1VRklcPhkW4WzVCDUebRg== X-Google-Smtp-Source: AHgI3Ia7jxh9b+YuYcMJabc6XTekc2vrZeM+mGqrmZplRYsh/YfPdCbKpYkz2gDIyR0lNEZIYgEZPg== X-Received: by 2002:a5d:9812:: with SMTP id a18mr1128890iol.236.1549958762667; Tue, 12 Feb 2019 00:06:02 -0800 (PST) Received: from [10.15.0.22] ([64.64.108.250]) by smtp.gmail.com with ESMTPSA id z124sm1134408itz.42.2019.02.12.00.05.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Feb 2019 00:06:02 -0800 (PST) To: Leif Lindholm Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, zhangfeng56@huawei.com References: <20190201142507.30454-1-ming.huang@linaro.org> <20190201142507.30454-3-ming.huang@linaro.org> <20190211213608.w7zqyap6vws4lam5@bivouac.eciton.net> From: Ming Huang Message-ID: <9c8d26cd-b0bb-e573-8a12-20259271c40e@linaro.org> Date: Tue, 12 Feb 2019 16:05:50 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20190211213608.w7zqyap6vws4lam5@bivouac.eciton.net> Subject: Re: [PATCH edk2-non-osi v1 2/7] Hisilicon/D0x: Rename StartupAp() function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2019 08:06:03 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 2/12/2019 5:36 AM, Leif Lindholm wrote: > On Fri, Feb 01, 2019 at 10:25:02PM +0800, Ming Huang wrote: >> As suggestion of community, 'AP' is a bit unfortunate to use in EDK2 >> context. PI specifies 'BSP' for Boot-strap Processor, as the one >> executing all of the EDK2 code. It then uses 'AP' to refer to >> Additional Processors, which can be assigned tasks using the >> EFI_MP_SERVICES_PROTOCOL. In a TianoCore context, this should be >> 'BSP'. So, Rename StartupAp() to StartUpBSP. > > Please add a comment somewhere that this applies to D0x > PlatformSysCtrlLib. ok > >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ming Huang >> --- >> Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib | Bin 297590 -> 229128 bytes >> Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib | Bin 344310 -> 275312 bytes >> Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib | Bin 356032 -> 375916 bytes >> 3 files changed, 0 insertions(+), 0 deletions(-) > > These are substantial changes in image size from only changing the > name of a function. So I'll have a little look around. > > 1610 version appears to have switched from building with GCC49_RELEASE > to GCC48_RELEASE. > 1616 and 1620 versions seem to have used GCC48_RELEASE all along. > > I definitely see additional renamed functions in these libraries too. > > Please have an inventory and determine what may be affecting image sizes. > > Also, I *beg* you - please upgrade from "GNU C 4.8.3 20131202 (prerelease)". We have plan to upgrage gcc to 7.3, but our build server is share for all ARM project, so need discuss with other project groups, it may be not enough time for 19.02. For D05/D03 libraries, just remove 2 functions from OemMiscLib which used by PlatformSysCtrlLib. Does edk2 version effect the libraries size? old edk2 base on: 2017-0904 now edk2 base on: 2018-0801 For D06 library, we use the same source code to support all Hi1620 projects, include product projects,so there are some modify for this, like support 3 sockets, 4 sockets and remove some useless functions. Thanks. > > / > Leif > >> >> diff --git a/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib b/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib >> index 68be770..4c63a26 100644 >> Binary files a/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib and b/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib differ >> diff --git a/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib b/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib >> index b3cc88e..cb2c652 100644 >> Binary files a/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib and b/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib differ >> diff --git a/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib b/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib >> index 50d453a..d643f7b 100644 >> Binary files a/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib and b/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib differ >> -- >> 2.9.5 >>