From: "Brijesh Singh" <brijesh.singh@amd.com>
To: devel@edk2.groups.io, kraxel@redhat.com
Cc: brijesh.singh@amd.com, James Bottomley <jejb@linux.ibm.com>,
Min Xu <min.m.xu@intel.com>, Jiewen Yao <jiewen.yao@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Erdem Aktas <erdemaktas@google.com>,
Michael Roth <Michael.Roth@amd.com>
Subject: Re: [edk2-devel] [PATCH 0/2] SEV BaseMemEncryptLib cleanup
Date: Tue, 25 Jan 2022 16:09:45 -0600 [thread overview]
Message-ID: <9c9294ee-ea58-d4b0-343e-54c5f7334288@amd.com> (raw)
In-Reply-To: <20220121080454.zjzezdtqqgfqmg2c@sirius.home.kraxel.org>
On 1/21/22 2:04 AM, Gerd Hoffmann via groups.io wrote:
> On Wed, Jan 19, 2022 at 05:03:30PM -0600, Brijesh Singh wrote:
>> This is the first of cleanup for SEV MemEncryptLib. The library uses
>> the CPUID followed by the MSR read to determine whether SEV is enabled.
>>
>> Now that we have a workarea concept, the logic can be simplified to
>> store the msr status in workarea and use that to build PCDs and then
>> later simply use the PCDs instead of going through the CPUID and RDMSR.
>>
>> The complete branch is available at
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcodomania%2Fedk2%2Ftree%2Fsev-workarea-cleanup&data=04%7C01%7Cbrijesh.singh%40amd.com%7C72f26427ada24f9fc2aa08d9dcb4bc74%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637783491097406747%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=DKsibiI3OYAJkR09fMPCUz0JGyh7ZrGJGj55VmO5%2FsQ%3D&reserved=0
>>
>> Brijesh Singh (2):
>> OvmfPkg/ResetVector: cache the SEV status MSR value in workarea
>> OvmfPkg/BaseMemEncryptLib: use the SEV_STATUS MSR value from workarea
>
> Looks good to me.
>
> Acked-by: Gerd Hoffmann <kraxel@redhat.com>
>
I ran into a regression for non-SEV guest, let me work to fix and post v2.
-Brijesh
prev parent reply other threads:[~2022-01-25 22:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 23:03 [PATCH 0/2] SEV BaseMemEncryptLib cleanup Brijesh Singh
2022-01-19 23:03 ` [PATCH 1/2] OvmfPkg/ResetVector: cache the SEV status MSR value in workarea Brijesh Singh
2022-01-19 23:03 ` [PATCH 2/2] OvmfPkg/BaseMemEncryptLib: use the SEV_STATUS MSR value from workarea Brijesh Singh
2022-01-21 8:04 ` [PATCH 0/2] SEV BaseMemEncryptLib cleanup Gerd Hoffmann
2022-01-25 22:09 ` Brijesh Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c9294ee-ea58-d4b0-343e-54c5f7334288@amd.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox