From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.52]) by mx.groups.io with SMTP id smtpd.web08.4335.1643148590918254181 for ; Tue, 25 Jan 2022 14:09:51 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=sApQdNFY; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.220.52, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WzM2Q3tooU898RoUFxC0VFJID4BcrV5EEMJ/PLelucKojRBWlmJoUfPH96JGfUbjo+kxOJ0sqpeoh0/QJwY7Au5eX+Bq58iPveZSSVCQbnUpt11dd54ycqy8/PV2ddnHfN0+n9dHo0rbTom0/Y/L1PlNzMd9YOydRWtweyrbHteMapoMEjjSy82dy7++Hct6J/mNLkW5GIv0HnMIZzECbwmdXG/HW7biNU4UqmMJaWdXTwzJdGVRbCD6oB4eQMjOdWxlTJ0w/xx9KdaGPew2CITNNQR4eQYZicMItaNBYVXlir/6wEk9ai7n8ahsXhapJHPIYkSgf9ZJ0PqDGydYcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hAo3rlBFBw9DJH6Pq85hBVRYsWX9b4BUDOQSqlyQuGs=; b=oFhPgOrMaDYL9MaoKsFwYw/lRbeRDJWf3kFqlyLfVZ9inpG6kZBNxgCv0IVrSbb/10GSUfuA0uHUh//5wUu8sLp5dNHvS0A7uzTF+oESULIehd5sBlGrhvZ45dtN9J6uCEgPEhOWdUOEzfFOCac0IX5/7teb9rVh0HCObi+h9COCTLYrrJFQcRLyBFAOXr49pmjd2tR3+wgCAk7iP6E/a+S95k+tU+h6MRYhE/0u4zPYJzmdrBAs7VbP4EdhpvV4il6Yx7ai0uPmBJHFS277YcbAlItX54UxImY/FsotrkaAB8cnRoNupZTOfUmd6AqHssoSzPm8Z6c7NKAU8eWvRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hAo3rlBFBw9DJH6Pq85hBVRYsWX9b4BUDOQSqlyQuGs=; b=sApQdNFYsUPr2/LJJYYY3an55LqNQSTRUXphZfYG4OTgSpy6IlSFVucqSleChRyFwfkloFb68shubIeW7sGnlu2v1h2AjNAqLS0No+IIcL21iOY8CHFmaI+ZLBQpZ+yWr0YmM6tWj2MbGhswytb888lNU5kN71O/jEVpRuFB/tA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by BY5PR12MB4292.namprd12.prod.outlook.com (2603:10b6:a03:212::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.15; Tue, 25 Jan 2022 22:09:49 +0000 Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::35:281:b7f8:ed4c]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::35:281:b7f8:ed4c%6]) with mapi id 15.20.4909.019; Tue, 25 Jan 2022 22:09:49 +0000 Cc: brijesh.singh@amd.com, James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Erdem Aktas , Michael Roth Subject: Re: [edk2-devel] [PATCH 0/2] SEV BaseMemEncryptLib cleanup To: devel@edk2.groups.io, kraxel@redhat.com References: <20220119230332.44888-1-brijesh.singh@amd.com> <20220121080454.zjzezdtqqgfqmg2c@sirius.home.kraxel.org> From: "Brijesh Singh" Message-ID: <9c9294ee-ea58-d4b0-343e-54c5f7334288@amd.com> Date: Tue, 25 Jan 2022 16:09:45 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <20220121080454.zjzezdtqqgfqmg2c@sirius.home.kraxel.org> X-ClientProxiedBy: MN2PR20CA0055.namprd20.prod.outlook.com (2603:10b6:208:235::24) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) Return-Path: brijesh.singh@amd.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3594fb26-2b33-409e-7f83-08d9e04f6725 X-MS-TrafficTypeDiagnostic: BY5PR12MB4292:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gI5OOermx8SqRbyIB3e4CA4/hM/FxR+meNO6HKz/oncNDB0809cmXogjGkIxXMJfPuqjjKN/Nomq5fG4qmtB485fVfJWKjT2EMO4yKwccCdehDBiZA4K9mzU0pErh2N59fj4DuhaxA6dgSDQ30lCSXSeYIIvF+OL51ZLp6roJ8bIq3fiQnBXl4zLLFUUTlvW6HRpFBs7vOnJJ9oMNF3b6yLGjxGcCgnGU8ik4WI5Tqhu6yNv9nnTv6cuGSReBoUGbSBEjm1ffBjvunpPKiQPuR6zcoFU/1D6fJAiw082KgGzWA5q+xoanQ1eb2wzniOYShNyE/5X6t7K6TC0OXNfgM/TwdO9e0lPr8YKfKC/vLpeJ38CLGKDmJa9joW9VthK7f5CwApZAH02UiUHb8TeXVr1qdZONk9RVv/p0BjRhjPjQX4dodVUiaxHGm67FI0PoRvxjlYNnYObLiLiJgcE8p7gZVtiNUWVW4wY6J1VaIxF/7ZF0JbKXXOlnm7Eiho4LxI2HwploDytjkijFsIsjZLE98AyvJWgCndJ2gyUaGbuJx4ecu79JRdvOg8wi5Qv674cR1CtWk8ZaWGEZwMYB6WiBAJWr2zPSHesJzccrOOp0XdwtuDpiDGgwV0GeJ4OCClHUxCox5zzFyInW9L40PwMJqLP4M4FNPf4J7e1EPHI5IdpL5YOpUWJoHSYBzyYYHbQSVkDjEKIhkyiIup52NdZ41uKoktcjqpnEjiNuDezFrgiGAPOGl6bV8osg/wY6u0+j/WCB7+PXpkYic6fDeivfmaX6P4QpF60U9NRjK02f7qTO4Jmx/AD9Qtse2FL X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2718.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(31686004)(5660300002)(44832011)(966005)(6486002)(8936002)(4326008)(8676002)(66476007)(36756003)(38100700002)(86362001)(66556008)(2906002)(54906003)(508600001)(45080400002)(31696002)(66946007)(316002)(2616005)(53546011)(26005)(6512007)(6506007)(186003)(6666004)(45980500001)(43740500002)(20210929001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bXI0NmVnS0JXNHRzQ043eGpxcW9sejNGd2JDVmxUR3FtcjcrSVdlYVBoRENN?= =?utf-8?B?ekRzRnZZWTZUdkRaTXJtUzRDTjh4WEFLMFhmaVV4UkZzcWx6L1ZDZXFKZkQ2?= =?utf-8?B?aURiMnpqcXFTSWZGS0hGblJud3N5dE1JUlNpVVV5NWFaMlpSTzIzY2tITTBR?= =?utf-8?B?YzJ1cTVCRGk3QndvSzRBbU5zZVdFdGYvY0RNaUlOclBxZjY5ckRoanhSZytv?= =?utf-8?B?VmQ1cUdSb3hUTFNnNmlMS1J6UitOc3BuQ0loRTUzVFRHbGF0eTRITktaUExF?= =?utf-8?B?OVlkdUhQME1udUQ3NmltdnVHOUs0ZE1xclUvSjFTUDNKRGJjVmE4Q3VjdG9r?= =?utf-8?B?aGtmMUh4UVNabmJib2JOTnA3b1RoUUN0SDhPUXdURlgvbG1lLzdtNTlkeVlU?= =?utf-8?B?RDcycnlJTkdLdzF4NExvQWFFMnZnOHkrK1lONUlzVGJHU3hvQkxRM2drYXVV?= =?utf-8?B?Z0VaVCtkOXpDZWdyVlNtQnkrRE1KU0pZeDRiZTU3Tm5BY0NsSHV6VE9JS1ZP?= =?utf-8?B?RWVydDEzQWFwajA2Y3Q5TzdIOWZndm1lM0FYNGFxaXpEaHUyZU8zWG42YzQ5?= =?utf-8?B?MmRQRmxIQzZBMWV5bUo5a0pOSkhxQmJPQkNsV09vMmIwQ2lxK2xSYVBReGdl?= =?utf-8?B?MFNqK1hEYnB3UTlvdzdFZEttdjNpcUd1US8vSkgreGdPVDd6aVJFb2NadTFW?= =?utf-8?B?eGNUV0htSmREU1M3V20ySklnOXhuMzhhZFhBMzhwZFdPdnNZQi9ScEhZcUNi?= =?utf-8?B?Ri9UTElzbTFtSDVSTHBRMWZmUzVSWVIwL3NseWIxeWZjRXo1VkQ4blJGeUxx?= =?utf-8?B?RnpyaFQ5QVNnekFDaDlRZzl0QTdHQ1lxdGdhd3ZXMnp2bjFqcVA4VUVDdU9J?= =?utf-8?B?OGFyREcxUXppanFWMDdtU0ExSkVBamV1bWJEZlZ0SXVBdGh2QzVZb2FCbC95?= =?utf-8?B?RUxqdFhvRVZoRkw3dGg1b1lORTk5cnB0S2pDL1dtQ1NpdFExTEFIMmEzNWx2?= =?utf-8?B?NmN1MWdVVVpVNjlkc0FMMHRjbitCWis2Vk5wODZsZTZhcW1STXR0T1VhbWM0?= =?utf-8?B?QWdHdUQ2d0Z5ZWhiQVJRV3p1ZW1sSXVFdndPemdPdHJ4UXF4ZStDSThFam1l?= =?utf-8?B?YW1UbjZ1bE1aNHFCamVZSVZPbmJvSnhuZHhBeDhpV0h0Sk95cEdXM3hRN0pY?= =?utf-8?B?TmRpTk9sQ0Z3RzdxM3hiVG00YlpJWloyYlMrQk4rdjZhV0d4bUhRRkROei9W?= =?utf-8?B?RklDYWJ3VzlSZ0s2Z0wxY3FvN0xuTEt6SXk2SmRUUzNhdmEwK2hPRUo1N3p5?= =?utf-8?B?ZEdvKy8zNnVYR1BzZGl3aGprZFZ0a0swbWdQejh1VC91TFRrNXFMQWxHVm14?= =?utf-8?B?L0hQWURJNGtRdk54QUxXWHV3dnIraDBUR0dwQ0dGNlJEVWJ3dkk2aHU1T09h?= =?utf-8?B?ZzNYQVAzdGllcDU4RmFEUEhDL0ZqNFYxTUZLVXhwUjhWVmZpQ3pTSTVqOWI0?= =?utf-8?B?c1BBSXZaYlMzSG9NNjZ0VUN1MzZEK1ArSktYN0hSZElTQXhsczFFMXZYT1pU?= =?utf-8?B?TDE2M3VZN013V0l1L0Z5SGNNSHNQNnRtNUVmc3ZFbG84UWdCUzFtNmluc0N4?= =?utf-8?B?SThKVUhlNHdla2ZUaThJUlYyeHpMeXcxMG42MHpPRnIxMjl1ei9UVDcyWU5x?= =?utf-8?B?bTc4b2lUZFA3SitqZTJ1UW90T0trWHQ3bSs3bmM3Z2VHeFphQVF1UFNtWnRY?= =?utf-8?B?bjNsVGpGUERNQlVIMzRRcjRrR2N0cTltSXhaNWFRYjVnWC9rbFhUcjhYRGVx?= =?utf-8?B?NVNZRVRMU1lBQ2srT2twRUNYUUY0UGhDb0RBaklhdHNwQlR3R2VaV2pJeGJJ?= =?utf-8?B?WVROU0xHaTFLd1NRSmpYN3lUMExOVXd3eUtXQ2haZkxERHVjOVlrSk9vNGNM?= =?utf-8?B?VFBRclB4cTNrNWNxTXJLQ0VsR09Bak84aEF2bExqZExUSmFIOW9nOFptMytX?= =?utf-8?B?dEpOUUFaNEFXRzM4U2srdjdIVmdieXVDdDM0YUJEYzhRMmR5dkJabGRidEdM?= =?utf-8?B?QlJKaklKSHNGV0V2UUlTU0pMSUx4aUFYSGZqTExDOU96YzRuZ3MwTjFGWVRR?= =?utf-8?B?NDdIY2pnTTlzbXZoQm5qK0ZjY3c3WSt6c2hQcDFWclVDV25MSkNoMDdXTCsx?= =?utf-8?Q?/1J30qEJ0gggEmlWxVZ1uYI=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3594fb26-2b33-409e-7f83-08d9e04f6725 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2022 22:09:48.9593 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gcDQOCMV0I+0p151LtO3M2tNgUJVilK0iumiyqy7Hb7tAATgTMoFjkg4Hg1Hhr2zk3kI47yKAh/A00RMTMB/Xw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4292 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 1/21/22 2:04 AM, Gerd Hoffmann via groups.io wrote: > On Wed, Jan 19, 2022 at 05:03:30PM -0600, Brijesh Singh wrote: >> This is the first of cleanup for SEV MemEncryptLib. The library uses >> the CPUID followed by the MSR read to determine whether SEV is enabled. >> >> Now that we have a workarea concept, the logic can be simplified to >> store the msr status in workarea and use that to build PCDs and then >> later simply use the PCDs instead of going through the CPUID and RDMSR. >> >> The complete branch is available at >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcodomania%2Fedk2%2Ftree%2Fsev-workarea-cleanup&data=04%7C01%7Cbrijesh.singh%40amd.com%7C72f26427ada24f9fc2aa08d9dcb4bc74%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637783491097406747%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=DKsibiI3OYAJkR09fMPCUz0JGyh7ZrGJGj55VmO5%2FsQ%3D&reserved=0 >> >> Brijesh Singh (2): >> OvmfPkg/ResetVector: cache the SEV status MSR value in workarea >> OvmfPkg/BaseMemEncryptLib: use the SEV_STATUS MSR value from workarea > > Looks good to me. > > Acked-by: Gerd Hoffmann > I ran into a regression for non-SEV guest, let me work to fix and post v2. -Brijesh