Re: [edk2-devel] [PATCH 03/16] OvmfPkg/EnrollDefaultKeys: refresh INF file

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 4/27/19 2:53 AM, Laszlo Ersek wrote:
> Bump INF_VERSION to the latest edk2 INF specification.
> 
> Regenerate FILE_GUID to distinguish this application from downstream-only
> versions.
> 
> Remove the VALID_ARCHITECTURES comment as there is nothing ISA or platform
> specific in the application.
> 
> Ensure all sections apart from [Defines] are alphabetically sorted.
> 
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Julien Grall <julien.grall@arm.com>
> Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1747
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

> ---
>  OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.inf | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.inf b/OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.inf
> index 1e579f495143..3a215df50863 100644
> --- a/OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.inf
> +++ b/OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.inf
> @@ -2,33 +2,29 @@
>  #  Enroll default PK, KEK, db, dbx.
>  #
>  #  Copyright (C) 2014-2019, Red Hat, Inc.
>  #
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>  ##
>  
>  [Defines]
> -  INF_VERSION                    = 0x00010006
> +  INF_VERSION                    = 1.28
>    BASE_NAME                      = EnrollDefaultKeys
> -  FILE_GUID                      = D5C1DF0B-1BAC-4EDF-BA48-08834009CA5A
> +  FILE_GUID                      = A0BAA8A3-041D-48A8-BC87-C36D121B5E3D
>    MODULE_TYPE                    = UEFI_APPLICATION
>    VERSION_STRING                 = 0.1
>    ENTRY_POINT                    = ShellCEntryLib
>  
> -#
> -#  VALID_ARCHITECTURES           = IA32 X64
> -#
> -
>  [Sources]
>    EnrollDefaultKeys.c
>  
>  [Packages]
> -  MdePkg/MdePkg.dec
>    MdeModulePkg/MdeModulePkg.dec
> +  MdePkg/MdePkg.dec
>    SecurityPkg/SecurityPkg.dec
>    ShellPkg/ShellPkg.dec
>  
>  [Guids]
>    gEfiCertPkcs7Guid
>    gEfiCertSha256Guid
>    gEfiCertX509Guid
>    gEfiCustomModeEnableGuid
>