From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.85.221.65, mailfrom: philmd@redhat.com) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by groups.io with SMTP; Mon, 29 Apr 2019 05:25:10 -0700 Received: by mail-wr1-f65.google.com with SMTP id k16so15739015wrn.5 for ; Mon, 29 Apr 2019 05:25:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7mleX1jaTojrcscpAmWFWdtFFFgpm5jcR6AjYnCQdjA=; b=c3xDMOX0gZo8+6x9XI2OzWOMMiGQuTplfGyZB3WE8o9WI7TEDzKE3mAXJNwEIQauGO 05aladbfvyLXZ9FZ9d3q41FG17+TQ7TEUIbjjoDLghSw2qUh/NaxJRTT6q3SSXqmFIxn c9BiNj8fD00y+4QXtcTHyf1dkfYJiUpCGkpmkCP8R+GQ/HwH9nZdxfuJkAzIHdNfoLIJ s2Yc3CqTHtNfPLhnOLZecEqe9cusgzahV2079PSLJIaHgUzm/TUKhJkN4QMEFQjtMDiw Ncs+4A3Id/Xolf1oe+u9Bc1o1MsrkQoZm5Bw68WsS3puzGjyJIAjwPVW1jkpUzLFwNvk Lccw== X-Gm-Message-State: APjAAAWqljaRjXZQJUdJXmdg8qEF5E1/k8JE8CnEdDKMg0LLj1n8nO3+ 77JGrM9R/N/nL1cy0y0xEUYKNw== X-Google-Smtp-Source: APXvYqxm+xh4+n6EdOzqfgw6Evzv9LpUqGTZL+vl1bqAW1PjrD5ZvrV9aTyYbNx5inTsy9UvnHoIsA== X-Received: by 2002:a5d:414d:: with SMTP id c13mr850080wrq.210.1556540708788; Mon, 29 Apr 2019 05:25:08 -0700 (PDT) Return-Path: Received: from [192.168.1.33] (193.red-88-21-103.staticip.rima-tde.net. [88.21.103.193]) by smtp.gmail.com with ESMTPSA id v5sm2464845wra.83.2019.04.29.05.25.07 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 29 Apr 2019 05:25:08 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 03/16] OvmfPkg/EnrollDefaultKeys: refresh INF file To: devel@edk2.groups.io, lersek@redhat.com Cc: Anthony Perard , Ard Biesheuvel , Jordan Justen , Julien Grall References: <20190427005328.27005-1-lersek@redhat.com> <20190427005328.27005-4-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: <9ca1d0d5-9fd6-c369-e408-4d9eab5348c9@redhat.com> Date: Mon, 29 Apr 2019 14:25:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190427005328.27005-4-lersek@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 4/27/19 2:53 AM, Laszlo Ersek wrote: > Bump INF_VERSION to the latest edk2 INF specification. > > Regenerate FILE_GUID to distinguish this application from downstream-only > versions. > > Remove the VALID_ARCHITECTURES comment as there is nothing ISA or platform > specific in the application. > > Ensure all sections apart from [Defines] are alphabetically sorted. > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1747 > Signed-off-by: Laszlo Ersek Reviewed-by: Philippe Mathieu-Daude > --- > OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.inf | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.inf b/OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.inf > index 1e579f495143..3a215df50863 100644 > --- a/OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.inf > +++ b/OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.inf > @@ -2,33 +2,29 @@ > # Enroll default PK, KEK, db, dbx. > # > # Copyright (C) 2014-2019, Red Hat, Inc. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > ## > > [Defines] > - INF_VERSION = 0x00010006 > + INF_VERSION = 1.28 > BASE_NAME = EnrollDefaultKeys > - FILE_GUID = D5C1DF0B-1BAC-4EDF-BA48-08834009CA5A > + FILE_GUID = A0BAA8A3-041D-48A8-BC87-C36D121B5E3D > MODULE_TYPE = UEFI_APPLICATION > VERSION_STRING = 0.1 > ENTRY_POINT = ShellCEntryLib > > -# > -# VALID_ARCHITECTURES = IA32 X64 > -# > - > [Sources] > EnrollDefaultKeys.c > > [Packages] > - MdePkg/MdePkg.dec > MdeModulePkg/MdeModulePkg.dec > + MdePkg/MdePkg.dec > SecurityPkg/SecurityPkg.dec > ShellPkg/ShellPkg.dec > > [Guids] > gEfiCertPkcs7Guid > gEfiCertSha256Guid > gEfiCertX509Guid > gEfiCustomModeEnableGuid >