From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web11.169.1571761242518312806 for ; Tue, 22 Oct 2019 09:20:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IL4+i4Vy; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571761241; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XNuJ2Rh7JYdE3ioHyXlgn7OVGuK28Et+MZCO1cNlLWM=; b=IL4+i4VykTiXt+o7ft7//uKtrBgbRZsXwOJbaNtREPdZB9Ob2KrrJS8MTEJKoKasO17hbK vU8C26JxQhFn+xX+hQxp1i0tTc3UVqsPbYKbHfBA8GEHJdb/t9yph0U0qZJMSIQFHKXEGr wPqkaaLnLa8UmW0bwiWLVCApCULkgmM= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-260-19robqA2Moq2Xlq3Uh4Ozw-1; Tue, 22 Oct 2019 12:20:39 -0400 Received: by mail-wm1-f72.google.com with SMTP id s19so6133815wmj.0 for ; Tue, 22 Oct 2019 09:20:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EDWeBtKW1F8F70+NNUMGe8NDOCi+j752sVmbCWkFf0U=; b=EAjEqaIaFEqlM1n2da9i3Kkls8N804m8Bqb0t7IPVXVT5huT1nUSl1GilqePTli4OY O6A0TmSECVjo/fptvshlFHOmP9abiTBu2UKbBulPKQ/2es0EK82EuKGVeXZ0eKB9ZNNH R3PQ5BF7CCsArpLuRdTbkNTvW0GkABDx4Syh0/m0avf6DodEYk4XlwTRy/8s31sqOMMC dt+brGYGWvGxgaxx4ftp/RaXNndsC3MqJ47JLnZcSSJtoh1OY7gaHk8LJhUQgAqjXr/t cf5QxCl48j40Q8U6yhHFGd05r0emxln5Ukji5RGpQwpsXxChZVqSJnWp4iYtjn8XvmTF B++Q== X-Gm-Message-State: APjAAAU46OxU7nzysbloAJBOJkOz1SRRJYDyzlqotx6hdCNWvSmZA/DC zTiHmnt8s4BJM6xoLqge0DxD1ioRdKhGmJlfHE90MDNHoXeBUqe0/4oJPVVeH66DALdFP/+krUu txq2GSR0SnB0Wyw== X-Received: by 2002:a05:600c:253:: with SMTP id 19mr3541852wmj.158.1571761238170; Tue, 22 Oct 2019 09:20:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqxnQnL4UrBcPwGE541hY0vTR3TuxfuRBMI+FspvnOAZb3ZxE9QYKixVJiuE6IPAco1ehuYMng== X-Received: by 2002:a05:600c:253:: with SMTP id 19mr3541830wmj.158.1571761237827; Tue, 22 Oct 2019 09:20:37 -0700 (PDT) Return-Path: Received: from [192.168.1.41] (129.red-83-57-174.dynamicip.rima-tde.net. [83.57.174.129]) by smtp.gmail.com with ESMTPSA id b196sm12147695wmd.24.2019.10.22.09.20.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Oct 2019 09:20:37 -0700 (PDT) Subject: Re: [edk2-devel] [Patch] SecurityPkg: Fix spelling errors To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: Sean Brogan , "Yao, Jiewen" , "Wang, Jian J" , "Zhang, Chao B" References: <20191018190138.25544-1-michael.d.kinney@intel.com> <48a2b100-4460-17a3-4a31-e71ce85de4a1@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <9cb863e5-9ada-e180-38a3-eebf29f8f739@redhat.com> Date: Tue, 22 Oct 2019 18:20:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: X-MC-Unique: 19robqA2Moq2Xlq3Uh4Ozw-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 10/22/19 6:08 PM, Michael D Kinney wrote: > Response below. >=20 > Mike >=20 >> -----Original Message----- >> From: Philippe Mathieu-Daud=C3=A9 >> Sent: Tuesday, October 22, 2019 5:41 AM >> To: devel@edk2.groups.io; Kinney, Michael D >> >> Cc: Sean Brogan ; Yao, >> Jiewen ; Wang, Jian J >> ; Zhang, Chao B >> >> Subject: Re: [edk2-devel] [Patch] SecurityPkg: Fix >> spelling errors >> >> Hi Michael, >> >> Few review comment below. >> >> On 10/18/19 9:01 PM, Michael D Kinney wrote: >>> From: Sean Brogan >>> >>> https://bugzilla.tianocore.org/show_bug.cgi?id=3D2265 >>> >>> Cc: Jiewen Yao >>> Cc: Jian J Wang >>> Cc: Chao Zhang >>> Signed-off-by: Michael D Kinney >> >>> --- [...] >>> --- a/SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c >>> +++ b/SecurityPkg/Tcg/MemoryOverwriteControl/TcgMor.c >>> @@ -1,7 +1,7 @@ >>> /** @file >>> TCG MOR (Memory Overwrite Request) Control >> Driver. >>> >>> - This driver initilize >> MemoryOverwriteRequestControl variable. It >>> + This driver initialize >> MemoryOverwriteRequestControl variable. It >>> will clear MOR_CLEAR_MEMORY_BIT bit if it is set. >> It will also do TPer Reset for >>> those encrypted drives through >> EFI_STORAGE_SECURITY_COMMAND_PROTOCOL at EndOfDxe. >>> >>> @@ -298,7 +298,7 @@ TPerResetAtEndOfDxe ( >>> @param[in] ImageHandle Image handle of this >> driver. >>> @param[in] SystemTable A Pointer to the EFI >> System Table. >>> >>> - @retval EFI_SUCEESS >>> + @retval EFI_SUCCESS >>> @return Others Some error occurs. >>> **/ >>> EFI_STATUS >>> @@ -341,7 +341,7 @@ MorDriverEntryPoint ( >>> // >>> // Create a Ready To Boot Event and Clear the >> MorControl bit in the call back function. >>> // >>> - DEBUG ((EFI_D_INFO, "TcgMor: Create ReadyToBoot >> Event for MorControl Bit cleanning!\n")); >>> + DEBUG ((DEBUG_INFO, "TcgMor: Create ReadyToBoot >> Event for MorControl Bit cleaning!\n")); >> >> Hmm this is not a spelling change... >=20 > The original fix from Sean is for cleanning -> cleaning. > PatchCheck.py gets an error on this patch because EFI_D_ERROR > should not be used, so I added the change to use DEBUG_INFO > to pass PatchCheck.py. I see. Since you need to respin to fix the "Volume" typo, do you mind=20 adding a preliminary patch doing the EFI_D_INFO -> DEBUG_INFO conversion=20 to satisfy PatchCheck.py, then the spelling changes? [...] >>> @@ -146,7 +146,7 @@ EFI_PEI_NOTIFY_DESCRIPTOR >> mNotifyList[] =3D { >>> }; >>> >>> /** >>> - Record all measured Firmware Volum Information >> into a Guid Hob >>> + Record all measured Firmware Voluem Information >> into a Guid Hob >> >> Typo "Volume" >> >>> Guid Hob payload layout is >>> >>> UINT32 *************************** >> FIRMWARE_BLOB number >>> @@ -501,7 +501,7 @@ MeasureMainBios ( >>> } >>> >>> /** >>> - Measure and record the Firmware Volum Information >> once FvInfoPPI install. >>> + Measure and record the Firmware Voluem Information >> once FvInfoPPI install. >> >> Ditto "Volume"