From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, hao.a.wu@intel.com
Cc: Ray Ni <ray.ni@intel.com>, Andrew Fish <afish@apple.com>,
Leif Lindholm <leif.lindholm@linaro.org>,
Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules
Date: Mon, 27 May 2019 19:02:58 +0200 [thread overview]
Message-ID: <9cd511ef-cbc1-4ff6-185b-8bf052f0ab7a@redhat.com> (raw)
In-Reply-To: <86cf0526-9b9e-17cc-5eb4-1648615c0d5a@redhat.com>
On 05/27/19 18:56, Laszlo Ersek wrote:
> On 05/27/19 08:36, Wu, Hao A wrote:
>> '''
>> Please note that this patch will be hold until all the below requirements
>> are met:
>>
>> A. edk2-stable201905 is created;
>> B. OvmfPkg has drop its usage of the legacy ISA stack (which includes
>> the IsaAcpiDxe driver);
>> C. UefiPayloadPkg has been updated to drop its consume to the
>> 8259InterruptControllerDxe driver.
>> '''
>>
>> This patch itself will not be sent to the mailing list and is only
>> available at:
>> https://github.com/hwu25/edk2/tree/delete_framework
>> (https://github.com/hwu25/edk2/commit/84e58f89f6d03f9cc3399cced9d5d5529e06a416)
>>
>>
>> Below modules will be removed from PcAtChipsetPkg:
>> * PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
>> * PcAtChipsetPkg/8254TimerDxe/8254Timer.inf
>> * PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf
>>
>> They are considered legacy framework components and will no longer be used
>> after the removal of IntelFramework[Module]Pkg.
>>
>> Also, the unused (after the modules being removed) PCDs will be deleted in
>> package level DEC/UNI files.
>
> Please include a reference to
> <https://bugzilla.tianocore.org/show_bug.cgi?id=1844> in the commit message.
Sorry, I missed that the patch was not sent to the list -- but I've now
checked in your personal repo, and the BZ reference is already there in
the commit message.
Thanks
Laszlo
>
> (I might comment more later; not sure just yet.)
>
> Thanks
> Laszlo
>
>>
>> Cc: Ray Ni <ray.ni@intel.com>
>> Cc: Andrew Fish <afish@apple.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>
>>
>> Hao A Wu (1):
>> PcAtChipsetPkg: Remove framework modules
>>
>> PcAtChipsetPkg/PcAtChipsetPkg.dec | 58 --
>> PcAtChipsetPkg/PcAtChipsetPkg.dsc | 5 +-
>> PcAtChipsetPkg/8254TimerDxe/8254Timer.inf | 42 --
>> PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf | 46 --
>> PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf | 50 --
>> PcAtChipsetPkg/8254TimerDxe/Timer.h | 185 ------
>> PcAtChipsetPkg/8259InterruptControllerDxe/8259.h | 220 -------
>> PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.h | 269 ---------
>> PcAtChipsetPkg/8254TimerDxe/Timer.c | 401 -------------
>> PcAtChipsetPkg/8259InterruptControllerDxe/8259.c | 622 --------------------
>> PcAtChipsetPkg/IsaAcpiDxe/ComponentName.c | 301 ----------
>> PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.c | 353 -----------
>> PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.c | 386 ------------
>> PcAtChipsetPkg/8254TimerDxe/Timer.uni | 16 -
>> PcAtChipsetPkg/8254TimerDxe/TimerExtra.uni | 14 -
>> PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259.uni | 16 -
>> PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259Extra.uni | 14 -
>> PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.uni | 16 -
>> PcAtChipsetPkg/IsaAcpiDxe/IsaAcpiExtra.uni | 14 -
>> PcAtChipsetPkg/PcAtChipsetPkg.uni | 52 +-
>> 20 files changed, 2 insertions(+), 3078 deletions(-)
>> delete mode 100644 PcAtChipsetPkg/8254TimerDxe/8254Timer.inf
>> delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf
>> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf
>> delete mode 100644 PcAtChipsetPkg/8254TimerDxe/Timer.h
>> delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/8259.h
>> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.h
>> delete mode 100644 PcAtChipsetPkg/8254TimerDxe/Timer.c
>> delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/8259.c
>> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/ComponentName.c
>> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.c
>> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.c
>> delete mode 100644 PcAtChipsetPkg/8254TimerDxe/Timer.uni
>> delete mode 100644 PcAtChipsetPkg/8254TimerDxe/TimerExtra.uni
>> delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259.uni
>> delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259Extra.uni
>> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.uni
>> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpiExtra.uni
>>
>
next prev parent reply other threads:[~2019-05-27 17:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 6:36 [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules Wu, Hao A
2019-05-27 16:56 ` [edk2-devel] " Laszlo Ersek
2019-05-27 17:02 ` Laszlo Ersek [this message]
2019-06-13 15:00 ` Laszlo Ersek
2019-06-25 8:03 ` Ni, Ray
2019-06-27 1:01 ` Wu, Hao A
2019-06-25 8:06 ` Wu, Hao A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cd511ef-cbc1-4ff6-185b-8bf052f0ab7a@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox