From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Mon, 27 May 2019 10:03:23 -0700 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 807F97FD6C; Mon, 27 May 2019 17:03:03 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-23.rdu2.redhat.com [10.10.120.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id 90C5260142; Mon, 27 May 2019 17:02:59 +0000 (UTC) Subject: Re: [edk2-devel] [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules From: "Laszlo Ersek" To: devel@edk2.groups.io, hao.a.wu@intel.com Cc: Ray Ni , Andrew Fish , Leif Lindholm , Michael D Kinney References: <20190527063656.9996-1-hao.a.wu@intel.com> <86cf0526-9b9e-17cc-5eb4-1648615c0d5a@redhat.com> Message-ID: <9cd511ef-cbc1-4ff6-185b-8bf052f0ab7a@redhat.com> Date: Mon, 27 May 2019 19:02:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <86cf0526-9b9e-17cc-5eb4-1648615c0d5a@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 27 May 2019 17:03:10 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05/27/19 18:56, Laszlo Ersek wrote: > On 05/27/19 08:36, Wu, Hao A wrote: >> ''' >> Please note that this patch will be hold until all the below requirements >> are met: >> >> A. edk2-stable201905 is created; >> B. OvmfPkg has drop its usage of the legacy ISA stack (which includes >> the IsaAcpiDxe driver); >> C. UefiPayloadPkg has been updated to drop its consume to the >> 8259InterruptControllerDxe driver. >> ''' >> >> This patch itself will not be sent to the mailing list and is only >> available at: >> https://github.com/hwu25/edk2/tree/delete_framework >> (https://github.com/hwu25/edk2/commit/84e58f89f6d03f9cc3399cced9d5d5529e06a416) >> >> >> Below modules will be removed from PcAtChipsetPkg: >> * PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf >> * PcAtChipsetPkg/8254TimerDxe/8254Timer.inf >> * PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf >> >> They are considered legacy framework components and will no longer be used >> after the removal of IntelFramework[Module]Pkg. >> >> Also, the unused (after the modules being removed) PCDs will be deleted in >> package level DEC/UNI files. > > Please include a reference to > in the commit message. Sorry, I missed that the patch was not sent to the list -- but I've now checked in your personal repo, and the BZ reference is already there in the commit message. Thanks Laszlo > > (I might comment more later; not sure just yet.) > > Thanks > Laszlo > >> >> Cc: Ray Ni >> Cc: Andrew Fish >> Cc: Laszlo Ersek >> Cc: Leif Lindholm >> Cc: Michael D Kinney >> >> >> Hao A Wu (1): >> PcAtChipsetPkg: Remove framework modules >> >> PcAtChipsetPkg/PcAtChipsetPkg.dec | 58 -- >> PcAtChipsetPkg/PcAtChipsetPkg.dsc | 5 +- >> PcAtChipsetPkg/8254TimerDxe/8254Timer.inf | 42 -- >> PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf | 46 -- >> PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf | 50 -- >> PcAtChipsetPkg/8254TimerDxe/Timer.h | 185 ------ >> PcAtChipsetPkg/8259InterruptControllerDxe/8259.h | 220 ------- >> PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.h | 269 --------- >> PcAtChipsetPkg/8254TimerDxe/Timer.c | 401 ------------- >> PcAtChipsetPkg/8259InterruptControllerDxe/8259.c | 622 -------------------- >> PcAtChipsetPkg/IsaAcpiDxe/ComponentName.c | 301 ---------- >> PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.c | 353 ----------- >> PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.c | 386 ------------ >> PcAtChipsetPkg/8254TimerDxe/Timer.uni | 16 - >> PcAtChipsetPkg/8254TimerDxe/TimerExtra.uni | 14 - >> PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259.uni | 16 - >> PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259Extra.uni | 14 - >> PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.uni | 16 - >> PcAtChipsetPkg/IsaAcpiDxe/IsaAcpiExtra.uni | 14 - >> PcAtChipsetPkg/PcAtChipsetPkg.uni | 52 +- >> 20 files changed, 2 insertions(+), 3078 deletions(-) >> delete mode 100644 PcAtChipsetPkg/8254TimerDxe/8254Timer.inf >> delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/8259.inf >> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.inf >> delete mode 100644 PcAtChipsetPkg/8254TimerDxe/Timer.h >> delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/8259.h >> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.h >> delete mode 100644 PcAtChipsetPkg/8254TimerDxe/Timer.c >> delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/8259.c >> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/ComponentName.c >> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.c >> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/PcatIsaAcpi.c >> delete mode 100644 PcAtChipsetPkg/8254TimerDxe/Timer.uni >> delete mode 100644 PcAtChipsetPkg/8254TimerDxe/TimerExtra.uni >> delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259.uni >> delete mode 100644 PcAtChipsetPkg/8259InterruptControllerDxe/Legacy8259Extra.uni >> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpi.uni >> delete mode 100644 PcAtChipsetPkg/IsaAcpiDxe/IsaAcpiExtra.uni >> >